arm64: qcom: don't select HAVE_PWRCTL when PCI=n

[PATCH] arm64: qcom: don't select HAVE_PWRCTL when PCI=n

Posted by Arnd Bergmann 1 year, 5 months ago

From: Arnd Bergmann <arnd@arndb.de>

The new HAVE_PWRCTL option is defined in the PCI subsystem, so
selecting it unconditionally when PCI is disabled causes a harmless
warning:

WARNING: unmet direct dependencies detected for HAVE_PWRCTL
  Depends on [n]: PCI [=n]
  Selected by [y]:
  - ARCH_QCOM [=y]

Add 'if PCI' in the qualcomm platform to hide the warning.

Fixes: ed70aaac7c35 ("Kconfig: reduce the amount of power sequencing noise")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 arch/arm64/Kconfig.platforms | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms
index 9b62c63781ec..6c6d11536b42 100644
--- a/arch/arm64/Kconfig.platforms
+++ b/arch/arm64/Kconfig.platforms
@@ -266,7 +266,7 @@ config ARCH_QCOM
 	bool "Qualcomm Platforms"
 	select GPIOLIB
 	select PINCTRL
-	select HAVE_PWRCTL
+	select HAVE_PWRCTL if PCI
 	help
 	  This enables support for the ARMv8 based Qualcomm chipsets.
 
-- 
2.39.2

Re: [PATCH] arm64: qcom: don't select HAVE_PWRCTL when PCI=n

Posted by Bartosz Golaszewski 1 year, 5 months ago

On Fri, Jul 19, 2024 at 9:28 AM Arnd Bergmann <arnd@kernel.org> wrote:
>
> From: Arnd Bergmann <arnd@arndb.de>
>
> The new HAVE_PWRCTL option is defined in the PCI subsystem, so
> selecting it unconditionally when PCI is disabled causes a harmless
> warning:
>
> WARNING: unmet direct dependencies detected for HAVE_PWRCTL
>   Depends on [n]: PCI [=n]
>   Selected by [y]:
>   - ARCH_QCOM [=y]
>
> Add 'if PCI' in the qualcomm platform to hide the warning.
>
> Fixes: ed70aaac7c35 ("Kconfig: reduce the amount of power sequencing noise")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  arch/arm64/Kconfig.platforms | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms
> index 9b62c63781ec..6c6d11536b42 100644
> --- a/arch/arm64/Kconfig.platforms
> +++ b/arch/arm64/Kconfig.platforms
> @@ -266,7 +266,7 @@ config ARCH_QCOM
>         bool "Qualcomm Platforms"
>         select GPIOLIB
>         select PINCTRL
> -       select HAVE_PWRCTL
> +       select HAVE_PWRCTL if PCI
>         help
>           This enables support for the ARMv8 based Qualcomm chipsets.
>
> --
> 2.39.2
>
>

I applied it manually. For some reason b4 cannot grab this from lore.

Bartosz