arm64: dts: mediatek: mt8186-corsola: Update ADSP reserved memory region

[PATCH] arm64: dts: mediatek: mt8186-corsola: Update ADSP reserved memory region

Posted by Fei Shao 2 months ago

Corsola firmware reserves the memory region of [0x60000000, 0x61100000)
exclusively for ADSP usage.
But in fact, a 6 MB "hole" of [0x60A00000, 0x61000000) didn't get
assigned to the ADSP node in the Corsola device tree, meaning no audio
tasks can access and utilize that memory section.

Update the reserved ADSP memory region to fill the gap.

Fixes: 8855d01fb81f ("arm64: dts: mediatek: Add MT8186 Krabby platform based Tentacruel / Tentacool")
Signed-off-by: Fei Shao <fshao@chromium.org>
---

 arch/arm64/boot/dts/mediatek/mt8186-corsola.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/mediatek/mt8186-corsola.dtsi b/arch/arm64/boot/dts/mediatek/mt8186-corsola.dtsi
index afdab5724eaa..0c4a26117428 100644
--- a/arch/arm64/boot/dts/mediatek/mt8186-corsola.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8186-corsola.dtsi
@@ -169,7 +169,7 @@ adsp_dma_mem: memory@61000000 {
 
 		adsp_mem: memory@60000000 {
 			compatible = "shared-dma-pool";
-			reg = <0 0x60000000 0 0xA00000>;
+			reg = <0 0x60000000 0 0x1000000>;
 			no-map;
 		};
 
-- 
2.45.2.1089.g2a221341d9-goog

Re: [PATCH] arm64: dts: mediatek: mt8186-corsola: Update ADSP reserved memory region

Posted by AngeloGioacchino Del Regno 1 month, 2 weeks ago

On Fri, 19 Jul 2024 12:58:04 +0800, Fei Shao wrote:
> Corsola firmware reserves the memory region of [0x60000000, 0x61100000)
> exclusively for ADSP usage.
> But in fact, a 6 MB "hole" of [0x60A00000, 0x61000000) didn't get
> assigned to the ADSP node in the Corsola device tree, meaning no audio
> tasks can access and utilize that memory section.
> 
> Update the reserved ADSP memory region to fill the gap.
> 
> [...]

Applied to v6.11-next/dts64, thanks!

[1/1] arm64: dts: mediatek: mt8186-corsola: Update ADSP reserved memory region
      commit: d03521e6c18f62876b3b5c1fbf37e0d8ab9fd1b8

Cheers,
Angelo

Re: [PATCH] arm64: dts: mediatek: mt8186-corsola: Update ADSP reserved memory region

Posted by AngeloGioacchino Del Regno 2 months ago

Il 19/07/24 06:58, Fei Shao ha scritto:
> Corsola firmware reserves the memory region of [0x60000000, 0x61100000)

Sorry but if the region is supposed to be 0x1100000 long....

> exclusively for ADSP usage.
> But in fact, a 6 MB "hole" of [0x60A00000, 0x61000000) didn't get
> assigned to the ADSP node in the Corsola device tree, meaning no audio
> tasks can access and utilize that memory section.
> 
> Update the reserved ADSP memory region to fill the gap.
> 
> Fixes: 8855d01fb81f ("arm64: dts: mediatek: Add MT8186 Krabby platform based Tentacruel / Tentacool")
> Signed-off-by: Fei Shao <fshao@chromium.org>
> ---
> 
>   arch/arm64/boot/dts/mediatek/mt8186-corsola.dtsi | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/mediatek/mt8186-corsola.dtsi b/arch/arm64/boot/dts/mediatek/mt8186-corsola.dtsi
> index afdab5724eaa..0c4a26117428 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8186-corsola.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8186-corsola.dtsi
> @@ -169,7 +169,7 @@ adsp_dma_mem: memory@61000000 {
>   
>   		adsp_mem: memory@60000000 {
>   			compatible = "shared-dma-pool";
> -			reg = <0 0x60000000 0 0xA00000>;
> +			reg = <0 0x60000000 0 0x1000000>;

...why are you making it 0x1000000 long?

Cheers,
Angelo

>   			no-map;
>   		};
>

Re: [PATCH] arm64: dts: mediatek: mt8186-corsola: Update ADSP reserved memory region

Posted by Fei Shao 1 month, 4 weeks ago

On Fri, Jul 19, 2024 at 5:22 PM AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com> wrote:
>
> Il 19/07/24 06:58, Fei Shao ha scritto:
> > Corsola firmware reserves the memory region of [0x60000000, 0x61100000)
>
> Sorry but if the region is supposed to be 0x1100000 long....
>
> > exclusively for ADSP usage.
> > But in fact, a 6 MB "hole" of [0x60A00000, 0x61000000) didn't get
> > assigned to the ADSP node in the Corsola device tree, meaning no audio
> > tasks can access and utilize that memory section.
> >
> > Update the reserved ADSP memory region to fill the gap.
> >
> > Fixes: 8855d01fb81f ("arm64: dts: mediatek: Add MT8186 Krabby platform based Tentacruel / Tentacool")
> > Signed-off-by: Fei Shao <fshao@chromium.org>
> > ---
> >
> >   arch/arm64/boot/dts/mediatek/mt8186-corsola.dtsi | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm64/boot/dts/mediatek/mt8186-corsola.dtsi b/arch/arm64/boot/dts/mediatek/mt8186-corsola.dtsi
> > index afdab5724eaa..0c4a26117428 100644
> > --- a/arch/arm64/boot/dts/mediatek/mt8186-corsola.dtsi
> > +++ b/arch/arm64/boot/dts/mediatek/mt8186-corsola.dtsi
> > @@ -169,7 +169,7 @@ adsp_dma_mem: memory@61000000 {
> >
> >               adsp_mem: memory@60000000 {
> >                       compatible = "shared-dma-pool";
> > -                     reg = <0 0x60000000 0 0xA00000>;
> > +                     reg = <0 0x60000000 0 0x1000000>;
>
> ...why are you making it 0x1000000 long?

Because 0x61000000-0x61100000 belongs to another existing region,
`adsp_dma_mem`.
It's slightly confusing because the diff doesn't show that directly...
here's its snippet for ref:

adsp_dma_mem: memory@61000000 {
        compatible = "shared-dma-pool";
        reg = <0 0x61000000 0 0x100000>;
        no-map;
};

Regards,
Fei
>
> Cheers,
> Angelo
>
> >                       no-map;
> >               };
> >
>
>

Re: [PATCH] arm64: dts: mediatek: mt8186-corsola: Update ADSP reserved memory region

Posted by AngeloGioacchino Del Regno 1 month, 4 weeks ago

Il 22/07/24 05:37, Fei Shao ha scritto:
> On Fri, Jul 19, 2024 at 5:22 PM AngeloGioacchino Del Regno
> <angelogioacchino.delregno@collabora.com> wrote:
>>
>> Il 19/07/24 06:58, Fei Shao ha scritto:
>>> Corsola firmware reserves the memory region of [0x60000000, 0x61100000)
>>
>> Sorry but if the region is supposed to be 0x1100000 long....
>>
>>> exclusively for ADSP usage.
>>> But in fact, a 6 MB "hole" of [0x60A00000, 0x61000000) didn't get
>>> assigned to the ADSP node in the Corsola device tree, meaning no audio
>>> tasks can access and utilize that memory section.
>>>
>>> Update the reserved ADSP memory region to fill the gap.
>>>
>>> Fixes: 8855d01fb81f ("arm64: dts: mediatek: Add MT8186 Krabby platform based Tentacruel / Tentacool")
>>> Signed-off-by: Fei Shao <fshao@chromium.org>
>>> ---
>>>
>>>    arch/arm64/boot/dts/mediatek/mt8186-corsola.dtsi | 2 +-
>>>    1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/arch/arm64/boot/dts/mediatek/mt8186-corsola.dtsi b/arch/arm64/boot/dts/mediatek/mt8186-corsola.dtsi
>>> index afdab5724eaa..0c4a26117428 100644
>>> --- a/arch/arm64/boot/dts/mediatek/mt8186-corsola.dtsi
>>> +++ b/arch/arm64/boot/dts/mediatek/mt8186-corsola.dtsi
>>> @@ -169,7 +169,7 @@ adsp_dma_mem: memory@61000000 {
>>>
>>>                adsp_mem: memory@60000000 {
>>>                        compatible = "shared-dma-pool";
>>> -                     reg = <0 0x60000000 0 0xA00000>;
>>> +                     reg = <0 0x60000000 0 0x1000000>;
>>
>> ...why are you making it 0x1000000 long?
> 
> Because 0x61000000-0x61100000 belongs to another existing region,
> `adsp_dma_mem`.
> It's slightly confusing because the diff doesn't show that directly...
> here's its snippet for ref:
> 

Oh, sorry about that, that's right.

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>

> adsp_dma_mem: memory@61000000 {
>          compatible = "shared-dma-pool";
>          reg = <0 0x61000000 0 0x100000>;
>          no-map;
> };
> 
> Regards,
> Fei
>>
>> Cheers,
>> Angelo
>>
>>>                        no-map;
>>>                };
>>>
>>
>>