[v1] ThinkPad T14s Gen 6 support

[PATCH 0/3] ThinkPad T14s Gen 6 support

Posted by Konrad Dybcio 9 months, 2 weeks ago

As good as the other X1 laptops

See this page for more hw info:

https://www.lenovo.com/us/en/p/laptops/thinkpad/thinkpadt/lenovo-thinkpad-t14s-gen-6-(14-inch-snapdragon)/len101t0099

Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
Konrad Dybcio (3):
      dt-bindings: arm: qcom: Add Lenovo ThinkPad T14s Gen 6
      firmware: qcom: scm: Allow QSEECOM on ThinkPad T14s
      arm64: dts: qcom: Add X1E78100 ThinkPad T14s Gen 6

 Documentation/devicetree/bindings/arm/qcom.yaml    |   6 +
 arch/arm64/boot/dts/qcom/Makefile                  |   1 +
 .../dts/qcom/x1e78100-lenovo-thinkpad-t14s.dts     | 792 +++++++++++++++++++++
 drivers/firmware/qcom/qcom_scm.c                   |   1 +
 4 files changed, 800 insertions(+)
---
base-commit: 523b23f0bee3014a7a752c9bb9f5c54f0eddae88
change-id: 20240719-topic-t14s_upstream-e53fcd0ccd2a

Best regards,
-- 
Konrad Dybcio <konrad.dybcio@linaro.org>

Re: [PATCH 0/3] ThinkPad T14s Gen 6 support

Posted by Rob Herring (Arm) 9 months, 2 weeks ago

On Fri, 19 Jul 2024 22:16:35 +0200, Konrad Dybcio wrote:
> As good as the other X1 laptops
> 
> See this page for more hw info:
> 
> https://www.lenovo.com/us/en/p/laptops/thinkpad/thinkpadt/lenovo-thinkpad-t14s-gen-6-(14-inch-snapdragon)/len101t0099
> 
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> ---
> Konrad Dybcio (3):
>       dt-bindings: arm: qcom: Add Lenovo ThinkPad T14s Gen 6
>       firmware: qcom: scm: Allow QSEECOM on ThinkPad T14s
>       arm64: dts: qcom: Add X1E78100 ThinkPad T14s Gen 6
> 
>  Documentation/devicetree/bindings/arm/qcom.yaml    |   6 +
>  arch/arm64/boot/dts/qcom/Makefile                  |   1 +
>  .../dts/qcom/x1e78100-lenovo-thinkpad-t14s.dts     | 792 +++++++++++++++++++++
>  drivers/firmware/qcom/qcom_scm.c                   |   1 +
>  4 files changed, 800 insertions(+)
> ---
> base-commit: 523b23f0bee3014a7a752c9bb9f5c54f0eddae88
> change-id: 20240719-topic-t14s_upstream-e53fcd0ccd2a
> 
> Best regards,
> --
> Konrad Dybcio <konrad.dybcio@linaro.org>
> 
> 
> 


My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade


New warnings running 'make CHECK_DTBS=y qcom/x1e78100-lenovo-thinkpad-t14s.dtb' for 20240719-topic-t14s_upstream-v1-0-d7d97fdebb28@linaro.org:

arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dtb: domain-idle-states: cluster-sleep-0: 'idle-state-name' does not match any of the regexes: 'pinctrl-[0-9]+'
	from schema $id: http://devicetree.org/schemas/power/domain-idle-state.yaml#
arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dtb: domain-idle-states: cluster-sleep-1: 'idle-state-name' does not match any of the regexes: 'pinctrl-[0-9]+'
	from schema $id: http://devicetree.org/schemas/power/domain-idle-state.yaml#
arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dtb: pci@1bf8000: Unevaluated properties are not allowed ('vddpe-3v3-supply' was unexpected)
	from schema $id: http://devicetree.org/schemas/pci/qcom,pcie-x1e80100.yaml#
arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dtb: usb@a2f8800: interrupt-names: ['pwr_event', 'dp_hs_phy_irq', 'dm_hs_phy_irq'] is too short
	from schema $id: http://devicetree.org/schemas/usb/qcom,dwc3.yaml#

Re: (subset) [PATCH 0/3] ThinkPad T14s Gen 6 support

Posted by Bjorn Andersson 9 months, 1 week ago

On Fri, 19 Jul 2024 22:16:35 +0200, Konrad Dybcio wrote:
> As good as the other X1 laptops
> 
> See this page for more hw info:
> 
> https://www.lenovo.com/us/en/p/laptops/thinkpad/thinkpadt/lenovo-thinkpad-t14s-gen-6-(14-inch-snapdragon)/len101t0099
> 
> 
> [...]

Applied, thanks!

[2/3] firmware: qcom: scm: Allow QSEECOM on ThinkPad T14s
      commit: e6b5a4c3ae3b883cb13be2e1cd9fbf364928173e

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>

Re: (subset) [PATCH 0/3] ThinkPad T14s Gen 6 support

Posted by Rob Herring 8 months, 3 weeks ago

On Sun, Jul 28, 2024 at 9:58 PM Bjorn Andersson <andersson@kernel.org> wrote:
>
>
> On Fri, 19 Jul 2024 22:16:35 +0200, Konrad Dybcio wrote:
> > As good as the other X1 laptops
> >
> > See this page for more hw info:
> >
> > https://www.lenovo.com/us/en/p/laptops/thinkpad/thinkpadt/lenovo-thinkpad-t14s-gen-6-(14-inch-snapdragon)/len101t0099
> >
> >
> > [...]
>
> Applied, thanks!
>
> [2/3] firmware: qcom: scm: Allow QSEECOM on ThinkPad T14s
>       commit: e6b5a4c3ae3b883cb13be2e1cd9fbf364928173e

Now "lenovo,thinkpad-t14s" is listed as undocumented.

Rob

Re: (subset) [PATCH 0/3] ThinkPad T14s Gen 6 support

Posted by Rob Herring 8 months, 1 week ago

On Fri, Aug 16, 2024 at 11:30 AM Rob Herring <robh@kernel.org> wrote:
>
> On Sun, Jul 28, 2024 at 9:58 PM Bjorn Andersson <andersson@kernel.org> wrote:
> >
> >
> > On Fri, 19 Jul 2024 22:16:35 +0200, Konrad Dybcio wrote:
> > > As good as the other X1 laptops
> > >
> > > See this page for more hw info:
> > >
> > > https://www.lenovo.com/us/en/p/laptops/thinkpad/thinkpadt/lenovo-thinkpad-t14s-gen-6-(14-inch-snapdragon)/len101t0099
> > >
> > >
> > > [...]
> >
> > Applied, thanks!
> >
> > [2/3] firmware: qcom: scm: Allow QSEECOM on ThinkPad T14s
> >       commit: e6b5a4c3ae3b883cb13be2e1cd9fbf364928173e
>
> Now "lenovo,thinkpad-t14s" is listed as undocumented.

Still an issue in linux-next.

Rob