selftest: x86: improve tests

[PATCH v3 0/4] selftest: x86: improve tests

Posted by Muhammad Usama Anjum 1 year, 5 months ago

Changes since v1:
- Correct the description of patches with what improvements they are
  bringing and why they are required

Changes since v2:
- Update descriptions of patches and add output before/after

Muhammad Usama Anjum (4):
  selftests: x86: check_initial_reg_state: remove manual counting and
    increase maintainability
  selftests: x86: corrupt_xstate_header: remove manual counting and
    increase maintainability
  selftests: x86: fsgsbase_restore: remove manual counting and increase
    maintainability
  selftests: x86: entry_from_vm86: remove manual counting and increase
    maintainability

 .../selftests/x86/check_initial_reg_state.c   |  24 ++--
 .../selftests/x86/corrupt_xstate_header.c     |  30 +++--
 tools/testing/selftests/x86/entry_from_vm86.c | 109 ++++++++--------
 .../testing/selftests/x86/fsgsbase_restore.c  | 117 +++++++++---------
 4 files changed, 139 insertions(+), 141 deletions(-)

-- 
2.39.2

Re: [PATCH v3 0/4] selftest: x86: improve tests

Posted by Shuah Khan 1 year, 5 months ago

On 7/18/24 05:32, Muhammad Usama Anjum wrote:
> Changes since v1:
> - Correct the description of patches with what improvements they are
>    bringing and why they are required
> 
> Changes since v2:
> - Update descriptions of patches and add output before/after
> 
> Muhammad Usama Anjum (4):
>    selftests: x86: check_initial_reg_state: remove manual counting and
>      increase maintainability
>    selftests: x86: corrupt_xstate_header: remove manual counting and
>      increase maintainability
>    selftests: x86: fsgsbase_restore: remove manual counting and increase
>      maintainability
>    selftests: x86: entry_from_vm86: remove manual counting and increase
>      maintainability
> 
>   .../selftests/x86/check_initial_reg_state.c   |  24 ++--
>   .../selftests/x86/corrupt_xstate_header.c     |  30 +++--
>   tools/testing/selftests/x86/entry_from_vm86.c | 109 ++++++++--------
>   .../testing/selftests/x86/fsgsbase_restore.c  | 117 +++++++++---------
>   4 files changed, 139 insertions(+), 141 deletions(-)
> 

I am still not convinced what how these changes improve reporting
over running "make kselftest TARGETS=x86"

thanks,
-- Shuah