[PATCH net-next V2 0/4] Add support to PHYLINK for LAN743x/PCI11x1x chips

Raju Lakkaraju posted 4 patches 1 year, 5 months ago
There is a newer version of this series
drivers/net/ethernet/microchip/Kconfig        |   5 +-
.../net/ethernet/microchip/lan743x_ethtool.c  | 118 +---
drivers/net/ethernet/microchip/lan743x_main.c | 657 +++++++++++-------
drivers/net/ethernet/microchip/lan743x_main.h |   7 +
4 files changed, 460 insertions(+), 327 deletions(-)
[PATCH net-next V2 0/4] Add support to PHYLINK for LAN743x/PCI11x1x chips
Posted by Raju Lakkaraju 1 year, 5 months ago
This is the follow-up patch series of
https://lkml.iu.edu/hypermail/linux/kernel/2310.2/02078.html

Divide the PHYLINK adaptation and SFP modifications into two separate patch
series.

The current patch series focuses on transitioning the LAN743x driver's PHY
support from phylib to phylink.

Tested on chip PCI11010 Rev-B with Bridgeport Evaluation board Rev-1

Change List:
============
V1 ->V2:
  - Fix the Russell King's comments i.e. remove the speed, duplex update in 
    lan743x_phylink_mac_config( )
  - pre-March 2020 legacy support has been removed

V0 -> V1:
  - Integrate with Synopsys DesignWare XPCS drivers
  - Based on external review comments,
  - Changes made to SGMII interface support only 1G/100M/10M bps speed
  - Changes made to 2500Base-X interface support only 2.5Gbps speed
  - Add check for not is_sgmii_en with is_sfp_support_en support
  - Change the "pci11x1x_strap_get_status" function return type from void to
    int
  - Add ethtool phylink wol, eee, pause get/set functions


Raju Lakkaraju (4):
  net: lan743x: Create separate PCS power reset function
  net: lan743x: Create separate Link Speed Duplex state function
  net: lan743x: Migrate phylib to phylink
  net: lan743x: Add support to ethtool phylink get and set settings

 drivers/net/ethernet/microchip/Kconfig        |   5 +-
 .../net/ethernet/microchip/lan743x_ethtool.c  | 118 +---
 drivers/net/ethernet/microchip/lan743x_main.c | 657 +++++++++++-------
 drivers/net/ethernet/microchip/lan743x_main.h |   7 +
 4 files changed, 460 insertions(+), 327 deletions(-)

-- 
2.34.1
Re: [PATCH net-next V2 0/4] Add support to PHYLINK for LAN743x/PCI11x1x chips
Posted by Jiri Pirko 1 year, 5 months ago
Tue, Jul 16, 2024 at 01:33:45PM CEST, Raju.Lakkaraju@microchip.com wrote:
>This is the follow-up patch series of
>https://lkml.iu.edu/hypermail/linux/kernel/2310.2/02078.html
>
>Divide the PHYLINK adaptation and SFP modifications into two separate patch
>series.
>
>The current patch series focuses on transitioning the LAN743x driver's PHY
>support from phylib to phylink.
>
>Tested on chip PCI11010 Rev-B with Bridgeport Evaluation board Rev-1
>
>Change List:
>============
>V1 ->V2:
>  - Fix the Russell King's comments i.e. remove the speed, duplex update in 
>    lan743x_phylink_mac_config( )
>  - pre-March 2020 legacy support has been removed
>
>V0 -> V1:
>  - Integrate with Synopsys DesignWare XPCS drivers
>  - Based on external review comments,
>  - Changes made to SGMII interface support only 1G/100M/10M bps speed
>  - Changes made to 2500Base-X interface support only 2.5Gbps speed
>  - Add check for not is_sgmii_en with is_sfp_support_en support
>  - Change the "pci11x1x_strap_get_status" function return type from void to
>    int
>  - Add ethtool phylink wol, eee, pause get/set functions

Net-next is closed. Please repost once it opens again.


>
>
>Raju Lakkaraju (4):
>  net: lan743x: Create separate PCS power reset function
>  net: lan743x: Create separate Link Speed Duplex state function
>  net: lan743x: Migrate phylib to phylink
>  net: lan743x: Add support to ethtool phylink get and set settings
>
> drivers/net/ethernet/microchip/Kconfig        |   5 +-
> .../net/ethernet/microchip/lan743x_ethtool.c  | 118 +---
> drivers/net/ethernet/microchip/lan743x_main.c | 657 +++++++++++-------
> drivers/net/ethernet/microchip/lan743x_main.h |   7 +
> 4 files changed, 460 insertions(+), 327 deletions(-)
>
>-- 
>2.34.1
>
>
Re: [PATCH net-next V2 0/4] Add support to PHYLINK for LAN743x/PCI11x1x chips
Posted by Paolo Abeni 1 year, 5 months ago
On 7/16/24 13:33, Raju Lakkaraju wrote:
> This is the follow-up patch series of
> https://lkml.iu.edu/hypermail/linux/kernel/2310.2/02078.html
> 
> Divide the PHYLINK adaptation and SFP modifications into two separate patch
> series.
> 
> The current patch series focuses on transitioning the LAN743x driver's PHY
> support from phylib to phylink.
> 
> Tested on chip PCI11010 Rev-B with Bridgeport Evaluation board Rev-1

## Form letter - net-next-closed

The merge window for v6.11 and therefore net-next is closed for new
drivers, features, code refactoring and optimizations. We are currently
accepting bug fixes only.

Please repost when net-next reopens after July 29th.

RFC patches sent for review only are obviously welcome at any time.

See:
https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#development-cycle
-- 
pw-bot: defer
Re: [PATCH net-next V2 0/4] Add support to PHYLINK for LAN743x/PCI11x1x chips
Posted by Andrew Lunn 1 year, 5 months ago
On Tue, Jul 16, 2024 at 05:03:45PM +0530, Raju Lakkaraju wrote:
> This is the follow-up patch series of
> https://lkml.iu.edu/hypermail/linux/kernel/2310.2/02078.html
> 
> Divide the PHYLINK adaptation and SFP modifications into two separate patch
> series.

You appear to be missing the PHYLINK maintainer in your Cc: list.

	Andrew
Re: [PATCH net-next V2 0/4] Add support to PHYLINK for LAN743x/PCI11x1x chips
Posted by Raju Lakkaraju 1 year, 5 months ago
Hi Andrew,

Thank you for review the patches.

The 07/18/2024 05:27, Andrew Lunn wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> On Tue, Jul 16, 2024 at 05:03:45PM +0530, Raju Lakkaraju wrote:
> > This is the follow-up patch series of
> > https://lkml.iu.edu/hypermail/linux/kernel/2310.2/02078.html
> >
> > Divide the PHYLINK adaptation and SFP modifications into two separate patch
> > series.
> 
> You appear to be missing the PHYLINK maintainer in your Cc: list.
> 
I add all PHYLINK maintainers email id's in cc

i.e.
$ ./scripts/get_maintainer.pl drivers/net/phy/phylink.c
Russell King <linux@armlinux.org.uk> (maintainer:SFF/SFP/SFP+ MODULE SUPPORT)
Andrew Lunn <andrew@lunn.ch> (maintainer:ETHERNET PHY LIBRARY)
Heiner Kallweit <hkallweit1@gmail.com> (maintainer:ETHERNET PHY LIBRARY)
"David S. Miller" <davem@davemloft.net> (maintainer:NETWORKING DRIVERS)
Eric Dumazet <edumazet@google.com> (maintainer:NETWORKING DRIVERS)
Jakub Kicinski <kuba@kernel.org> (maintainer:NETWORKING DRIVERS)
Paolo Abeni <pabeni@redhat.com> (maintainer:NETWORKING DRIVERS)
netdev@vger.kernel.org (open list:SFF/SFP/SFP+ MODULE SUPPORT)
linux-kernel@vger.kernel.org (open list)

Do i need to add any more PHY maintainer id's apart from above list ?

>         Andrew

-- 
Thanks,                                                                         
Raju
Re: [PATCH net-next V2 0/4] Add support to PHYLINK for LAN743x/PCI11x1x chips
Posted by Andrew Lunn 1 year, 5 months ago
On Thu, Jul 18, 2024 at 10:38:52AM +0530, Raju Lakkaraju wrote:
> Hi Andrew,
> 
> Thank you for review the patches.
> 
> The 07/18/2024 05:27, Andrew Lunn wrote:
> > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> > 
> > On Tue, Jul 16, 2024 at 05:03:45PM +0530, Raju Lakkaraju wrote:
> > > This is the follow-up patch series of
> > > https://lkml.iu.edu/hypermail/linux/kernel/2310.2/02078.html
> > >
> > > Divide the PHYLINK adaptation and SFP modifications into two separate patch
> > > series.
> > 
> > You appear to be missing the PHYLINK maintainer in your Cc: list.
> > 
> I add all PHYLINK maintainers email id's in cc
> 
> i.e.
> $ ./scripts/get_maintainer.pl drivers/net/phy/phylink.c
> Russell King <linux@armlinux.org.uk> (maintainer:SFF/SFP/SFP+ MODULE SUPPORT)

Yes, sorry, Russell is on the list. My error.

richardcochran@gmail.com is a bit odd, is PTP involved here?

	Andrew