[PATCH] perf inject: Convert comma to semicolon

Chen Ni posted 1 patch 1 year, 5 months ago
tools/perf/builtin-inject.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] perf inject: Convert comma to semicolon
Posted by Chen Ni 1 year, 5 months ago
Replace a comma between expression statements by a semicolon.

Fixes: 97406a7e4fa6 ("perf inject: Add support for injecting guest sideband events")
Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
---
 tools/perf/builtin-inject.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/builtin-inject.c b/tools/perf/builtin-inject.c
index a212678d47be..7b4a5d56d279 100644
--- a/tools/perf/builtin-inject.c
+++ b/tools/perf/builtin-inject.c
@@ -2069,7 +2069,7 @@ static int __cmd_inject(struct perf_inject *inject)
 		 */
 		inject->tool.finished_init	= host__finished_init;
 		/* Obey finished round ordering */
-		inject->tool.finished_round	= host__finished_round,
+		inject->tool.finished_round	= host__finished_round;
 		/* Keep track of which CPU a VCPU is runnng on */
 		inject->tool.context_switch	= host__context_switch;
 		/*
-- 
2.25.1
Re: [PATCH] perf inject: Convert comma to semicolon
Posted by Arnaldo Carvalho de Melo 1 year, 4 months ago
On Tue, Jul 16, 2024 at 03:53:47PM +0800, Chen Ni wrote:
> Replace a comma between expression statements by a semicolon.
> 
> Fixes: 97406a7e4fa6 ("perf inject: Add support for injecting guest sideband events")
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>

Thanks, applied to tmp.perf-tools-next, again removed the fixes.

- Arnaldo
> ---
>  tools/perf/builtin-inject.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/builtin-inject.c b/tools/perf/builtin-inject.c
> index a212678d47be..7b4a5d56d279 100644
> --- a/tools/perf/builtin-inject.c
> +++ b/tools/perf/builtin-inject.c
> @@ -2069,7 +2069,7 @@ static int __cmd_inject(struct perf_inject *inject)
>  		 */
>  		inject->tool.finished_init	= host__finished_init;
>  		/* Obey finished round ordering */
> -		inject->tool.finished_round	= host__finished_round,
> +		inject->tool.finished_round	= host__finished_round;
>  		/* Keep track of which CPU a VCPU is runnng on */
>  		inject->tool.context_switch	= host__context_switch;
>  		/*
> -- 
> 2.25.1
Re: [PATCH] perf inject: Convert comma to semicolon
Posted by Ian Rogers 1 year, 5 months ago
On Tue, Jul 16, 2024 at 12:55 AM Chen Ni <nichen@iscas.ac.cn> wrote:
>
> Replace a comma between expression statements by a semicolon.
>
> Fixes: 97406a7e4fa6 ("perf inject: Add support for injecting guest sideband events")
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>

Reviewed-by: Ian Rogers <irogers@google.com>

Thanks,
Ian

> ---
>  tools/perf/builtin-inject.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/builtin-inject.c b/tools/perf/builtin-inject.c
> index a212678d47be..7b4a5d56d279 100644
> --- a/tools/perf/builtin-inject.c
> +++ b/tools/perf/builtin-inject.c
> @@ -2069,7 +2069,7 @@ static int __cmd_inject(struct perf_inject *inject)
>                  */
>                 inject->tool.finished_init      = host__finished_init;
>                 /* Obey finished round ordering */
> -               inject->tool.finished_round     = host__finished_round,
> +               inject->tool.finished_round     = host__finished_round;
>                 /* Keep track of which CPU a VCPU is runnng on */
>                 inject->tool.context_switch     = host__context_switch;
>                 /*
> --
> 2.25.1
>