perf daemon: Convert comma to semicolon

[PATCH] perf daemon: Convert comma to semicolon

Posted by Chen Ni 1 year, 5 months ago

Replace a comma between expression statements by a semicolon.

Fixes: 2d6914cd59ff ("perf daemon: Add 'signal' command")
Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
---
 tools/perf/builtin-daemon.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/builtin-daemon.c b/tools/perf/builtin-daemon.c
index de76bbc50bfb..18f7f417ba11 100644
--- a/tools/perf/builtin-daemon.c
+++ b/tools/perf/builtin-daemon.c
@@ -1433,7 +1433,7 @@ static int __cmd_signal(struct daemon *daemon, struct option parent_options[],
 	}
 
 	memset(&cmd, 0, sizeof(cmd));
-	cmd.signal.cmd = CMD_SIGNAL,
+	cmd.signal.cmd = CMD_SIGNAL;
 	cmd.signal.sig = SIGUSR2;
 	strncpy(cmd.signal.name, name, sizeof(cmd.signal.name) - 1);
 
-- 
2.25.1

Re: [PATCH] perf daemon: Convert comma to semicolon

Posted by Ian Rogers 1 year, 5 months ago

On Tue, Jul 16, 2024 at 12:46 AM Chen Ni <nichen@iscas.ac.cn> wrote:
>
> Replace a comma between expression statements by a semicolon.
>
> Fixes: 2d6914cd59ff ("perf daemon: Add 'signal' command")
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>

Reviewed-by: Ian Rogers <irogers@google.com>

Thanks,
Ian

> ---
>  tools/perf/builtin-daemon.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/builtin-daemon.c b/tools/perf/builtin-daemon.c
> index de76bbc50bfb..18f7f417ba11 100644
> --- a/tools/perf/builtin-daemon.c
> +++ b/tools/perf/builtin-daemon.c
> @@ -1433,7 +1433,7 @@ static int __cmd_signal(struct daemon *daemon, struct option parent_options[],
>         }
>
>         memset(&cmd, 0, sizeof(cmd));
> -       cmd.signal.cmd = CMD_SIGNAL,
> +       cmd.signal.cmd = CMD_SIGNAL;
>         cmd.signal.sig = SIGUSR2;
>         strncpy(cmd.signal.name, name, sizeof(cmd.signal.name) - 1);
>
> --
> 2.25.1
>

Re: [PATCH] perf daemon: Convert comma to semicolon

Posted by Arnaldo Carvalho de Melo 1 year, 4 months ago

On Tue, Jul 16, 2024 at 06:33:34AM -0700, Ian Rogers wrote:
> On Tue, Jul 16, 2024 at 12:46 AM Chen Ni <nichen@iscas.ac.cn> wrote:
> >
> > Replace a comma between expression statements by a semicolon.
> >
> > Fixes: 2d6914cd59ff ("perf daemon: Add 'signal' command")
> > Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
> 
> Reviewed-by: Ian Rogers <irogers@google.com>

Thanks, applied to tmp.perf-tools-next, and also removed the fixes tag.

- Arnaldo
 
> Thanks,
> Ian
> 
> > ---
> >  tools/perf/builtin-daemon.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/perf/builtin-daemon.c b/tools/perf/builtin-daemon.c
> > index de76bbc50bfb..18f7f417ba11 100644
> > --- a/tools/perf/builtin-daemon.c
> > +++ b/tools/perf/builtin-daemon.c
> > @@ -1433,7 +1433,7 @@ static int __cmd_signal(struct daemon *daemon, struct option parent_options[],
> >         }
> >
> >         memset(&cmd, 0, sizeof(cmd));
> > -       cmd.signal.cmd = CMD_SIGNAL,
> > +       cmd.signal.cmd = CMD_SIGNAL;
> >         cmd.signal.sig = SIGUSR2;
> >         strncpy(cmd.signal.name, name, sizeof(cmd.signal.name) - 1);
> >
> > --
> > 2.25.1
> >