[v1] iommu/amd: Convert comma to semicolon

[PATCH] iommu/amd: Convert comma to semicolon

Posted by Chen Ni 1 year, 5 months ago

Replace a comma between expression statements by a semicolon.

Fixes: c9b258c6be09 ("iommu/amd: Prepare for generic IO page table framework")
Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
---
 drivers/iommu/amd/io_pgtable.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/iommu/amd/io_pgtable.c b/drivers/iommu/amd/io_pgtable.c
index 9d9a7fde59e7..1074ee25064d 100644
--- a/drivers/iommu/amd/io_pgtable.c
+++ b/drivers/iommu/amd/io_pgtable.c
@@ -588,9 +588,9 @@ static struct io_pgtable *v1_alloc_pgtable(struct io_pgtable_cfg *cfg, void *coo
 {
 	struct amd_io_pgtable *pgtable = io_pgtable_cfg_to_data(cfg);
 
-	cfg->pgsize_bitmap  = AMD_IOMMU_PGSIZES,
-	cfg->ias            = IOMMU_IN_ADDR_BIT_SIZE,
-	cfg->oas            = IOMMU_OUT_ADDR_BIT_SIZE,
+	cfg->pgsize_bitmap  = AMD_IOMMU_PGSIZES;
+	cfg->ias            = IOMMU_IN_ADDR_BIT_SIZE;
+	cfg->oas            = IOMMU_OUT_ADDR_BIT_SIZE;
 	cfg->tlb            = &v1_flush_ops;
 
 	pgtable->iop.ops.map_pages    = iommu_v1_map_pages;
-- 
2.25.1

Re: [PATCH] iommu/amd: Convert comma to semicolon

Posted by Will Deacon 1 year, 4 months ago

On Tue, 16 Jul 2024 15:25:45 +0800, Chen Ni wrote:
> Replace a comma between expression statements by a semicolon.
> 
> 

Applied to iommu (next), thanks!

[1/1] iommu/amd: Convert comma to semicolon
      https://git.kernel.org/iommu/c/86c5eac3c4c4

Cheers,
-- 
Will

https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev

Re: [PATCH] iommu/amd: Convert comma to semicolon

Posted by Suthikulpanit, Suravee 1 year, 5 months ago

On 7/16/2024 2:25 PM, Chen Ni wrote:
> Replace a comma between expression statements by a semicolon.
> 
> Fixes: c9b258c6be09 ("iommu/amd: Prepare for generic IO page table framework")
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
> ---
>   drivers/iommu/amd/io_pgtable.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/iommu/amd/io_pgtable.c b/drivers/iommu/amd/io_pgtable.c
> index 9d9a7fde59e7..1074ee25064d 100644
> --- a/drivers/iommu/amd/io_pgtable.c
> +++ b/drivers/iommu/amd/io_pgtable.c
> @@ -588,9 +588,9 @@ static struct io_pgtable *v1_alloc_pgtable(struct io_pgtable_cfg *cfg, void *coo
>   {
>   	struct amd_io_pgtable *pgtable = io_pgtable_cfg_to_data(cfg);
>   
> -	cfg->pgsize_bitmap  = AMD_IOMMU_PGSIZES,
> -	cfg->ias            = IOMMU_IN_ADDR_BIT_SIZE,
> -	cfg->oas            = IOMMU_OUT_ADDR_BIT_SIZE,
> +	cfg->pgsize_bitmap  = AMD_IOMMU_PGSIZES;
> +	cfg->ias            = IOMMU_IN_ADDR_BIT_SIZE;
> +	cfg->oas            = IOMMU_OUT_ADDR_BIT_SIZE;
>   	cfg->tlb            = &v1_flush_ops;
>   
>   	pgtable->iop.ops.map_pages    = iommu_v1_map_pages;

Reviewed-by: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>

Thanks,
Suravee