[v1] bcachefs: Convert comma to semicolon

[PATCH] bcachefs: Convert comma to semicolon

Posted by Chen Ni 1 year, 5 months ago

Replace a comma between expression statements by a semicolon.

Fixes: 79032b078173 ("bcachefs: Improved topology repair checks")
Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
---
 fs/bcachefs/btree_update_interior.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/bcachefs/btree_update_interior.c b/fs/bcachefs/btree_update_interior.c
index 31ee50184be2..51b43d75ddb6 100644
--- a/fs/bcachefs/btree_update_interior.c
+++ b/fs/bcachefs/btree_update_interior.c
@@ -96,7 +96,7 @@ int bch2_btree_node_check_topology(struct btree_trans *trans, struct btree *b)
 			bch2_topology_error(c);
 
 			printbuf_reset(&buf);
-			prt_str(&buf, "end of prev node doesn't match start of next node\n"),
+			prt_str(&buf, "end of prev node doesn't match start of next node\n");
 			prt_printf(&buf, "  in btree %s level %u node ",
 				   bch2_btree_id_str(b->c.btree_id), b->c.level);
 			bch2_bkey_val_to_text(&buf, c, bkey_i_to_s_c(&b->key));
-- 
2.25.1

Re: [PATCH] bcachefs: Convert comma to semicolon

Posted by Hongbo Li 1 year, 5 months ago


On 2024/7/16 12:03, Chen Ni wrote:
> Replace a comma between expression statements by a semicolon.
> 
> Fixes: 79032b078173 ("bcachefs: Improved topology repair checks")
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
> ---
>   fs/bcachefs/btree_update_interior.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/bcachefs/btree_update_interior.c b/fs/bcachefs/btree_update_interior.c
> index 31ee50184be2..51b43d75ddb6 100644
> --- a/fs/bcachefs/btree_update_interior.c
> +++ b/fs/bcachefs/btree_update_interior.c
> @@ -96,7 +96,7 @@ int bch2_btree_node_check_topology(struct btree_trans *trans, struct btree *b)
>   			bch2_topology_error(c);
>   
>   			printbuf_reset(&buf);
> -			prt_str(&buf, "end of prev node doesn't match start of next node\n"),
> +			prt_str(&buf, "end of prev node doesn't match start of next node\n");

Reviewed-by: Hongbo Li <lihongbo22@huawei.com>

Thanks,
Hongbo
>   			prt_printf(&buf, "  in btree %s level %u node ",
>   				   bch2_btree_id_str(b->c.btree_id), b->c.level);
>   			bch2_bkey_val_to_text(&buf, c, bkey_i_to_s_c(&b->key));