[PATCH v3 0/5] Add Per-transport SCMI debug statistics

Luke Parkin posted 5 patches 1 year, 6 months ago
There is a newer version of this series
drivers/firmware/arm_scmi/Kconfig  |  11 +++
drivers/firmware/arm_scmi/common.h |   9 ++
drivers/firmware/arm_scmi/driver.c | 138 +++++++++++++++++++++++++++--
3 files changed, 150 insertions(+), 8 deletions(-)
[PATCH v3 0/5] Add Per-transport SCMI debug statistics
Posted by Luke Parkin 1 year, 6 months ago
This series adds support for tracking Arm SCMI statistics [Patch 2/3]
A config option to enable this [Patch 2]
Cleans up a unneeded call to handle_scmi_info [Patch 1]
In [Patch 4] a selection of new debugfs entries to present these statistics
Then finally in [Patch 5] enabled writing on the debugfs entries to reset stats

Based on v6.9, Tested on Arm Juno [1]

Thanks,
Luke

[1]: https://www.arm.com/products/development-tools/development-boards/juno-arm-dev-platform

V2->V3
Switch statistic counters to an array to store statistics.
Add more statistics
Add the ability to reset statistics, both individually and all
V1->V2
Add a minor fix removing an unneeded call to handle_to_scmi_info
Use new scmi_log_stats op/no-op rather than if(IS_ENABLED)
Drop unneeded atomic_set's
Use a helper function for stats debugfs creation

Luke Parkin (5):
  firmware: arm_scmi: Remove superfluous handle_to_scmi_info
  firmware: arm_scmi: Add support for tracking statistics
  firmware: arm_scmi: Track basic SCMI statistics
  firmware: arm_scmi: Create debugfs files for statistics
  firmware: arm_scmi: Reset statistics

 drivers/firmware/arm_scmi/Kconfig  |  11 +++
 drivers/firmware/arm_scmi/common.h |   9 ++
 drivers/firmware/arm_scmi/driver.c | 138 +++++++++++++++++++++++++++--
 3 files changed, 150 insertions(+), 8 deletions(-)

-- 
2.34.1
Re: [PATCH v3 0/5] Add Per-transport SCMI debug statistics
Posted by Cristian Marussi 1 year, 6 months ago
On Mon, Jul 15, 2024 at 02:37:46PM +0100, Luke Parkin wrote:
> This series adds support for tracking Arm SCMI statistics [Patch 2/3]
> A config option to enable this [Patch 2]
> Cleans up a unneeded call to handle_scmi_info [Patch 1]
> In [Patch 4] a selection of new debugfs entries to present these statistics
> Then finally in [Patch 5] enabled writing on the debugfs entries to reset stats
> 
> Based on v6.9, Tested on Arm Juno [1]
> 
> Thanks,
> Luke

Beside the specific patch review comments, I have been just reminded by
ATG that using SCMI stats is a bit ambigous since there are statistics
in the protocol...so please in v4 take care to rename all the
code/commmemts and commit msg to something else ... that could be...
"counters" ? instead of stats...so you will have debug counters available
under transport/counters instead of /stats....etc etc

Thanks,
Cristian