linux-next: build failure after merge of the ksmbd tree

Posted by Stephen Rothwell 1 year, 6 months ago

Hi all,

After merging the ksmbd tree, today's linux-next build (x86_64
allmodconfig) failed like this:

fs/smb/server/vfs_cache.c:39:27: error: 'dh_task' defined but not used [-Werror=unused-variable]
   39 | static struct task_struc *dh_task;
      |                           ^~~~~~~
cc1: all warnings being treated as errors

Caused by commit

  e70f0abc77e8 ("ksmbd: add durable scavenger timer")

I have applied the following patch for today:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Mon, 15 Jul 2024 09:55:23 +1000
Subject: [PATCH] fixup for "ksmbd: add durable scavenger timer"

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 fs/smb/server/vfs_cache.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/fs/smb/server/vfs_cache.c b/fs/smb/server/vfs_cache.c
index 2b1a5a3ebf42..4d4ee696e37c 100644
--- a/fs/smb/server/vfs_cache.c
+++ b/fs/smb/server/vfs_cache.c
@@ -36,7 +36,6 @@ static struct kmem_cache *filp_cache;
 
 static bool durable_scavenger_running;
 static DEFINE_MUTEX(durable_scavenger_lock);
-static struct task_struc *dh_task;
 static wait_queue_head_t dh_wq;
 
 void ksmbd_set_fd_limit(unsigned long limit)
-- 
2.43.0

-- 
Cheers,
Stephen Rothwell

Re: linux-next: build failure after merge of the ksmbd tree

Posted by Steve French 1 year, 6 months ago

have now updated ksmbd-for-next with the change to address this

On Sun, Jul 14, 2024 at 7:15 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
>
> After merging the ksmbd tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> fs/smb/server/vfs_cache.c:39:27: error: 'dh_task' defined but not used [-Werror=unused-variable]
>    39 | static struct task_struc *dh_task;
>       |                           ^~~~~~~
> cc1: all warnings being treated as errors
>
> Caused by commit
>
>   e70f0abc77e8 ("ksmbd: add durable scavenger timer")
>
> I have applied the following patch for today:
>
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Mon, 15 Jul 2024 09:55:23 +1000
> Subject: [PATCH] fixup for "ksmbd: add durable scavenger timer"
>
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
>  fs/smb/server/vfs_cache.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/fs/smb/server/vfs_cache.c b/fs/smb/server/vfs_cache.c
> index 2b1a5a3ebf42..4d4ee696e37c 100644
> --- a/fs/smb/server/vfs_cache.c
> +++ b/fs/smb/server/vfs_cache.c
> @@ -36,7 +36,6 @@ static struct kmem_cache *filp_cache;
>
>  static bool durable_scavenger_running;
>  static DEFINE_MUTEX(durable_scavenger_lock);
> -static struct task_struc *dh_task;
>  static wait_queue_head_t dh_wq;
>
>  void ksmbd_set_fd_limit(unsigned long limit)
> --
> 2.43.0
>
> --
> Cheers,
> Stephen Rothwell



-- 
Thanks,

Steve