drm: panel-orientation-quirks: Add quirk for OrangePi Neo

[PATCH] drm: panel-orientation-quirks: Add quirk for OrangePi Neo

Posted by Philip Mueller 1 year, 5 months ago

This adds a DMI orientation quirk for the OrangePi Neo Linux Gaming Handheld.

Signed-off-by: Philip Mueller <philm@manjaro.org>
---
 drivers/gpu/drm/drm_panel_orientation_quirks.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c
index 3860a8ce1e2d..903f4bfea7e8 100644
--- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
+++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
@@ -414,6 +414,12 @@ static const struct dmi_system_id orientation_data[] = {
 		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "ONE XPLAYER"),
 		},
 		.driver_data = (void *)&lcd1600x2560_leftside_up,
+	}, {	/* OrangePi Neo */
+		.matches = {
+		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "OrangePi"),
+		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "NEO-01"),
+		},
+		.driver_data = (void *)&lcd1200x1920_rightside_up,
 	}, {	/* Samsung GalaxyBook 10.6 */
 		.matches = {
 		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "SAMSUNG ELECTRONICS CO., LTD."),
-- 
2.45.2

Re: [PATCH] drm: panel-orientation-quirks: Add quirk for OrangePi Neo

Posted by Hans de Goede 1 year, 5 months ago

Hi,

On 7/15/24 6:57 AM, Philip Mueller wrote:
> This adds a DMI orientation quirk for the OrangePi Neo Linux Gaming Handheld.
> 
> Signed-off-by: Philip Mueller <philm@manjaro.org>

Thanks, patch looks good to me:

Reviewed-by: Hans de Goede <hdegoede@redhat.com>

I have pushed this to drm-misc-fixes now.

Regards,

Hans



> ---
>  drivers/gpu/drm/drm_panel_orientation_quirks.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c
> index 3860a8ce1e2d..903f4bfea7e8 100644
> --- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
> +++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
> @@ -414,6 +414,12 @@ static const struct dmi_system_id orientation_data[] = {
>  		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "ONE XPLAYER"),
>  		},
>  		.driver_data = (void *)&lcd1600x2560_leftside_up,
> +	}, {	/* OrangePi Neo */
> +		.matches = {
> +		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "OrangePi"),
> +		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "NEO-01"),
> +		},
> +		.driver_data = (void *)&lcd1200x1920_rightside_up,
>  	}, {	/* Samsung GalaxyBook 10.6 */
>  		.matches = {
>  		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "SAMSUNG ELECTRONICS CO., LTD."),

Re: [PATCH] drm: panel-orientation-quirks: Add quirk for OrangePi Neo

Posted by Philip Müller 1 year, 5 months ago

Hi Hans,

thx for the fast pick-up of my patch. With the first sent of my patch 
the comment landed in the subject. Seems git needed an extra empty line 
to send out the patch properly.

On 15/7/24 20:46, Hans de Goede wrote:
> Hi,
> 
> On 7/15/24 6:57 AM, Philip Mueller wrote:
>> This adds a DMI orientation quirk for the OrangePi Neo Linux Gaming Handheld.
>>
>> Signed-off-by: Philip Mueller <philm@manjaro.org>
> 
> Thanks, patch looks good to me:
> 
> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
> 
> I have pushed this to drm-misc-fixes now.
> 
> Regards,
> 
> Hans
> 
> 
> 
>> ---
>>   drivers/gpu/drm/drm_panel_orientation_quirks.c | 6 ++++++
>>   1 file changed, 6 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/drm_panel_orientation_quirks.c b/drivers/gpu/drm/drm_panel_orientation_quirks.c
>> index 3860a8ce1e2d..903f4bfea7e8 100644
>> --- a/drivers/gpu/drm/drm_panel_orientation_quirks.c
>> +++ b/drivers/gpu/drm/drm_panel_orientation_quirks.c
>> @@ -414,6 +414,12 @@ static const struct dmi_system_id orientation_data[] = {
>>   		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "ONE XPLAYER"),
>>   		},
>>   		.driver_data = (void *)&lcd1600x2560_leftside_up,
>> +	}, {	/* OrangePi Neo */
>> +		.matches = {
>> +		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "OrangePi"),
>> +		  DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "NEO-01"),
>> +		},
>> +		.driver_data = (void *)&lcd1200x1920_rightside_up,
>>   	}, {	/* Samsung GalaxyBook 10.6 */
>>   		.matches = {
>>   		  DMI_EXACT_MATCH(DMI_SYS_VENDOR, "SAMSUNG ELECTRONICS CO., LTD."),
> 

-- 
Best, Philip