[v3] Add support for SA8775P Multimedia clock controllers

[PATCH v3 8/8] arm64: dts: qcom: Update sleep_clk frequency to 32000 on SA8775P

Posted by Taniya Das 1 year, 5 months ago

The HW supported sleep_clk frequency on SA8775P is 32000, hence
update the sleep_clk frequency with the correct value on SA8775P.

Fixes: 603f96d4c9d0 ("arm64: dts: qcom: add initial support for qcom sa8775p-ride")
Signed-off-by: Taniya Das <quic_tdas@quicinc.com>
---
 arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi b/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi
index 2a6170623ea9..864ad109371c 100644
--- a/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi
+++ b/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi
@@ -517,7 +517,7 @@ &serdes1 {
 };
 
 &sleep_clk {
-	clock-frequency = <32764>;
+	clock-frequency = <32000>;
 };
 
 &spi16 {

-- 
2.45.2

Re: [PATCH v3 8/8] arm64: dts: qcom: Update sleep_clk frequency to 32000 on SA8775P

Posted by Konrad Dybcio 1 year, 5 months ago

On 15.07.2024 10:23 AM, Taniya Das wrote:
> The HW supported sleep_clk frequency on SA8775P is 32000, hence
> update the sleep_clk frequency with the correct value on SA8775P.
> 
> Fixes: 603f96d4c9d0 ("arm64: dts: qcom: add initial support for qcom sa8775p-ride")
> Signed-off-by: Taniya Das <quic_tdas@quicinc.com>
> ---

Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad

Re: [PATCH v3 8/8] arm64: dts: qcom: Update sleep_clk frequency to 32000 on SA8775P

Posted by Krzysztof Kozlowski 1 year, 5 months ago

On 15/07/2024 10:23, Taniya Das wrote:
> The HW supported sleep_clk frequency on SA8775P is 32000, hence
> update the sleep_clk frequency with the correct value on SA8775P.
> 
> Fixes: 603f96d4c9d0 ("arm64: dts: qcom: add initial support for qcom sa8775p-ride")
> Signed-off-by: Taniya Das <quic_tdas@quicinc.com>
> ---

Avoid combining fixes with features, but if you do, then fixes are never
the last patch, but first.

Best regards,
Krzysztof

Re: [PATCH v3 8/8] arm64: dts: qcom: Update sleep_clk frequency to 32000 on SA8775P

Posted by Taniya Das 1 year, 4 months ago


On 7/16/2024 1:15 PM, Krzysztof Kozlowski wrote:
> On 15/07/2024 10:23, Taniya Das wrote:
>> The HW supported sleep_clk frequency on SA8775P is 32000, hence
>> update the sleep_clk frequency with the correct value on SA8775P.
>>
>> Fixes: 603f96d4c9d0 ("arm64: dts: qcom: add initial support for qcom sa8775p-ride")
>> Signed-off-by: Taniya Das <quic_tdas@quicinc.com>
>> ---
> 
> Avoid combining fixes with features, but if you do, then fixes are never
> the last patch, but first.
> 
> Best regards,
> Krzysztof
> 
Thanks Krzysztof, I will change the order of the patch, putting it 
before the MM clock nodes.

-- 
Thanks & Regards,
Taniya Das.