[v1] net: ethernet: lantiq_etop: remove redundant device name setup

[PATCH] net: ethernet: lantiq_etop: remove redundant device name setup

Aleksander Jan Bajkowski posted 1 patch 1 year, 6 months ago

Diff against v2
Download mbox

There is a newer version of this series

drivers/net/ethernet/lantiq_etop.c | 1 -
1 file changed, 1 deletion(-)

Expand all Fold all

[PATCH] net: ethernet: lantiq_etop: remove redundant device name setup

Posted by Aleksander Jan Bajkowski 1 year, 6 months ago

The same name is set when allocating the netdevice structure in the
alloc_etherdev_mq()->alloc_etherrdev_mqs() function. Therefore, there
is no need to manually set it.

This fixes CheckPatch warnings:
WARNING: Prefer strscpy over strcpy - see: https://github.com/KSPP/linux/issues/88
	strcpy(dev->name, "eth%d");

Signed-off-by: Aleksander Jan Bajkowski <olek2@wp.pl>
---
 drivers/net/ethernet/lantiq_etop.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/ethernet/lantiq_etop.c b/drivers/net/ethernet/lantiq_etop.c
index 0b9982804370..9e6984815386 100644
--- a/drivers/net/ethernet/lantiq_etop.c
+++ b/drivers/net/ethernet/lantiq_etop.c
@@ -675,7 +675,6 @@ ltq_etop_probe(struct platform_device *pdev)
 		err = -ENOMEM;
 		goto err_out;
 	}
-	strcpy(dev->name, "eth%d");
 	dev->netdev_ops = &ltq_eth_netdev_ops;
 	dev->ethtool_ops = &ltq_etop_ethtool_ops;
 	priv = netdev_priv(dev);
-- 
2.39.2