MEDIA: USB: UVC: Corrected Errors in Macro Definitions

[PATCH] MEDIA: USB: UVC: Corrected Errors in Macro Definitions

Posted by aditya-chari25 1 year, 6 months ago

macro definitions had errors since they weren't enclosed in parenthesis
hence I rectified those errors

Signed-off-by: aditya-chari25 <adi25charis@gmail.com>
---
 drivers/media/usb/uvc/uvc_driver.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc_driver.c
index 8fe24c98087e..6e14b9dc3886 100644
--- a/drivers/media/usb/uvc/uvc_driver.c
+++ b/drivers/media/usb/uvc/uvc_driver.c
@@ -2424,9 +2424,9 @@ static const struct uvc_device_info uvc_quirk_force_y8 = {
 	.quirks = UVC_QUIRK_FORCE_Y8,
 };
 
-#define UVC_INFO_QUIRK(q) (kernel_ulong_t)&(struct uvc_device_info){.quirks = q}
-#define UVC_INFO_META(m) (kernel_ulong_t)&(struct uvc_device_info) \
-	{.meta_format = m}
+#define UVC_INFO_QUIRK(q) {(kernel_ulong_t)&(struct uvc_device_info){.quirks = q}}
+#define UVC_INFO_META(m) {(kernel_ulong_t)&(struct uvc_device_info) \
+	{.meta_format = m}}
 
 /*
  * The Logitech cameras listed below have their interface class set to
-- 
2.34.1

Re: [PATCH] MEDIA: USB: UVC: Corrected Errors in Macro Definitions

Posted by Christophe JAILLET 1 year, 6 months ago

Le 13/07/2024 à 13:08, aditya-chari25 a écrit :
> macro definitions had errors since they weren't enclosed in parenthesis
> hence I rectified those errors

Hi,

The driver does *not* compile anymore with this patch.

Can you elaborate on what you are trying to fix and if your chnage is at 
least compile-tested?

CJ

> 
> Signed-off-by: aditya-chari25 <adi25charis@gmail.com>
> ---
>   drivers/media/usb/uvc/uvc_driver.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc_driver.c
> index 8fe24c98087e..6e14b9dc3886 100644
> --- a/drivers/media/usb/uvc/uvc_driver.c
> +++ b/drivers/media/usb/uvc/uvc_driver.c
> @@ -2424,9 +2424,9 @@ static const struct uvc_device_info uvc_quirk_force_y8 = {
>   	.quirks = UVC_QUIRK_FORCE_Y8,
>   };
>   
> -#define UVC_INFO_QUIRK(q) (kernel_ulong_t)&(struct uvc_device_info){.quirks = q}
> -#define UVC_INFO_META(m) (kernel_ulong_t)&(struct uvc_device_info) \
> -	{.meta_format = m}
> +#define UVC_INFO_QUIRK(q) {(kernel_ulong_t)&(struct uvc_device_info){.quirks = q}}
> +#define UVC_INFO_META(m) {(kernel_ulong_t)&(struct uvc_device_info) \
> +	{.meta_format = m}}
>   
>   /*
>    * The Logitech cameras listed below have their interface class set to