kselftest: missing arg in ptrace.c

[PATCH] kselftest: missing arg in ptrace.c

Posted by Remington Brasga 1 year, 5 months ago

The string passed to ksft_test_result_skip is missing the `type_name`

Signed-off-by: Remington Brasga <rbrasga@uci.edu>
---
clang-tidy reported clang-diagnostic-format-insufficient-args warning
on this line, so I am fixing it.

 tools/testing/selftests/arm64/abi/ptrace.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/arm64/abi/ptrace.c b/tools/testing/selftests/arm64/abi/ptrace.c
index abe4d58d731d..6144f83f8ab4 100644
--- a/tools/testing/selftests/arm64/abi/ptrace.c
+++ b/tools/testing/selftests/arm64/abi/ptrace.c
@@ -156,7 +156,7 @@ static void test_hw_debug(pid_t child, int type, const char *type_name)
 		/* Zero is not currently architecturally valid */
 		ksft_test_result(arch, "%s_arch_set\n", type_name);
 	} else {
-		ksft_test_result_skip("%s_arch_set\n");
+		ksft_test_result_skip("%s_arch_set\n", type_name);
 	}
 }
 
-- 
2.34.1

Re: [PATCH] kselftest: missing arg in ptrace.c

Posted by Will Deacon 1 year, 4 months ago

On Fri, 12 Jul 2024 23:17:30 +0000, Remington Brasga wrote:
> The string passed to ksft_test_result_skip is missing the `type_name`
> 
> 

Applied to arm64 (for-next/core), thanks!

[1/1] kselftest: missing arg in ptrace.c
      https://git.kernel.org/arm64/c/0c35e3bd412a

Cheers,
-- 
Will

https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev

Re: [PATCH] kselftest: missing arg in ptrace.c

Posted by Dev Jain 1 year, 5 months ago

On 7/13/24 04:47, Remington Brasga wrote:
> The string passed to ksft_test_result_skip is missing the `type_name`
>
> Signed-off-by: Remington Brasga <rbrasga@uci.edu>
> ---
> clang-tidy reported clang-diagnostic-format-insufficient-args warning
> on this line, so I am fixing it.
>
>   tools/testing/selftests/arm64/abi/ptrace.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/arm64/abi/ptrace.c b/tools/testing/selftests/arm64/abi/ptrace.c
> index abe4d58d731d..6144f83f8ab4 100644
> --- a/tools/testing/selftests/arm64/abi/ptrace.c
> +++ b/tools/testing/selftests/arm64/abi/ptrace.c
> @@ -156,7 +156,7 @@ static void test_hw_debug(pid_t child, int type, const char *type_name)
>   		/* Zero is not currently architecturally valid */
>   		ksft_test_result(arch, "%s_arch_set\n", type_name);
>   	} else {
> -		ksft_test_result_skip("%s_arch_set\n");
> +		ksft_test_result_skip("%s_arch_set\n", type_name);
>   	}
>   }

Okay, I almost forgot that I had a patch fixing this as part of another series:
https://lore.kernel.org/all/20240625122408.1439097-6-dev.jain@arm.com/
If that is OK, Will, can you please pull that? Or should I send that as a
separate patch?

Re: [PATCH] kselftest: missing arg in ptrace.c

Posted by Will Deacon 1 year, 5 months ago

On Tue, Jul 16, 2024 at 09:49:12AM +0530, Dev Jain wrote:
> 
> On 7/13/24 04:47, Remington Brasga wrote:
> > The string passed to ksft_test_result_skip is missing the `type_name`
> > 
> > Signed-off-by: Remington Brasga <rbrasga@uci.edu>
> > ---
> > clang-tidy reported clang-diagnostic-format-insufficient-args warning
> > on this line, so I am fixing it.
> > 
> >   tools/testing/selftests/arm64/abi/ptrace.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/tools/testing/selftests/arm64/abi/ptrace.c b/tools/testing/selftests/arm64/abi/ptrace.c
> > index abe4d58d731d..6144f83f8ab4 100644
> > --- a/tools/testing/selftests/arm64/abi/ptrace.c
> > +++ b/tools/testing/selftests/arm64/abi/ptrace.c
> > @@ -156,7 +156,7 @@ static void test_hw_debug(pid_t child, int type, const char *type_name)
> >   		/* Zero is not currently architecturally valid */
> >   		ksft_test_result(arch, "%s_arch_set\n", type_name);
> >   	} else {
> > -		ksft_test_result_skip("%s_arch_set\n");
> > +		ksft_test_result_skip("%s_arch_set\n", type_name);
> >   	}
> >   }
> 
> Okay, I almost forgot that I had a patch fixing this as part of another series:
> https://lore.kernel.org/all/20240625122408.1439097-6-dev.jain@arm.com/
> If that is OK, Will, can you please pull that? Or should I send that as a
> separate patch?

I think Mark already suggested sending that separately:

  | This should ideally be a separate patch, there's no overlap.

and he's right: it's best to keep fixes and features separate.

Will

Re: [PATCH] kselftest: missing arg in ptrace.c

Posted by Will Deacon 1 year, 4 months ago

On Thu, Jul 18, 2024 at 04:34:10PM +0100, Will Deacon wrote:
> On Tue, Jul 16, 2024 at 09:49:12AM +0530, Dev Jain wrote:
> > 
> > On 7/13/24 04:47, Remington Brasga wrote:
> > > The string passed to ksft_test_result_skip is missing the `type_name`
> > > 
> > > Signed-off-by: Remington Brasga <rbrasga@uci.edu>
> > > ---
> > > clang-tidy reported clang-diagnostic-format-insufficient-args warning
> > > on this line, so I am fixing it.
> > > 
> > >   tools/testing/selftests/arm64/abi/ptrace.c | 2 +-
> > >   1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/tools/testing/selftests/arm64/abi/ptrace.c b/tools/testing/selftests/arm64/abi/ptrace.c
> > > index abe4d58d731d..6144f83f8ab4 100644
> > > --- a/tools/testing/selftests/arm64/abi/ptrace.c
> > > +++ b/tools/testing/selftests/arm64/abi/ptrace.c
> > > @@ -156,7 +156,7 @@ static void test_hw_debug(pid_t child, int type, const char *type_name)
> > >   		/* Zero is not currently architecturally valid */
> > >   		ksft_test_result(arch, "%s_arch_set\n", type_name);
> > >   	} else {
> > > -		ksft_test_result_skip("%s_arch_set\n");
> > > +		ksft_test_result_skip("%s_arch_set\n", type_name);
> > >   	}
> > >   }
> > 
> > Okay, I almost forgot that I had a patch fixing this as part of another series:
> > https://lore.kernel.org/all/20240625122408.1439097-6-dev.jain@arm.com/
> > If that is OK, Will, can you please pull that? Or should I send that as a
> > separate patch?
> 
> I think Mark already suggested sending that separately:
> 
>   | This should ideally be a separate patch, there's no overlap.
> 
> and he's right: it's best to keep fixes and features separate.

I didn't spot a patch from you, so I'm going to pick this one up instead.

Will

Re: [PATCH] kselftest: missing arg in ptrace.c

Posted by Dev Jain 1 year, 5 months ago

On 7/13/24 04:47, Remington Brasga wrote:
> The string passed to ksft_test_result_skip is missing the `type_name`
>
> Signed-off-by: Remington Brasga <rbrasga@uci.edu>

Reviewed-by: Dev Jain <dev.jain@arm.com>

Re: [PATCH] kselftest: missing arg in ptrace.c

Posted by Anshuman Khandual 1 year, 5 months ago


On 7/13/24 04:47, Remington Brasga wrote:
> The string passed to ksft_test_result_skip is missing the `type_name`
> 
> Signed-off-by: Remington Brasga <rbrasga@uci.edu>
> ---
> clang-tidy reported clang-diagnostic-format-insufficient-args warning
> on this line, so I am fixing it.
> 
>  tools/testing/selftests/arm64/abi/ptrace.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/arm64/abi/ptrace.c b/tools/testing/selftests/arm64/abi/ptrace.c
> index abe4d58d731d..6144f83f8ab4 100644
> --- a/tools/testing/selftests/arm64/abi/ptrace.c
> +++ b/tools/testing/selftests/arm64/abi/ptrace.c
> @@ -156,7 +156,7 @@ static void test_hw_debug(pid_t child, int type, const char *type_name)
>  		/* Zero is not currently architecturally valid */
>  		ksft_test_result(arch, "%s_arch_set\n", type_name);
>  	} else {
> -		ksft_test_result_skip("%s_arch_set\n");
> +		ksft_test_result_skip("%s_arch_set\n", type_name);
>  	}
>  }
>  

Reviewed-by: Anshuman Khandual <anshuman.khandual@arm.com>