Hi all,

After merging the pm tree, today's linux-next build (x86_64 allmodconfig)
failed like this:

drivers/thermal/tegra/soctherm.c: In function 'tegra_thermctl_set_trip_temp':
drivers/thermal/tegra/soctherm.c:592:13: error: unused variable 'ret' [-Werror=unused-variable]
  592 |         int ret;
      |             ^~~
cc1: all warnings being treated as errors

Caused by commit

  b46696a4e8c4 ("thermal: trip: Pass trip pointer to .set_trip_temp() thermal zone callback")

I have applied the following patch for today:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Fri, 12 Jul 2024 11:46:14 +1000
Subject: [PATCH] fixup for "thermal: trip: Pass trip pointer to .set_trip_temp() thermal zone callback"

Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
 drivers/thermal/tegra/soctherm.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/thermal/tegra/soctherm.c b/drivers/thermal/tegra/soctherm.c
index 62983653ca19..d3dfc34c62c6 100644
--- a/drivers/thermal/tegra/soctherm.c
+++ b/drivers/thermal/tegra/soctherm.c
@@ -589,7 +589,6 @@ static int tegra_thermctl_set_trip_temp(struct thermal_zone_device *tz,
 	struct tegra_soctherm *ts = zone->ts;
 	const struct tegra_tsensor_group *sg = zone->sg;
 	struct device *dev = zone->dev;
-	int ret;
 
 	if (!tz)
 		return -EINVAL;
-- 
2.43.0

-- 
Cheers,
Stephen Rothwell

Hi Stephen,

On Friday, July 12, 2024 3:48:38 AM CEST Stephen Rothwell wrote:
> 
> --Sig_/uDBst4ohDb48w0eZ67u3=2t
> Content-Type: text/plain; charset=US-ASCII
> Content-Transfer-Encoding: quoted-printable
> 
> Hi all,
> 
> After merging the pm tree, today's linux-next build (x86_64 allmodconfig)
> failed like this:
> 
> drivers/thermal/tegra/soctherm.c: In function 'tegra_thermctl_set_trip_temp=
> ':
> drivers/thermal/tegra/soctherm.c:592:13: error: unused variable 'ret' [-Wer=
> ror=3Dunused-variable]
>   592 |         int ret;
>       |             ^~~
> cc1: all warnings being treated as errors
> 
> Caused by commit
> 
>   b46696a4e8c4 ("thermal: trip: Pass trip pointer to .set_trip_temp() therm=
> al zone callback")
> 
> I have applied the following patch for today:
> 
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Fri, 12 Jul 2024 11:46:14 +1000
> Subject: [PATCH] fixup for "thermal: trip: Pass trip pointer to .set_trip_t=
> emp() thermal zone callback"
> 
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
>  drivers/thermal/tegra/soctherm.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/thermal/tegra/soctherm.c b/drivers/thermal/tegra/socth=
> erm.c
> index 62983653ca19..d3dfc34c62c6 100644
> --- a/drivers/thermal/tegra/soctherm.c
> +++ b/drivers/thermal/tegra/soctherm.c
> @@ -589,7 +589,6 @@ static int tegra_thermctl_set_trip_temp(struct thermal_=
> zone_device *tz,
>  	struct tegra_soctherm *ts =3D zone->ts;
>  	const struct tegra_tsensor_group *sg =3D zone->sg;
>  	struct device *dev =3D zone->dev;
> -	int ret;
> =20
>  	if (!tz)
>  		return -EINVAL;
> --=20
> 2.43.0
> 
> --=20

Sorry for adding a build issue and thanks for the patch!

This should be fixed in my linux-next branch now.

Thank you!