[v1] rtc: stm32: add pinctrl interface to handle RTC outs

[PATCH 1/4] dt-bindings: rtc: stm32: describe pinmux nodes

Posted by Valentin Caron 1 year, 5 months ago

STM32 RTC is capable to handle 3 specific pins of the soc (out1, out2,
out2_rmp) and to outputs 2 signals (LSCO, alarm-a).

This feature is configured thanks to pinmux nodes and pinctrl framework.
This feature is available with compatible st,stm32mp1-rtc and
st,stm32mp25-rtc only.

Signed-off-by: Valentin Caron <valentin.caron@foss.st.com>
---
 .../devicetree/bindings/rtc/st,stm32-rtc.yaml | 28 +++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/Documentation/devicetree/bindings/rtc/st,stm32-rtc.yaml b/Documentation/devicetree/bindings/rtc/st,stm32-rtc.yaml
index 7a0fab721cf1..09221c2f8a0c 100644
--- a/Documentation/devicetree/bindings/rtc/st,stm32-rtc.yaml
+++ b/Documentation/devicetree/bindings/rtc/st,stm32-rtc.yaml
@@ -53,6 +53,28 @@ properties:
       override default rtc_ck parent clock phandle of the new parent clock of rtc_ck
     maxItems: 1
 
+patternProperties:
+  "^rtc-[a-z]*-[0-9]+$":
+    type: object
+    $ref: /schemas/pinctrl/pinmux-node.yaml
+    description: |
+      Configuration of STM32 RTC pins description. STM32 RTC is able to output
+      some signals on specific pins:
+      - LSCO (Low Speed Clock Output) that allow to output LSE clock on a pin.
+      - Alarm out that allow to send a pulse on a pin when alarm A of the RTC
+        expires.
+    additionalProperties: false
+    properties:
+      function:
+        enum:
+          - lsco
+          - alarm-a
+      pins:
+        enum:
+          - out1
+          - out2
+          - out2_rmp
+
 allOf:
   - if:
       properties:
@@ -68,6 +90,9 @@ allOf:
 
         clock-names: false
 
+      patternProperties:
+        "^rtc-[a-z]*-[0-9]+$": false
+
       required:
         - st,syscfg
 
@@ -83,6 +108,9 @@ allOf:
           minItems: 2
           maxItems: 2
 
+      patternProperties:
+        "^rtc-[a-z]*-[0-9]+$": false
+
       required:
         - clock-names
         - st,syscfg
-- 
2.25.1

Re: [PATCH 1/4] dt-bindings: rtc: stm32: describe pinmux nodes

Posted by Rob Herring 1 year, 5 months ago

On Thu, Jul 11, 2024 at 04:08:40PM +0200, Valentin Caron wrote:
> STM32 RTC is capable to handle 3 specific pins of the soc (out1, out2,
> out2_rmp) and to outputs 2 signals (LSCO, alarm-a).
> 
> This feature is configured thanks to pinmux nodes and pinctrl framework.
> This feature is available with compatible st,stm32mp1-rtc and
> st,stm32mp25-rtc only.
> 
> Signed-off-by: Valentin Caron <valentin.caron@foss.st.com>
> ---
>  .../devicetree/bindings/rtc/st,stm32-rtc.yaml | 28 +++++++++++++++++++
>  1 file changed, 28 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/rtc/st,stm32-rtc.yaml b/Documentation/devicetree/bindings/rtc/st,stm32-rtc.yaml
> index 7a0fab721cf1..09221c2f8a0c 100644
> --- a/Documentation/devicetree/bindings/rtc/st,stm32-rtc.yaml
> +++ b/Documentation/devicetree/bindings/rtc/st,stm32-rtc.yaml
> @@ -53,6 +53,28 @@ properties:
>        override default rtc_ck parent clock phandle of the new parent clock of rtc_ck
>      maxItems: 1
>  
> +patternProperties:
> +  "^rtc-[a-z]*-[0-9]+$":

rtc--123 is valid? "*" should be "+"

Otherwise,

Reviewed-by: Rob Herring <robh@kernel.org>

Re: [PATCH 1/4] dt-bindings: rtc: stm32: describe pinmux nodes

Posted by Valentin CARON 1 year, 5 months ago


On 7/12/24 00:56, Rob Herring wrote:
> On Thu, Jul 11, 2024 at 04:08:40PM +0200, Valentin Caron wrote:
>> STM32 RTC is capable to handle 3 specific pins of the soc (out1, out2,
>> out2_rmp) and to outputs 2 signals (LSCO, alarm-a).
>>
>> This feature is configured thanks to pinmux nodes and pinctrl framework.
>> This feature is available with compatible st,stm32mp1-rtc and
>> st,stm32mp25-rtc only.
>>
>> Signed-off-by: Valentin Caron <valentin.caron@foss.st.com>
>> ---
>>   .../devicetree/bindings/rtc/st,stm32-rtc.yaml | 28 +++++++++++++++++++
>>   1 file changed, 28 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/rtc/st,stm32-rtc.yaml b/Documentation/devicetree/bindings/rtc/st,stm32-rtc.yaml
>> index 7a0fab721cf1..09221c2f8a0c 100644
>> --- a/Documentation/devicetree/bindings/rtc/st,stm32-rtc.yaml
>> +++ b/Documentation/devicetree/bindings/rtc/st,stm32-rtc.yaml
>> @@ -53,6 +53,28 @@ properties:
>>         override default rtc_ck parent clock phandle of the new parent clock of rtc_ck
>>       maxItems: 1
>>   
>> +patternProperties:
>> +  "^rtc-[a-z]*-[0-9]+$":
> 
> rtc--123 is valid? "*" should be "+"
> 
> Otherwise,
> 
> Reviewed-by: Rob Herring <robh@kernel.org>

Yes, it should be. I will add this in the next version.

Thanks,
Valentin