[v2] bfs: fix null-ptr-deref and possible warning in bfs_move_block() func

[PATCHv2 fs/bfs 0/2] bfs: fix null-ptr-deref and possible warning in bfs_move_block() func

Posted by kovalev@altlinux.org 1 year, 5 months ago

https://syzkaller.appspot.com/bug?extid=d98fd19acd08b36ff422

[PATCHv2 fs/bfs 1/2] bfs: prevent null pointer dereference in bfs_move_block()
---
v2: corrected the commit message and explicitly initialized
the return variable with zero (Markus Elfring)
---
[PATCHv2 fs/bfs 2/2] bfs: add buffer_uptodate check before mark_buffer_dirty
---
v2: renamed the return variable  err -> ret (Markus Elfring)
---

Re: [PATCH v2 fs/bfs 0/2] bfs: fix null-ptr-deref and possible warning in bfs_move_block() func

Posted by Markus Elfring 1 year, 5 months ago

…
> [PATCHv2 fs/bfs 1/2] bfs: prevent null pointer dereference in bfs_move_block()
…

I find it usually helpful to separate the version identifier from the previous key word.

How do you think about to improve the outline another bit (also for the cover letter)?

Regards,
Markus

Re: [PATCH v2 fs/bfs 0/2] bfs: fix null-ptr-deref and possible warning in bfs_move_block() func

Posted by kovalev@altlinux.org 1 year, 5 months ago

11.07.2024 10:47, Markus Elfring wrote:
> …
>> [PATCHv2 fs/bfs 1/2] bfs: prevent null pointer dereference in bfs_move_block()
> …
> 
> I find it usually helpful to separate the version identifier from the previous key word.
> 
> How do you think about to improve the outline another bit (also for the cover letter)?

I will take your recommendation into account when submitting the next 
versions, if there are any comments on the patches themselves.

> Regards,
> Markus

-- 
Thanks,
Vasiliy Kovalev