[v1] bpf: kprobe: remove unused declaring of bpf_kprobe_override

[PATCH bpf-next] bpf: kprobe: remove unused declaring of bpf_kprobe_override

Posted by Menglong Dong 1 year, 5 months ago

After the commit 66665ad2f102 ("tracing/kprobe: bpf: Compare instruction
pointer with original one"), "bpf_kprobe_override" is not used anywhere
anymore, and we can remove it now.

Signed-off-by: Menglong Dong <dongml2@chinatelecom.cn>
---
 include/linux/trace_events.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/include/linux/trace_events.h b/include/linux/trace_events.h
index 9df3e2973626..9435185c10ef 100644
--- a/include/linux/trace_events.h
+++ b/include/linux/trace_events.h
@@ -880,7 +880,6 @@ do {									\
 struct perf_event;
 
 DECLARE_PER_CPU(struct pt_regs, perf_trace_regs);
-DECLARE_PER_CPU(int, bpf_kprobe_override);
 
 extern int  perf_trace_init(struct perf_event *event);
 extern void perf_trace_destroy(struct perf_event *event);
-- 
2.39.2

Re: [PATCH bpf-next] bpf: kprobe: remove unused declaring of bpf_kprobe_override

Posted by Jiri Olsa 1 year, 5 months ago

On Wed, Jul 10, 2024 at 04:59:39PM +0800, Menglong Dong wrote:
> After the commit 66665ad2f102 ("tracing/kprobe: bpf: Compare instruction

should be in Fixes: tag probably ?

> pointer with original one"), "bpf_kprobe_override" is not used anywhere
> anymore, and we can remove it now.
> 
> Signed-off-by: Menglong Dong <dongml2@chinatelecom.cn>

lgtm, cc-ing Masami

Acked-by: Jiri Olsa <jolsa@kernel.org>

jirka

> ---
>  include/linux/trace_events.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/include/linux/trace_events.h b/include/linux/trace_events.h
> index 9df3e2973626..9435185c10ef 100644
> --- a/include/linux/trace_events.h
> +++ b/include/linux/trace_events.h
> @@ -880,7 +880,6 @@ do {									\
>  struct perf_event;
>  
>  DECLARE_PER_CPU(struct pt_regs, perf_trace_regs);
> -DECLARE_PER_CPU(int, bpf_kprobe_override);
>  
>  extern int  perf_trace_init(struct perf_event *event);
>  extern void perf_trace_destroy(struct perf_event *event);
> -- 
> 2.39.2
> 
>

Re: [PATCH bpf-next] bpf: kprobe: remove unused declaring of bpf_kprobe_override

Posted by Masami Hiramatsu (Google) 1 year, 5 months ago

On Wed, 10 Jul 2024 15:13:07 +0200
Jiri Olsa <olsajiri@gmail.com> wrote:

> On Wed, Jul 10, 2024 at 04:59:39PM +0800, Menglong Dong wrote:
> > After the commit 66665ad2f102 ("tracing/kprobe: bpf: Compare instruction
> 
> should be in Fixes: tag probably ?

Yes, I'll add a Fixed tag.

> 
> > pointer with original one"), "bpf_kprobe_override" is not used anywhere
> > anymore, and we can remove it now.
> > 
> > Signed-off-by: Menglong Dong <dongml2@chinatelecom.cn>
> 
> lgtm, cc-ing Masami
> 
> Acked-by: Jiri Olsa <jolsa@kernel.org>

Thanks!

> 
> jirka
> 
> > ---
> >  include/linux/trace_events.h | 1 -
> >  1 file changed, 1 deletion(-)
> > 
> > diff --git a/include/linux/trace_events.h b/include/linux/trace_events.h
> > index 9df3e2973626..9435185c10ef 100644
> > --- a/include/linux/trace_events.h
> > +++ b/include/linux/trace_events.h
> > @@ -880,7 +880,6 @@ do {									\
> >  struct perf_event;
> >  
> >  DECLARE_PER_CPU(struct pt_regs, perf_trace_regs);
> > -DECLARE_PER_CPU(int, bpf_kprobe_override);
> >  
> >  extern int  perf_trace_init(struct perf_event *event);
> >  extern void perf_trace_destroy(struct perf_event *event);
> > -- 
> > 2.39.2
> > 
> > 


-- 
Masami Hiramatsu (Google) <mhiramat@kernel.org>

Re: [PATCH bpf-next] bpf: kprobe: remove unused declaring of bpf_kprobe_override

Posted by Menglong Dong 1 year, 5 months ago

On Wed, Jul 10, 2024 at 10:18 PM Masami Hiramatsu <mhiramat@kernel.org> wrote:
>
> On Wed, 10 Jul 2024 15:13:07 +0200
> Jiri Olsa <olsajiri@gmail.com> wrote:
>
> > On Wed, Jul 10, 2024 at 04:59:39PM +0800, Menglong Dong wrote:
> > > After the commit 66665ad2f102 ("tracing/kprobe: bpf: Compare instruction
> >
> > should be in Fixes: tag probably ?
>
> Yes, I'll add a Fixed tag.
>

Hello!

Should I send a v2 with the "Fixes" tag? It seems that this commit has
been pending for a while.

Thanks!
Menglong Dong

> >
> > > pointer with original one"), "bpf_kprobe_override" is not used anywhere
> > > anymore, and we can remove it now.
> > >
> > > Signed-off-by: Menglong Dong <dongml2@chinatelecom.cn>
> >
> > lgtm, cc-ing Masami
> >
> > Acked-by: Jiri Olsa <jolsa@kernel.org>
>
> Thanks!
>
> >
> > jirka
> >
> > > ---
> > >  include/linux/trace_events.h | 1 -
> > >  1 file changed, 1 deletion(-)
> > >
> > > diff --git a/include/linux/trace_events.h b/include/linux/trace_events.h
> > > index 9df3e2973626..9435185c10ef 100644
> > > --- a/include/linux/trace_events.h
> > > +++ b/include/linux/trace_events.h
> > > @@ -880,7 +880,6 @@ do {                                                                    \
> > >  struct perf_event;
> > >
> > >  DECLARE_PER_CPU(struct pt_regs, perf_trace_regs);
> > > -DECLARE_PER_CPU(int, bpf_kprobe_override);
> > >
> > >  extern int  perf_trace_init(struct perf_event *event);
> > >  extern void perf_trace_destroy(struct perf_event *event);
> > > --
> > > 2.39.2
> > >
> > >
>
>
> --
> Masami Hiramatsu (Google) <mhiramat@kernel.org>

Re: [PATCH bpf-next] bpf: kprobe: remove unused declaring of bpf_kprobe_override

Posted by Masami Hiramatsu (Google) 1 year, 5 months ago

Hi,

On Thu, 18 Jul 2024 09:32:13 +0800
Menglong Dong <menglong8.dong@gmail.com> wrote:

> On Wed, Jul 10, 2024 at 10:18 PM Masami Hiramatsu <mhiramat@kernel.org> wrote:
> >
> > On Wed, 10 Jul 2024 15:13:07 +0200
> > Jiri Olsa <olsajiri@gmail.com> wrote:
> >
> > > On Wed, Jul 10, 2024 at 04:59:39PM +0800, Menglong Dong wrote:
> > > > After the commit 66665ad2f102 ("tracing/kprobe: bpf: Compare instruction
> > >
> > > should be in Fixes: tag probably ?
> >
> > Yes, I'll add a Fixed tag.
> >
> 
> Hello!
> 
> Should I send a v2 with the "Fixes" tag? It seems that this commit has
> been pending for a while.

No problem, but wait a bit. I need to send this to 6.11-rc1.

Thank you,


> 
> Thanks!
> Menglong Dong
> 
> > >
> > > > pointer with original one"), "bpf_kprobe_override" is not used anywhere
> > > > anymore, and we can remove it now.
> > > >
> > > > Signed-off-by: Menglong Dong <dongml2@chinatelecom.cn>
> > >
> > > lgtm, cc-ing Masami
> > >
> > > Acked-by: Jiri Olsa <jolsa@kernel.org>
> >
> > Thanks!
> >
> > >
> > > jirka
> > >
> > > > ---
> > > >  include/linux/trace_events.h | 1 -
> > > >  1 file changed, 1 deletion(-)
> > > >
> > > > diff --git a/include/linux/trace_events.h b/include/linux/trace_events.h
> > > > index 9df3e2973626..9435185c10ef 100644
> > > > --- a/include/linux/trace_events.h
> > > > +++ b/include/linux/trace_events.h
> > > > @@ -880,7 +880,6 @@ do {                                                                    \
> > > >  struct perf_event;
> > > >
> > > >  DECLARE_PER_CPU(struct pt_regs, perf_trace_regs);
> > > > -DECLARE_PER_CPU(int, bpf_kprobe_override);
> > > >
> > > >  extern int  perf_trace_init(struct perf_event *event);
> > > >  extern void perf_trace_destroy(struct perf_event *event);
> > > > --
> > > > 2.39.2
> > > >
> > > >
> >
> >
> > --
> > Masami Hiramatsu (Google) <mhiramat@kernel.org>


-- 
Masami Hiramatsu (Google) <mhiramat@kernel.org>