[v2] gpio: mc33880: Convert comma to semicolon

[PATCH v2] gpio: mc33880: Convert comma to semicolon

Posted by Chen Ni 1 year, 5 months ago

Replace a comma between expression statements by a semicolon.

Fixes: c103de240439 ("gpio: reorganize drivers")
Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
---
Changelog:

v1 -> v2:

1. Add Fixes tag.
---
 drivers/gpio/gpio-mc33880.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpio/gpio-mc33880.c b/drivers/gpio/gpio-mc33880.c
index 94f6fefc011b..5fb357d7b78a 100644
--- a/drivers/gpio/gpio-mc33880.c
+++ b/drivers/gpio/gpio-mc33880.c
@@ -99,7 +99,7 @@ static int mc33880_probe(struct spi_device *spi)
 
 	mc->spi = spi;
 
-	mc->chip.label = DRIVER_NAME,
+	mc->chip.label = DRIVER_NAME;
 	mc->chip.set = mc33880_set;
 	mc->chip.base = pdata->base;
 	mc->chip.ngpio = PIN_NUMBER;
-- 
2.25.1

Re: [PATCH v2] gpio: mc33880: Convert comma to semicolon

Posted by Bartosz Golaszewski 1 year, 5 months ago

From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>


On Wed, 10 Jul 2024 16:28:13 +0800, Chen Ni wrote:
> Replace a comma between expression statements by a semicolon.
> 
> 

Applied, thanks!

[1/1] gpio: mc33880: Convert comma to semicolon
      commit: dfda97e37de4c2fa4a079ae77737c6b9ed021f79

Best regards,
-- 
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

Re: [PATCH v2] gpio: mc33880: Convert comma to semicolon

Posted by Bartosz Golaszewski 1 year, 5 months ago

On Wed, Jul 10, 2024 at 10:28 AM Chen Ni <nichen@iscas.ac.cn> wrote:
>
> Replace a comma between expression statements by a semicolon.
>
> Fixes: c103de240439 ("gpio: reorganize drivers")

This is not correct. The commit that introduced that issue is
1e5db00687c1 ("gpio: add MC33880 driver"). I'll fix it when applying.

Bart

> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
> ---
> Changelog:
>
> v1 -> v2:
>
> 1. Add Fixes tag.
> ---
>  drivers/gpio/gpio-mc33880.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-mc33880.c b/drivers/gpio/gpio-mc33880.c
> index 94f6fefc011b..5fb357d7b78a 100644
> --- a/drivers/gpio/gpio-mc33880.c
> +++ b/drivers/gpio/gpio-mc33880.c
> @@ -99,7 +99,7 @@ static int mc33880_probe(struct spi_device *spi)
>
>         mc->spi = spi;
>
> -       mc->chip.label = DRIVER_NAME,
> +       mc->chip.label = DRIVER_NAME;
>         mc->chip.set = mc33880_set;
>         mc->chip.base = pdata->base;
>         mc->chip.ngpio = PIN_NUMBER;
> --
> 2.25.1
>