selftests/dma:remove unused variable

[PATCH] selftests/dma:remove unused variable

Posted by Zhu Jun 1 year, 5 months ago

The variable are never referenced in the code, just remove it
that this problem was discovered by reading code

Signed-off-by: Zhu Jun <zhujun2@cmss.chinamobile.com>
---
 tools/testing/selftests/dma/dma_map_benchmark.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/tools/testing/selftests/dma/dma_map_benchmark.c b/tools/testing/selftests/dma/dma_map_benchmark.c
index 3fcea00961c0..c91b485ca99a 100644
--- a/tools/testing/selftests/dma/dma_map_benchmark.c
+++ b/tools/testing/selftests/dma/dma_map_benchmark.c
@@ -33,7 +33,6 @@ int main(int argc, char **argv)
 	int granule = 1;
 
 	int cmd = DMA_MAP_BENCHMARK;
-	char *p;
 
 	while ((opt = getopt(argc, argv, "t:s:n:b:d:x:g:")) != -1) {
 		switch (opt) {
-- 
2.17.1

Re: [PATCH] selftests/dma:remove unused variable

Posted by Shuah Khan 1 year, 5 months ago

On 7/10/24 00:57, Zhu Jun wrote:
> The variable are never referenced in the code, just remove it
> that this problem was discovered by reading code
> 
> Signed-off-by: Zhu Jun <zhujun2@cmss.chinamobile.com>
> ---
>   tools/testing/selftests/dma/dma_map_benchmark.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/dma/dma_map_benchmark.c b/tools/testing/selftests/dma/dma_map_benchmark.c
> index 3fcea00961c0..c91b485ca99a 100644
> --- a/tools/testing/selftests/dma/dma_map_benchmark.c
> +++ b/tools/testing/selftests/dma/dma_map_benchmark.c
> @@ -33,7 +33,6 @@ int main(int argc, char **argv)
>   	int granule = 1;
>   
>   	int cmd = DMA_MAP_BENCHMARK;
> -	char *p;
>   
>   	while ((opt = getopt(argc, argv, "t:s:n:b:d:x:g:")) != -1) {
>   		switch (opt) {

Applied to linux-kselftest next for Linux 6.11-rc1.

thanks,
-- Shuah