[v1] dmaengine: idxd: Convert comma to semicolon

[PATCH] dmaengine: idxd: Convert comma to semicolon

Posted by Chen Ni 1 year, 5 months ago

Replace a comma between expression statements by a semicolon.

Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
---
 drivers/dma/idxd/perfmon.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/dma/idxd/perfmon.c b/drivers/dma/idxd/perfmon.c
index 5e94247e1ea7..e596ea60ed3c 100644
--- a/drivers/dma/idxd/perfmon.c
+++ b/drivers/dma/idxd/perfmon.c
@@ -480,8 +480,8 @@ static void idxd_pmu_init(struct idxd_pmu *idxd_pmu)
 	idxd_pmu->pmu.attr_groups	= perfmon_attr_groups;
 	idxd_pmu->pmu.task_ctx_nr	= perf_invalid_context;
 	idxd_pmu->pmu.event_init	= perfmon_pmu_event_init;
-	idxd_pmu->pmu.pmu_enable	= perfmon_pmu_enable,
-	idxd_pmu->pmu.pmu_disable	= perfmon_pmu_disable,
+	idxd_pmu->pmu.pmu_enable	= perfmon_pmu_enable;
+	idxd_pmu->pmu.pmu_disable	= perfmon_pmu_disable;
 	idxd_pmu->pmu.add		= perfmon_pmu_event_add;
 	idxd_pmu->pmu.del		= perfmon_pmu_event_del;
 	idxd_pmu->pmu.start		= perfmon_pmu_event_start;
-- 
2.25.1

Re: [PATCH] dmaengine: idxd: Convert comma to semicolon

Posted by Fenghua Yu 1 year, 5 months ago


On 7/9/24 20:07, Chen Ni wrote:
> Replace a comma between expression statements by a semicolon.

better to add "for more readability."

Otherwise, there is no issue with the commas.

> 
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>

Reviewed-by: Fenghua Yu <fenghua.yu@intel.com>

> ---
>   drivers/dma/idxd/perfmon.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/dma/idxd/perfmon.c b/drivers/dma/idxd/perfmon.c
> index 5e94247e1ea7..e596ea60ed3c 100644
> --- a/drivers/dma/idxd/perfmon.c
> +++ b/drivers/dma/idxd/perfmon.c
> @@ -480,8 +480,8 @@ static void idxd_pmu_init(struct idxd_pmu *idxd_pmu)
>   	idxd_pmu->pmu.attr_groups	= perfmon_attr_groups;
>   	idxd_pmu->pmu.task_ctx_nr	= perf_invalid_context;
>   	idxd_pmu->pmu.event_init	= perfmon_pmu_event_init;
> -	idxd_pmu->pmu.pmu_enable	= perfmon_pmu_enable,
> -	idxd_pmu->pmu.pmu_disable	= perfmon_pmu_disable,
> +	idxd_pmu->pmu.pmu_enable	= perfmon_pmu_enable;
> +	idxd_pmu->pmu.pmu_disable	= perfmon_pmu_disable;
>   	idxd_pmu->pmu.add		= perfmon_pmu_event_add;
>   	idxd_pmu->pmu.del		= perfmon_pmu_event_del;
>   	idxd_pmu->pmu.start		= perfmon_pmu_event_start;

Thanks.

-Fenghua

Re: [PATCH] dmaengine: idxd: Convert comma to semicolon

Posted by Dave Jiang 1 year, 5 months ago


On 7/9/24 8:07 PM, Chen Ni wrote:
> Replace a comma between expression statements by a semicolon.
> 
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>

Odd that it used to compile.

Reviewed-by: Dave Jiang <dave.jiang@intel.com>
> ---
>  drivers/dma/idxd/perfmon.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/dma/idxd/perfmon.c b/drivers/dma/idxd/perfmon.c
> index 5e94247e1ea7..e596ea60ed3c 100644
> --- a/drivers/dma/idxd/perfmon.c
> +++ b/drivers/dma/idxd/perfmon.c
> @@ -480,8 +480,8 @@ static void idxd_pmu_init(struct idxd_pmu *idxd_pmu)
>  	idxd_pmu->pmu.attr_groups	= perfmon_attr_groups;
>  	idxd_pmu->pmu.task_ctx_nr	= perf_invalid_context;
>  	idxd_pmu->pmu.event_init	= perfmon_pmu_event_init;
> -	idxd_pmu->pmu.pmu_enable	= perfmon_pmu_enable,
> -	idxd_pmu->pmu.pmu_disable	= perfmon_pmu_disable,
> +	idxd_pmu->pmu.pmu_enable	= perfmon_pmu_enable;
> +	idxd_pmu->pmu.pmu_disable	= perfmon_pmu_disable;
>  	idxd_pmu->pmu.add		= perfmon_pmu_event_add;
>  	idxd_pmu->pmu.del		= perfmon_pmu_event_del;
>  	idxd_pmu->pmu.start		= perfmon_pmu_event_start;