[PATCH -next] xfs: Remove duplicate xfs_trans_priv.h header

Jiapeng Chong posted 1 patch 1 year, 5 months ago
fs/xfs/libxfs/xfs_defer.c | 1 -
1 file changed, 1 deletion(-)
[PATCH -next] xfs: Remove duplicate xfs_trans_priv.h header
Posted by Jiapeng Chong 1 year, 5 months ago
./fs/xfs/libxfs/xfs_defer.c: xfs_trans_priv.h is included more than once.

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=9491
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
 fs/xfs/libxfs/xfs_defer.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/fs/xfs/libxfs/xfs_defer.c b/fs/xfs/libxfs/xfs_defer.c
index 40021849b42f..2cd212ad2c1d 100644
--- a/fs/xfs/libxfs/xfs_defer.c
+++ b/fs/xfs/libxfs/xfs_defer.c
@@ -28,7 +28,6 @@
 #include "xfs_da_format.h"
 #include "xfs_da_btree.h"
 #include "xfs_attr.h"
-#include "xfs_trans_priv.h"
 #include "xfs_exchmaps.h"
 
 static struct kmem_cache	*xfs_defer_pending_cache;
-- 
2.20.1.7.g153144c
Re: [PATCH -next] xfs: Remove duplicate xfs_trans_priv.h header
Posted by Darrick J. Wong 1 year, 5 months ago
On Wed, Jul 10, 2024 at 10:45:14AM +0800, Jiapeng Chong wrote:
> ./fs/xfs/libxfs/xfs_defer.c: xfs_trans_priv.h is included more than once.
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=9491
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>

Looks ok,
Reviewed-by: Darrick J. Wong <djwong@kernel.org>

--D

> ---
>  fs/xfs/libxfs/xfs_defer.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/fs/xfs/libxfs/xfs_defer.c b/fs/xfs/libxfs/xfs_defer.c
> index 40021849b42f..2cd212ad2c1d 100644
> --- a/fs/xfs/libxfs/xfs_defer.c
> +++ b/fs/xfs/libxfs/xfs_defer.c
> @@ -28,7 +28,6 @@
>  #include "xfs_da_format.h"
>  #include "xfs_da_btree.h"
>  #include "xfs_attr.h"
> -#include "xfs_trans_priv.h"
>  #include "xfs_exchmaps.h"
>  
>  static struct kmem_cache	*xfs_defer_pending_cache;
> -- 
> 2.20.1.7.g153144c
> 
>