tools/testing/selftests/breakpoints/step_after_suspend_test.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
Main function return value is int type, so add return
value in the end that this problem was discovered by reading the code
Signed-off-by: Zhu Jun <zhujun2@cmss.chinamobile.com>
---
Changes in v2:
- modify commit info
tools/testing/selftests/breakpoints/step_after_suspend_test.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/tools/testing/selftests/breakpoints/step_after_suspend_test.c b/tools/testing/selftests/breakpoints/step_after_suspend_test.c
index dfec31fb9b30..b473131fce3e 100644
--- a/tools/testing/selftests/breakpoints/step_after_suspend_test.c
+++ b/tools/testing/selftests/breakpoints/step_after_suspend_test.c
@@ -166,7 +166,7 @@ int main(int argc, char **argv)
bool succeeded = true;
unsigned int tests = 0;
cpu_set_t available_cpus;
- int err;
+ int err = 0;
int cpu;
ksft_print_header();
@@ -222,4 +222,6 @@ int main(int argc, char **argv)
ksft_exit_pass();
else
ksft_exit_fail();
+
+ return err;
}
--
2.17.1
On 7/9/24 20:16, Zhu Jun wrote: > Main function return value is int type, so add return > value in the end that this problem was discovered by reading the code > > Signed-off-by: Zhu Jun <zhujun2@cmss.chinamobile.com> > --- > Changes in v2: > - modify commit info > > tools/testing/selftests/breakpoints/step_after_suspend_test.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/breakpoints/step_after_suspend_test.c b/tools/testing/selftests/breakpoints/step_after_suspend_test.c > index dfec31fb9b30..b473131fce3e 100644 > --- a/tools/testing/selftests/breakpoints/step_after_suspend_test.c > +++ b/tools/testing/selftests/breakpoints/step_after_suspend_test.c > @@ -166,7 +166,7 @@ int main(int argc, char **argv) > bool succeeded = true; > unsigned int tests = 0; > cpu_set_t available_cpus; > - int err; > + int err = 0; > int cpu; > > ksft_print_header(); > @@ -222,4 +222,6 @@ int main(int argc, char **argv) > ksft_exit_pass(); > else > ksft_exit_fail(); > + > + return err; > } Unless this is causing a compile error or warning - there is no need to make this change. thanks, -- Shuah
© 2016 - 2025 Red Hat, Inc.