[PATCH 2/2] arm64: dts: ti: k3-j784s4-evm: Consolidate serdes0 references

Andrew Halaney posted 2 patches 1 year, 7 months ago
[PATCH 2/2] arm64: dts: ti: k3-j784s4-evm: Consolidate serdes0 references
Posted by Andrew Halaney 1 year, 7 months ago
Subnodes were added to serdes0 in two different spots (due to independent
development of their consumer usage). Let's go ahead and combine those
into one reference for readability's sake.

Signed-off-by: Andrew Halaney <ahalaney@redhat.com>
---
 arch/arm64/boot/dts/ti/k3-j784s4-evm.dts | 24 ++++++++----------------
 1 file changed, 8 insertions(+), 16 deletions(-)

diff --git a/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts b/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts
index e54ccf4f37955..ffa38f41679d8 100644
--- a/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts
+++ b/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts
@@ -1262,6 +1262,14 @@ &dss {
 &serdes0 {
 	status = "okay";
 
+	serdes0_pcie1_link: phy@0 {
+		reg = <0>;
+		cdns,num-lanes = <2>;
+		#phy-cells = <0>;
+		cdns,phy-type = <PHY_TYPE_PCIE>;
+		resets = <&serdes_wiz0 1>, <&serdes_wiz0 2>;
+	};
+
 	serdes0_usb_link: phy@3 {
 		reg = <3>;
 		cdns,num-lanes = <1>;
@@ -1386,22 +1394,6 @@ &main_mcan4 {
 	phys = <&transceiver3>;
 };
 
-&serdes0 {
-	status = "okay";
-
-	serdes0_pcie1_link: phy@0 {
-		reg = <0>;
-		cdns,num-lanes = <2>;
-		#phy-cells = <0>;
-		cdns,phy-type = <PHY_TYPE_PCIE>;
-		resets = <&serdes_wiz0 1>, <&serdes_wiz0 2>;
-	};
-};
-
-&serdes_wiz0 {
-	status = "okay";
-};
-
 &pcie1_rc {
 	status = "okay";
 	num-lanes = <2>;

-- 
2.45.2
Re: [PATCH 2/2] arm64: dts: ti: k3-j784s4-evm: Consolidate serdes0 references
Posted by Siddharth Vadapalli 1 year, 7 months ago
On Wed, Jul 10, 2024 at 10:36:14AM -0500, Andrew Halaney wrote:
> Subnodes were added to serdes0 in two different spots (due to independent
> development of their consumer usage). Let's go ahead and combine those
> into one reference for readability's sake.
> 
> Signed-off-by: Andrew Halaney <ahalaney@redhat.com>

This patch could probably be squashed into the previous one.
Irrespective of that,

Reviewed-by: Siddharth Vadapalli <s-vadapalli@ti.com>

[...]

Regards,
Siddharth.