[v3] media: qcom: camss: Add sm8550 support

[PATCH V3 00/13] media: qcom: camss: Add sm8550 support

Posted by Depeng Shao 1 year, 7 months ago

V3:
- Rebased the change based on below change which will be merged firstly.
  "Move camss version related defs in to resources"
Link: https://lore.kernel.org/all/20240522154659.510-1-quic_grosikop@quicinc.com/
- Rebased the change based on Bryan's csiphy optimization change and add
these changes into this series, so that the new csiphy-3ph driver don't
need to add duplicate code. This has got Bryan's permission to add his
patches into this series.
- Refactor some changes based on the comments to move the random code to
patches where they are used.
- Remove the vfe780 irq function since it isn't doing the actual work.
- Add dt-binding for sm8550 camss driver.
Link to V2: https://lore.kernel.org/all/20240320141136.26827-1-quic_depengs@quicinc.com/

V2:
- Update some commit messages
Link to V1: https://lore.kernel.org/all/20240320134227.16587-1-quic_depengs@quicinc.com/

V1:
SM8550 is a Qualcomm flagship SoC. This series adds support to
bring up the CSIPHY, CSID, VFE/RDI interfaces in SM8550.

SM8550 provides

- 3 x VFE, 3 RDI per VFE
- 2 x VFE Lite, 4 RDI per VFE
- 3 x CSID
- 2 x CSID Lite
- 8 x CSI PHY

This series is rebased based on: "Move camss version related defs in to resources"
Link: https://lore.kernel.org/all/20240522154659.510-1-quic_grosikop@quicinc.com/

Bryan O'Donoghue (6):
  media: qcom: camss: csiphy-3ph: Fix trivial indentation fault in
    defines
  media: qcom: camss: csiphy-3ph: Remove redundant PHY init sequence
    control loop
  media: qcom: camss: csiphy-3ph: Rename struct
  media: qcom: camss: csiphy: Add an init callback to CSI PHY devices
  media: qcom: camss: csiphy-3ph: Move CSIPHY variables to data field
    inside csiphy struct
  media: qcom: camss: csiphy-3ph: Use an offset variable to find common
    control regs

Depeng Shao (7):
  dt-bindings: media: camss: Add qcom,sm8550-camss binding
  media: qcom: camss: csiphy-3ph: Add Gen2 v1.2 two-phase MIPI CSI-2
    DPHY init
  media: qcom: camss: Add CSID Gen3 support for SM8550
  media: qcom: camss: Add support for VFE hardware version Titan 780
  media: qcom: camss: Add notify interface in camss driver
  media: qcom: camss: Add sm8550 support
  media: qcom: camss: Add sm8550 resources

 .../bindings/media/qcom,sm8550-camss.yaml     | 545 ++++++++++++
 drivers/media/platform/qcom/camss/Makefile    |   2 +
 .../platform/qcom/camss/camss-csid-gen3.c     | 483 +++++++++++
 .../platform/qcom/camss/camss-csid-gen3.h     |  26 +
 .../media/platform/qcom/camss/camss-csid.c    |  21 +
 .../media/platform/qcom/camss/camss-csid.h    |  11 +
 .../qcom/camss/camss-csiphy-2ph-1-0.c         |   6 +
 .../qcom/camss/camss-csiphy-3ph-1-0.c         | 796 ++++++++++--------
 .../media/platform/qcom/camss/camss-csiphy.c  |   4 +
 .../media/platform/qcom/camss/camss-csiphy.h  |   2 +
 .../media/platform/qcom/camss/camss-vfe-780.c | 429 ++++++++++
 drivers/media/platform/qcom/camss/camss-vfe.c |   6 +
 drivers/media/platform/qcom/camss/camss-vfe.h |   2 +
 drivers/media/platform/qcom/camss/camss.c     | 462 ++++++++++
 drivers/media/platform/qcom/camss/camss.h     |  10 +
 15 files changed, 2467 insertions(+), 338 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/media/qcom,sm8550-camss.yaml
 create mode 100644 drivers/media/platform/qcom/camss/camss-csid-gen3.c
 create mode 100644 drivers/media/platform/qcom/camss/camss-csid-gen3.h
 create mode 100644 drivers/media/platform/qcom/camss/camss-vfe-780.c


base-commit: 0c52056d9f77508cb6d4d68d3fc91c6c08ec71af
prerequisite-patch-id: 74fabfbf51d650af74a1dc9f7e09fe03a1d85d93
prerequisite-patch-id: 3833c5eed2690679e5eca3551053e08350d2b070
prerequisite-patch-id: 0e433e0c5a9d2402da97c1a01194b1a9f6f7e6cb
prerequisite-patch-id: f876f5ed5605fcfebea7f1584888f494bfecd102
prerequisite-patch-id: 8bcb15b208a319a6e88ff4f9e5023097af92cc90
prerequisite-patch-id: dc4b5ddbbedd8773159694b3becad5c7dcbfcf77
prerequisite-patch-id: 75c1b00f4476ee6006041046ad5194b086db3358
prerequisite-patch-id: 0efc004cb8a844291ebe1f16ce192567f44218c7
-- 
2.34.1

Re: [PATCH V3 00/13] media: qcom: camss: Add sm8550 support

Posted by Bryan O'Donoghue 1 year, 5 months ago

>    media: qcom: camss: Add CSID Gen3 support for SM8550
>    media: qcom: camss: Add support for VFE hardware version Titan 780

Before your post your next version of this series, please make the patch 
submission titles consistent.

e.g.

Add CSID 780 support
Add VFE 780 support

Mixing SoC versions "sm8550" and/or including "Titan" - what's that a 
reader might ask - should be avoided.

No harm in including "Titan" but if you do, include it in both patches 
and explain that Titan is the codename of the camera block in your SoC.

---
bod

Re: [PATCH V3 00/13] media: qcom: camss: Add sm8550 support

Posted by Krzysztof Kozlowski 1 year, 7 months ago

On 09/07/2024 18:06, Depeng Shao wrote:
> V3:
> - Rebased the change based on below change which will be merged firstly.
>   "Move camss version related defs in to resources"
> Link: https://lore.kernel.org/all/20240522154659.510-1-quic_grosikop@quicinc.com/
> - Rebased the change based on Bryan's csiphy optimization change and add
> these changes into this series, so that the new csiphy-3ph driver don't
> need to add duplicate code. This has got Bryan's permission to add his
> patches into this series.
> - Refactor some changes based on the comments to move the random code to
> patches where they are used.
> - Remove the vfe780 irq function since it isn't doing the actual work.
> - Add dt-binding for sm8550 camss driver.
> Link to V2: https://lore.kernel.org/all/20240320141136.26827-1-quic_depengs@quicinc.com/

I asked for reference to upstream DTS - where can I find the DTS patches?

Best regards,
Krzysztof

Re: [PATCH V3 00/13] media: qcom: camss: Add sm8550 support

Posted by Depeng Shao 1 year, 7 months ago


On 7/10/2024 7:08 PM, Krzysztof Kozlowski wrote:
> On 09/07/2024 18:06, Depeng Shao wrote:
>> V3:
>> - Rebased the change based on below change which will be merged firstly.
>>    "Move camss version related defs in to resources"
>> Link: https://lore.kernel.org/all/20240522154659.510-1-quic_grosikop@quicinc.com/
>> - Rebased the change based on Bryan's csiphy optimization change and add
>> these changes into this series, so that the new csiphy-3ph driver don't
>> need to add duplicate code. This has got Bryan's permission to add his
>> patches into this series.
>> - Refactor some changes based on the comments to move the random code to
>> patches where they are used.
>> - Remove the vfe780 irq function since it isn't doing the actual work.
>> - Add dt-binding for sm8550 camss driver.
>> Link to V2: https://lore.kernel.org/all/20240320141136.26827-1-quic_depengs@quicinc.com/
> 
> I asked for reference to upstream DTS - where can I find the DTS patches?
> 
> Best regards,
> Krzysztof
> 

Hi Krzysztof,

Sorry for that, I thought add the dt-binding is also fine, since I saw 
other patches also do like this. Will add add the DTS in next patch set.

Thanks,
Depeng

Re: [PATCH V3 00/13] media: qcom: camss: Add sm8550 support

Posted by Krzysztof Kozlowski 1 year, 7 months ago

On 10/07/2024 13:27, Depeng Shao wrote:
> 
> 
> On 7/10/2024 7:08 PM, Krzysztof Kozlowski wrote:
>> On 09/07/2024 18:06, Depeng Shao wrote:
>>> V3:
>>> - Rebased the change based on below change which will be merged firstly.
>>>    "Move camss version related defs in to resources"
>>> Link: https://lore.kernel.org/all/20240522154659.510-1-quic_grosikop@quicinc.com/
>>> - Rebased the change based on Bryan's csiphy optimization change and add
>>> these changes into this series, so that the new csiphy-3ph driver don't
>>> need to add duplicate code. This has got Bryan's permission to add his
>>> patches into this series.
>>> - Refactor some changes based on the comments to move the random code to
>>> patches where they are used.
>>> - Remove the vfe780 irq function since it isn't doing the actual work.
>>> - Add dt-binding for sm8550 camss driver.
>>> Link to V2: https://lore.kernel.org/all/20240320141136.26827-1-quic_depengs@quicinc.com/
>>
>> I asked for reference to upstream DTS - where can I find the DTS patches?
>>
>> Best regards,
>> Krzysztof
>>
> 
> Hi Krzysztof,
> 
> Sorry for that, I thought add the dt-binding is also fine, since I saw 
> other patches also do like this. Will add add the DTS in next patch set.

DTS should not be part of this patchset, but sent separately.  It's
enough if you post a lore link to it.

Best regards,
Krzysztof

Re: [PATCH V3 00/13] media: qcom: camss: Add sm8550 support

Posted by Depeng Shao 1 year, 7 months ago

Hi Krzysztof,

On 7/10/2024 8:30 PM, Krzysztof Kozlowski wrote:
> On 10/07/2024 13:27, Depeng Shao wrote:
>>
>>
>> On 7/10/2024 7:08 PM, Krzysztof Kozlowski wrote:
>>> On 09/07/2024 18:06, Depeng Shao wrote:
>>>> V3:
>>>> - Rebased the change based on below change which will be merged firstly.
>>>>     "Move camss version related defs in to resources"
>>>> Link: https://lore.kernel.org/all/20240522154659.510-1-quic_grosikop@quicinc.com/
>>>> - Rebased the change based on Bryan's csiphy optimization change and add
>>>> these changes into this series, so that the new csiphy-3ph driver don't
>>>> need to add duplicate code. This has got Bryan's permission to add his
>>>> patches into this series.
>>>> - Refactor some changes based on the comments to move the random code to
>>>> patches where they are used.
>>>> - Remove the vfe780 irq function since it isn't doing the actual work.
>>>> - Add dt-binding for sm8550 camss driver.
>>>> Link to V2: https://lore.kernel.org/all/20240320141136.26827-1-quic_depengs@quicinc.com/
>>>
>>> I asked for reference to upstream DTS - where can I find the DTS patches?
>>>
>>> Best regards,
>>> Krzysztof
>>>
>>
>> Hi Krzysztof,
>>
>> Sorry for that, I thought add the dt-binding is also fine, since I saw
>> other patches also do like this. Will add add the DTS in next patch set.
> 
> DTS should not be part of this patchset, but sent separately.  It's
> enough if you post a lore link to it.
> 

Thanks for the explanation, I will post the link in new version series.

> Best regards,
> Krzysztof
> 

Thanks,
Depeng