Add support for the 1200x1920 BOE TV101WUM-LL2 DSI Display Panel found
in the Lenovo Smart Tab M10 tablet. The controller is unknown.
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
---
drivers/gpu/drm/panel/Kconfig | 9 +
drivers/gpu/drm/panel/Makefile | 1 +
drivers/gpu/drm/panel/panel-boe-tv101wum-ll2.c | 240 +++++++++++++++++++++++++
3 files changed, 250 insertions(+)
diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig
index 9f49b0189d3b..b52d255f65e6 100644
--- a/drivers/gpu/drm/panel/Kconfig
+++ b/drivers/gpu/drm/panel/Kconfig
@@ -87,6 +87,15 @@ config DRM_PANEL_BOE_TV101WUM_NL6
Say Y here if you want to support for BOE TV101WUM and AUO KD101N80
45NA WUXGA PANEL DSI Video Mode panel
+config DRM_PANEL_BOE_TV101WUM_LL2
+ tristate "BOE TV101WUM LL2 1200x1920 panel"
+ depends on OF
+ depends on DRM_MIPI_DSI
+ depends on BACKLIGHT_CLASS_DEVICE
+ help
+ Say Y here if you want to support for BOE TV101WUM-LL2
+ WUXGA PANEL DSI Video Mode panel
+
config DRM_PANEL_EBBG_FT8719
tristate "EBBG FT8719 panel driver"
depends on OF
diff --git a/drivers/gpu/drm/panel/Makefile b/drivers/gpu/drm/panel/Makefile
index 5581387707c6..79c90894b6a4 100644
--- a/drivers/gpu/drm/panel/Makefile
+++ b/drivers/gpu/drm/panel/Makefile
@@ -7,6 +7,7 @@ obj-$(CONFIG_DRM_PANEL_BOE_BF060Y8M_AJ0) += panel-boe-bf060y8m-aj0.o
obj-$(CONFIG_DRM_PANEL_BOE_HIMAX8279D) += panel-boe-himax8279d.o
obj-$(CONFIG_DRM_PANEL_BOE_TH101MB31UIG002_28A) += panel-boe-th101mb31ig002-28a.o
obj-$(CONFIG_DRM_PANEL_BOE_TV101WUM_NL6) += panel-boe-tv101wum-nl6.o
+obj-$(CONFIG_DRM_PANEL_BOE_TV101WUM_LL2) += panel-boe-tv101wum-ll2.o
obj-$(CONFIG_DRM_PANEL_DSI_CM) += panel-dsi-cm.o
obj-$(CONFIG_DRM_PANEL_LVDS) += panel-lvds.o
obj-$(CONFIG_DRM_PANEL_SIMPLE) += panel-simple.o
diff --git a/drivers/gpu/drm/panel/panel-boe-tv101wum-ll2.c b/drivers/gpu/drm/panel/panel-boe-tv101wum-ll2.c
new file mode 100644
index 000000000000..5513cb48d949
--- /dev/null
+++ b/drivers/gpu/drm/panel/panel-boe-tv101wum-ll2.c
@@ -0,0 +1,240 @@
+// SPDX-License-Identifier: GPL-2.0-only
+// Generated with linux-mdss-dsi-panel-driver-generator from vendor device tree:
+// Copyright (c) 2013, The Linux Foundation. All rights reserved.
+// Copyright (c) 2024, Neil Armstrong <neil.armstrong@linaro.org>
+
+#include <linux/delay.h>
+#include <linux/gpio/consumer.h>
+#include <linux/regulator/consumer.h>
+#include <linux/module.h>
+#include <linux/of.h>
+
+#include <drm/drm_mipi_dsi.h>
+#include <drm/drm_modes.h>
+#include <drm/drm_panel.h>
+#include <drm/drm_probe_helper.h>
+
+struct boe_tv101wum_ll2 {
+ struct drm_panel panel;
+ struct mipi_dsi_device *dsi;
+ struct gpio_desc *reset_gpio;
+ struct regulator_bulk_data supplies[2];
+};
+
+static inline struct boe_tv101wum_ll2 *to_boe_tv101wum_ll2(struct drm_panel *panel)
+{
+ return container_of(panel, struct boe_tv101wum_ll2, panel);
+}
+
+static void boe_tv101wum_ll2_reset(struct boe_tv101wum_ll2 *ctx)
+{
+ gpiod_set_value_cansleep(ctx->reset_gpio, 0);
+ usleep_range(5000, 6000);
+ gpiod_set_value_cansleep(ctx->reset_gpio, 1);
+ usleep_range(5000, 6000);
+ gpiod_set_value_cansleep(ctx->reset_gpio, 0);
+
+ msleep(120);
+}
+
+static int boe_tv101wum_ll2_on(struct boe_tv101wum_ll2 *ctx)
+{
+ struct mipi_dsi_device *dsi = ctx->dsi;
+ struct mipi_dsi_multi_context dsi_ctx = { .dsi = dsi };
+
+ dsi->mode_flags |= MIPI_DSI_MODE_LPM;
+
+ mipi_dsi_dcs_exit_sleep_mode_multi(&dsi_ctx);
+
+ mipi_dsi_msleep(&dsi_ctx, 120);
+
+ mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0x50, 0x5a, 0x0e);
+ mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0x80, 0xff, 0x81, 0x68, 0x6c, 0x22,
+ 0x6d, 0x12, 0x00, 0x00, 0x00, 0x00, 0x00);
+ mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0x50, 0x5a, 0x23);
+ mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0x90, 0x00, 0x00);
+ mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0x94, 0x2c, 0x00);
+ mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0x50, 0x5a, 0x19);
+ mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xa2, 0x38);
+
+ mipi_dsi_generic_write_seq_multi(&dsi_ctx, 0x50, 0x5a, 0x0c);
+ mipi_dsi_generic_write_seq_multi(&dsi_ctx, 0x80, 0xfd);
+ mipi_dsi_generic_write_seq_multi(&dsi_ctx, 0x50, 0x00);
+
+ mipi_dsi_dcs_set_display_on_multi(&dsi_ctx);
+
+ mipi_dsi_msleep(&dsi_ctx, 20);
+
+ return dsi_ctx.accum_err;
+}
+
+static int boe_tv101wum_ll2_off(struct boe_tv101wum_ll2 *ctx)
+{
+ struct mipi_dsi_device *dsi = ctx->dsi;
+ struct mipi_dsi_multi_context dsi_ctx = { .dsi = dsi };
+
+ dsi->mode_flags &= ~MIPI_DSI_MODE_LPM;
+
+ mipi_dsi_dcs_set_display_off_multi(&dsi_ctx);
+
+ mipi_dsi_msleep(&dsi_ctx, 70);
+
+ mipi_dsi_dcs_enter_sleep_mode_multi(&dsi_ctx);
+
+ mipi_dsi_msleep(&dsi_ctx, 20);
+
+ mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0x04, 0x5a);
+ mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0x05, 0x5a);
+
+ mipi_dsi_msleep(&dsi_ctx, 150);
+
+ return dsi_ctx.accum_err;
+}
+
+static int boe_tv101wum_ll2_prepare(struct drm_panel *panel)
+{
+ struct boe_tv101wum_ll2 *ctx = to_boe_tv101wum_ll2(panel);
+ struct device *dev = &ctx->dsi->dev;
+ int ret;
+
+ ret = regulator_bulk_enable(ARRAY_SIZE(ctx->supplies),
+ ctx->supplies);
+ if (ret < 0)
+ return ret;
+
+ boe_tv101wum_ll2_reset(ctx);
+
+ ret = boe_tv101wum_ll2_on(ctx);
+ if (ret < 0) {
+ dev_err(dev, "Failed to initialize panel: %d\n", ret);
+ gpiod_set_value_cansleep(ctx->reset_gpio, 1);
+ return ret;
+ }
+
+ return 0;
+}
+
+static int boe_tv101wum_ll2_unprepare(struct drm_panel *panel)
+{
+ struct boe_tv101wum_ll2 *ctx = to_boe_tv101wum_ll2(panel);
+ struct device *dev = &ctx->dsi->dev;
+ int ret;
+
+ ret = boe_tv101wum_ll2_off(ctx);
+ if (ret < 0)
+ dev_err(dev, "Failed to un-initialize panel: %d\n", ret);
+
+ gpiod_set_value_cansleep(ctx->reset_gpio, 1);
+
+ regulator_bulk_disable(ARRAY_SIZE(ctx->supplies), ctx->supplies);
+
+ return 0;
+}
+
+static const struct drm_display_mode boe_tv101wum_ll2_mode = {
+ .clock = (1200 + 27 + 8 + 12) * (1920 + 155 + 8 + 32) * 60 / 1000,
+ .hdisplay = 1200,
+ .hsync_start = 1200 + 27,
+ .hsync_end = 1200 + 27 + 8,
+ .htotal = 1200 + 27 + 8 + 12,
+ .vdisplay = 1920,
+ .vsync_start = 1920 + 155,
+ .vsync_end = 1920 + 155 + 8,
+ .vtotal = 1920 + 155 + 8 + 32,
+ .width_mm = 136,
+ .height_mm = 217,
+ .type = DRM_MODE_TYPE_DRIVER,
+};
+
+static int boe_tv101wum_ll2_get_modes(struct drm_panel *panel,
+ struct drm_connector *connector)
+{
+ return drm_connector_helper_get_modes_fixed(connector, &boe_tv101wum_ll2_mode);
+}
+
+static const struct drm_panel_funcs boe_tv101wum_ll2_panel_funcs = {
+ .prepare = boe_tv101wum_ll2_prepare,
+ .unprepare = boe_tv101wum_ll2_unprepare,
+ .get_modes = boe_tv101wum_ll2_get_modes,
+};
+
+static int boe_tv101wum_ll2_probe(struct mipi_dsi_device *dsi)
+{
+ struct device *dev = &dsi->dev;
+ struct boe_tv101wum_ll2 *ctx;
+ int ret;
+
+ ctx = devm_kzalloc(dev, sizeof(*ctx), GFP_KERNEL);
+ if (!ctx)
+ return -ENOMEM;
+
+ ctx->supplies[0].supply = "vsp";
+ ctx->supplies[1].supply = "vsn";
+
+ ret = devm_regulator_bulk_get(&dsi->dev, ARRAY_SIZE(ctx->supplies),
+ ctx->supplies);
+ if (ret < 0)
+ return ret;
+
+ ctx->reset_gpio = devm_gpiod_get(dev, "reset", GPIOD_OUT_LOW);
+ if (IS_ERR(ctx->reset_gpio))
+ return dev_err_probe(dev, PTR_ERR(ctx->reset_gpio),
+ "Failed to get reset-gpios\n");
+
+ ctx->dsi = dsi;
+ mipi_dsi_set_drvdata(dsi, ctx);
+
+ dsi->lanes = 4;
+ dsi->format = MIPI_DSI_FMT_RGB888;
+ dsi->mode_flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_BURST |
+ MIPI_DSI_MODE_VIDEO_HSE;
+
+ drm_panel_init(&ctx->panel, dev, &boe_tv101wum_ll2_panel_funcs,
+ DRM_MODE_CONNECTOR_DSI);
+ ctx->panel.prepare_prev_first = true;
+
+ ret = drm_panel_of_backlight(&ctx->panel);
+ if (ret)
+ return dev_err_probe(dev, ret, "Failed to get backlight\n");
+
+ drm_panel_add(&ctx->panel);
+
+ ret = mipi_dsi_attach(dsi);
+ if (ret < 0) {
+ drm_panel_remove(&ctx->panel);
+ return dev_err_probe(dev, ret, "Failed to attach to DSI host\n");
+ }
+
+ return 0;
+}
+
+static void boe_tv101wum_ll2_remove(struct mipi_dsi_device *dsi)
+{
+ struct boe_tv101wum_ll2 *ctx = mipi_dsi_get_drvdata(dsi);
+ int ret;
+
+ ret = mipi_dsi_detach(dsi);
+ if (ret < 0)
+ dev_err(&dsi->dev, "Failed to detach from DSI host: %d\n", ret);
+
+ drm_panel_remove(&ctx->panel);
+}
+
+static const struct of_device_id boe_tv101wum_ll2_of_match[] = {
+ { .compatible = "boe,tv101wum-ll2" },
+ { /* sentinel */ }
+};
+MODULE_DEVICE_TABLE(of, boe_tv101wum_ll2_of_match);
+
+static struct mipi_dsi_driver boe_tv101wum_ll2_driver = {
+ .probe = boe_tv101wum_ll2_probe,
+ .remove = boe_tv101wum_ll2_remove,
+ .driver = {
+ .name = "panel-boe-tv101wum_ll2",
+ .of_match_table = boe_tv101wum_ll2_of_match,
+ },
+};
+module_mipi_dsi_driver(boe_tv101wum_ll2_driver);
+
+MODULE_DESCRIPTION("DRM driver for Boe TV101WUM-LL2 Panel");
+MODULE_LICENSE("GPL");
--
2.34.1Hi,
On Tue, Jul 9, 2024 at 6:06 AM Neil Armstrong <neil.armstrong@linaro.org> wrote:
>
> diff --git a/drivers/gpu/drm/panel/Makefile b/drivers/gpu/drm/panel/Makefile
> index 5581387707c6..79c90894b6a4 100644
> --- a/drivers/gpu/drm/panel/Makefile
> +++ b/drivers/gpu/drm/panel/Makefile
> @@ -7,6 +7,7 @@ obj-$(CONFIG_DRM_PANEL_BOE_BF060Y8M_AJ0) += panel-boe-bf060y8m-aj0.o
> obj-$(CONFIG_DRM_PANEL_BOE_HIMAX8279D) += panel-boe-himax8279d.o
> obj-$(CONFIG_DRM_PANEL_BOE_TH101MB31UIG002_28A) += panel-boe-th101mb31ig002-28a.o
> obj-$(CONFIG_DRM_PANEL_BOE_TV101WUM_NL6) += panel-boe-tv101wum-nl6.o
> +obj-$(CONFIG_DRM_PANEL_BOE_TV101WUM_LL2) += panel-boe-tv101wum-ll2.o
nit: please sort. L comes before N.
> obj-$(CONFIG_DRM_PANEL_DSI_CM) += panel-dsi-cm.o
> obj-$(CONFIG_DRM_PANEL_LVDS) += panel-lvds.o
> obj-$(CONFIG_DRM_PANEL_SIMPLE) += panel-simple.o
> diff --git a/drivers/gpu/drm/panel/panel-boe-tv101wum-ll2.c b/drivers/gpu/drm/panel/panel-boe-tv101wum-ll2.c
> new file mode 100644
> index 000000000000..5513cb48d949
> --- /dev/null
> +++ b/drivers/gpu/drm/panel/panel-boe-tv101wum-ll2.c
> @@ -0,0 +1,240 @@
> +// SPDX-License-Identifier: GPL-2.0-only
> +// Generated with linux-mdss-dsi-panel-driver-generator from vendor device tree:
> +// Copyright (c) 2013, The Linux Foundation. All rights reserved.
> +// Copyright (c) 2024, Neil Armstrong <neil.armstrong@linaro.org>
> +
> +#include <linux/delay.h>
> +#include <linux/gpio/consumer.h>
> +#include <linux/regulator/consumer.h>
> +#include <linux/module.h>
> +#include <linux/of.h>
nit: sort header files?
> +static int boe_tv101wum_ll2_prepare(struct drm_panel *panel)
> +{
> + struct boe_tv101wum_ll2 *ctx = to_boe_tv101wum_ll2(panel);
> + struct device *dev = &ctx->dsi->dev;
> + int ret;
> +
> + ret = regulator_bulk_enable(ARRAY_SIZE(ctx->supplies),
> + ctx->supplies);
> + if (ret < 0)
> + return ret;
> +
> + boe_tv101wum_ll2_reset(ctx);
> +
> + ret = boe_tv101wum_ll2_on(ctx);
> + if (ret < 0) {
> + dev_err(dev, "Failed to initialize panel: %d\n", ret);
nit: Do you really need this error message? The "_multi" variants are
all chatty and print the error message, so we don't really need this
here...
> + gpiod_set_value_cansleep(ctx->reset_gpio, 1);
> + return ret;
Shouldn't you turn off the regulators?
> +static int boe_tv101wum_ll2_unprepare(struct drm_panel *panel)
> +{
> + struct boe_tv101wum_ll2 *ctx = to_boe_tv101wum_ll2(panel);
> + struct device *dev = &ctx->dsi->dev;
> + int ret;
> +
> + ret = boe_tv101wum_ll2_off(ctx);
> + if (ret < 0)
> + dev_err(dev, "Failed to un-initialize panel: %d\n", ret);
nit: Do you really need this error message? The "_multi" variants are
all chatty and print the error message, so we don't really need this
here...
> +
> + gpiod_set_value_cansleep(ctx->reset_gpio, 1);
> +
> + regulator_bulk_disable(ARRAY_SIZE(ctx->supplies), ctx->supplies);
> +
> + return 0;
Maybe add a comment justifying why you don't return the error code
that boe_tv101wum_ll2_off() returned?
> +static int boe_tv101wum_ll2_get_modes(struct drm_panel *panel,
> + struct drm_connector *connector)
> +{
> + return drm_connector_helper_get_modes_fixed(connector, &boe_tv101wum_ll2_mode);
Random question for you: on panels that don't use the
drm_connector_helper the "bpc" gets set here. Is there a reason why
some panel drivers (like this one) don't set bpc?
> +static int boe_tv101wum_ll2_probe(struct mipi_dsi_device *dsi)
> +{
> + struct device *dev = &dsi->dev;
> + struct boe_tv101wum_ll2 *ctx;
> + int ret;
> +
> + ctx = devm_kzalloc(dev, sizeof(*ctx), GFP_KERNEL);
> + if (!ctx)
> + return -ENOMEM;
> +
> + ctx->supplies[0].supply = "vsp";
> + ctx->supplies[1].supply = "vsn";
> +
> + ret = devm_regulator_bulk_get(&dsi->dev, ARRAY_SIZE(ctx->supplies),
> + ctx->supplies);
Any chance I can convince you to use devm_regulator_bulk_get_const()?
Then you can list your supply structures as "static const" instead of
having to initialize them via code.
> + if (ret < 0)
> + return ret;
> +
> + ctx->reset_gpio = devm_gpiod_get(dev, "reset", GPIOD_OUT_LOW);
> + if (IS_ERR(ctx->reset_gpio))
> + return dev_err_probe(dev, PTR_ERR(ctx->reset_gpio),
> + "Failed to get reset-gpios\n");
> +
> + ctx->dsi = dsi;
> + mipi_dsi_set_drvdata(dsi, ctx);
> +
> + dsi->lanes = 4;
> + dsi->format = MIPI_DSI_FMT_RGB888;
> + dsi->mode_flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_BURST |
> + MIPI_DSI_MODE_VIDEO_HSE;
> +
> + drm_panel_init(&ctx->panel, dev, &boe_tv101wum_ll2_panel_funcs,
> + DRM_MODE_CONNECTOR_DSI);
> + ctx->panel.prepare_prev_first = true;
> +
> + ret = drm_panel_of_backlight(&ctx->panel);
> + if (ret)
> + return dev_err_probe(dev, ret, "Failed to get backlight\n");
> +
> + drm_panel_add(&ctx->panel);
Any chance you could add devm_drm_panel_add() and then use it? Then
you can fully get rid of your remove and error handling since
devm_mipi_dsi_attach() already exists. Note that this would not change
object lifetimes at all since you're already calling
drm_panel_remove() in your remove code--it would just clean up the
code...
> +static struct mipi_dsi_driver boe_tv101wum_ll2_driver = {
> + .probe = boe_tv101wum_ll2_probe,
> + .remove = boe_tv101wum_ll2_remove,
> + .driver = {
> + .name = "panel-boe-tv101wum_ll2",
> + .of_match_table = boe_tv101wum_ll2_of_match,
> + },
> +};
> +module_mipi_dsi_driver(boe_tv101wum_ll2_driver);
> +
> +MODULE_DESCRIPTION("DRM driver for Boe TV101WUM-LL2 Panel");
Should "Boe" be "BOE" ?
On 23/07/2024 21:17, Doug Anderson wrote:
> Hi,
>
> On Tue, Jul 9, 2024 at 6:06 AM Neil Armstrong <neil.armstrong@linaro.org> wrote:
>>
>> diff --git a/drivers/gpu/drm/panel/Makefile b/drivers/gpu/drm/panel/Makefile
>> index 5581387707c6..79c90894b6a4 100644
>> --- a/drivers/gpu/drm/panel/Makefile
>> +++ b/drivers/gpu/drm/panel/Makefile
>> @@ -7,6 +7,7 @@ obj-$(CONFIG_DRM_PANEL_BOE_BF060Y8M_AJ0) += panel-boe-bf060y8m-aj0.o
>> obj-$(CONFIG_DRM_PANEL_BOE_HIMAX8279D) += panel-boe-himax8279d.o
>> obj-$(CONFIG_DRM_PANEL_BOE_TH101MB31UIG002_28A) += panel-boe-th101mb31ig002-28a.o
>> obj-$(CONFIG_DRM_PANEL_BOE_TV101WUM_NL6) += panel-boe-tv101wum-nl6.o
>> +obj-$(CONFIG_DRM_PANEL_BOE_TV101WUM_LL2) += panel-boe-tv101wum-ll2.o
>
> nit: please sort. L comes before N.
Good catch, thx
>
>
>> obj-$(CONFIG_DRM_PANEL_DSI_CM) += panel-dsi-cm.o
>> obj-$(CONFIG_DRM_PANEL_LVDS) += panel-lvds.o
>> obj-$(CONFIG_DRM_PANEL_SIMPLE) += panel-simple.o
>> diff --git a/drivers/gpu/drm/panel/panel-boe-tv101wum-ll2.c b/drivers/gpu/drm/panel/panel-boe-tv101wum-ll2.c
>> new file mode 100644
>> index 000000000000..5513cb48d949
>> --- /dev/null
>> +++ b/drivers/gpu/drm/panel/panel-boe-tv101wum-ll2.c
>> @@ -0,0 +1,240 @@
>> +// SPDX-License-Identifier: GPL-2.0-only
>> +// Generated with linux-mdss-dsi-panel-driver-generator from vendor device tree:
>> +// Copyright (c) 2013, The Linux Foundation. All rights reserved.
>> +// Copyright (c) 2024, Neil Armstrong <neil.armstrong@linaro.org>
>> +
>> +#include <linux/delay.h>
>> +#include <linux/gpio/consumer.h>
>> +#include <linux/regulator/consumer.h>
>> +#include <linux/module.h>
>> +#include <linux/of.h>
>
> nit: sort header files?
Will do while I'm it, but I don't personally care of the include order..
>
>> +static int boe_tv101wum_ll2_prepare(struct drm_panel *panel)
>> +{
>> + struct boe_tv101wum_ll2 *ctx = to_boe_tv101wum_ll2(panel);
>> + struct device *dev = &ctx->dsi->dev;
>> + int ret;
>> +
>> + ret = regulator_bulk_enable(ARRAY_SIZE(ctx->supplies),
>> + ctx->supplies);
>> + if (ret < 0)
>> + return ret;
>> +
>> + boe_tv101wum_ll2_reset(ctx);
>> +
>> + ret = boe_tv101wum_ll2_on(ctx);
>> + if (ret < 0) {
>> + dev_err(dev, "Failed to initialize panel: %d\n", ret);
>
> nit: Do you really need this error message? The "_multi" variants are
> all chatty and print the error message, so we don't really need this
> here...
Yeah you're right, it's a leftover of the linux-mdss-dsi-panel-driver-generator
>
>
>> + gpiod_set_value_cansleep(ctx->reset_gpio, 1);
>> + return ret;
>
> Shouldn't you turn off the regulators?
Indeed
>
>
>> +static int boe_tv101wum_ll2_unprepare(struct drm_panel *panel)
>> +{
>> + struct boe_tv101wum_ll2 *ctx = to_boe_tv101wum_ll2(panel);
>> + struct device *dev = &ctx->dsi->dev;
>> + int ret;
>> +
>> + ret = boe_tv101wum_ll2_off(ctx);
>> + if (ret < 0)
>> + dev_err(dev, "Failed to un-initialize panel: %d\n", ret);
>
> nit: Do you really need this error message? The "_multi" variants are
> all chatty and print the error message, so we don't really need this
> here...
Another leftover
>
>
>> +
>> + gpiod_set_value_cansleep(ctx->reset_gpio, 1);
>> +
>> + regulator_bulk_disable(ARRAY_SIZE(ctx->supplies), ctx->supplies);
>> +
>> + return 0;
>
> Maybe add a comment justifying why you don't return the error code
> that boe_tv101wum_ll2_off() returned?
Good point, as far as I remember I always avoided returning errors
when disabling things, I'll investigate
>
>
>> +static int boe_tv101wum_ll2_get_modes(struct drm_panel *panel,
>> + struct drm_connector *connector)
>> +{
>> + return drm_connector_helper_get_modes_fixed(connector, &boe_tv101wum_ll2_mode);
>
> Random question for you: on panels that don't use the
> drm_connector_helper the "bpc" gets set here. Is there a reason why
> some panel drivers (like this one) don't set bpc?
Good question, I'll check
>
>
>> +static int boe_tv101wum_ll2_probe(struct mipi_dsi_device *dsi)
>> +{
>> + struct device *dev = &dsi->dev;
>> + struct boe_tv101wum_ll2 *ctx;
>> + int ret;
>> +
>> + ctx = devm_kzalloc(dev, sizeof(*ctx), GFP_KERNEL);
>> + if (!ctx)
>> + return -ENOMEM;
>> +
>> + ctx->supplies[0].supply = "vsp";
>> + ctx->supplies[1].supply = "vsn";
>> +
>> + ret = devm_regulator_bulk_get(&dsi->dev, ARRAY_SIZE(ctx->supplies),
>> + ctx->supplies);
>
> Any chance I can convince you to use devm_regulator_bulk_get_const()?
> Then you can list your supply structures as "static const" instead of
> having to initialize them via code.
You convinced me!
>
>
>> + if (ret < 0)
>> + return ret;
>> +
>> + ctx->reset_gpio = devm_gpiod_get(dev, "reset", GPIOD_OUT_LOW);
>> + if (IS_ERR(ctx->reset_gpio))
>> + return dev_err_probe(dev, PTR_ERR(ctx->reset_gpio),
>> + "Failed to get reset-gpios\n");
>> +
>> + ctx->dsi = dsi;
>> + mipi_dsi_set_drvdata(dsi, ctx);
>> +
>> + dsi->lanes = 4;
>> + dsi->format = MIPI_DSI_FMT_RGB888;
>> + dsi->mode_flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_BURST |
>> + MIPI_DSI_MODE_VIDEO_HSE;
>> +
>> + drm_panel_init(&ctx->panel, dev, &boe_tv101wum_ll2_panel_funcs,
>> + DRM_MODE_CONNECTOR_DSI);
>> + ctx->panel.prepare_prev_first = true;
>> +
>> + ret = drm_panel_of_backlight(&ctx->panel);
>> + if (ret)
>> + return dev_err_probe(dev, ret, "Failed to get backlight\n");
>> +
>> + drm_panel_add(&ctx->panel);
>
> Any chance you could add devm_drm_panel_add() and then use it? Then
> you can fully get rid of your remove and error handling since
> devm_mipi_dsi_attach() already exists. Note that this would not change
> object lifetimes at all since you're already calling
> drm_panel_remove() in your remove code--it would just clean up the
> code...
Yep I'll use it
>
>
>> +static struct mipi_dsi_driver boe_tv101wum_ll2_driver = {
>> + .probe = boe_tv101wum_ll2_probe,
>> + .remove = boe_tv101wum_ll2_remove,
>> + .driver = {
>> + .name = "panel-boe-tv101wum_ll2",
>> + .of_match_table = boe_tv101wum_ll2_of_match,
>> + },
>> +};
>> +module_mipi_dsi_driver(boe_tv101wum_ll2_driver);
>> +
>> +MODULE_DESCRIPTION("DRM driver for Boe TV101WUM-LL2 Panel");
>
> Should "Boe" be "BOE" ?
Good point aswell!
Thanks for the review
Neil
On 24/07/2024 09:50, Neil Armstrong wrote:
> On 23/07/2024 21:17, Doug Anderson wrote:
>> Hi,
>>
>> On Tue, Jul 9, 2024 at 6:06 AM Neil Armstrong <neil.armstrong@linaro.org> wrote:
>>>
<snip>
>>
>>> +static int boe_tv101wum_ll2_get_modes(struct drm_panel *panel,
>>> + struct drm_connector *connector)
>>> +{
>>> + return drm_connector_helper_get_modes_fixed(connector, &boe_tv101wum_ll2_mode);
>>
>> Random question for you: on panels that don't use the
>> drm_connector_helper the "bpc" gets set here. Is there a reason why
>> some panel drivers (like this one) don't set bpc?
>
> Good question, I'll check
Ok so the documentation says :
https://elixir.bootlin.com/linux/v6.11-rc5/source/include/drm/drm_connector.h#L698
* @bpc: Maximum bits per color channel. Used by HDMI and DP outputs.
and looking at the code, all drivers considers bpc=8 when unset.
but yeah ultimately drm_connector_helper_get_modes_fixed should have a variant to set the bpc
when != 8.
In this case it's useless.
Neil
<snip>
Hi, On Wed, Jul 24, 2024 at 12:51 AM Neil Armstrong <neil.armstrong@linaro.org> wrote: > > >> @@ -0,0 +1,240 @@ > >> +// SPDX-License-Identifier: GPL-2.0-only > >> +// Generated with linux-mdss-dsi-panel-driver-generator from vendor device tree: > >> +// Copyright (c) 2013, The Linux Foundation. All rights reserved. > >> +// Copyright (c) 2024, Neil Armstrong <neil.armstrong@linaro.org> > >> + > >> +#include <linux/delay.h> > >> +#include <linux/gpio/consumer.h> > >> +#include <linux/regulator/consumer.h> > >> +#include <linux/module.h> > >> +#include <linux/of.h> > > > > nit: sort header files? > > Will do while I'm it, but I don't personally care of the include order.. FWIW: the main reason I push for sorting in cases like this is to avoid merge conflicts as the driver changes. If everyone adds new #includes at the end then every change will cause a merge conflict. If things are kept sorted it's still possible to get a merge conflict but the number goes down. Probably not super relevant in such a simple driver but just the policy I push for in general. The criteria for sorting doesn't matter to me (some people put "nested" includes in separate sections and some just do a normal sort) as long as it's obvious / consistent for a given file. -Doug
Hi Jessica, Doug, On 09/07/2024 15:05, Neil Armstrong wrote: > Add support for the 1200x1920 BOE TV101WUM-LL2 DSI Display Panel found > in the Lenovo Smart Tab M10 tablet. The controller is unknown. Could you review this patch ? Thanks ! Neil > > Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> > --- > drivers/gpu/drm/panel/Kconfig | 9 + > drivers/gpu/drm/panel/Makefile | 1 + > drivers/gpu/drm/panel/panel-boe-tv101wum-ll2.c | 240 +++++++++++++++++++++++++ > 3 files changed, 250 insertions(+) > <snip>
© 2016 - 2025 Red Hat, Inc.