[v2] arm64: dts: qcom: sa8775p: Add interconnects for ethernet

[PATCH v2] arm64: dts: qcom: sa8775p: Add interconnects for ethernet

Posted by Sagar Cheluvegowda 1 year, 5 months ago

Define interconnect properties for ethernet hardware.

Suggested-by: Andrew Halaney <ahalaney@redhat.com>
Signed-off-by: Sagar Cheluvegowda <quic_scheluve@quicinc.com>
---
Adding interconnect dtsi properties within ethernet node of SA8775P,
this patch is adding support for the interconnect properties defined
in the series ->  
https://lore.kernel.org/all/20240703-icc_bw_voting_from_ethqos-v3-0-8f9148ac60a3@quicinc.com/
---
Changes in v2:
- Rearrange the interconnect properties for SA8775P to follow the below order.
	property
	property-names
- Link to v1: https://lore.kernel.org/r/20240708-icc_bw_voting_emac_dtsi-v1-1-4b091b3150c0@quicinc.com
---
 arch/arm64/boot/dts/qcom/sa8775p.dtsi | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
index 23f1b2e5e624..cc4ad901fbac 100644
--- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi
+++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
@@ -3464,6 +3464,12 @@ ethernet1: ethernet@23000000 {
 				      "ptp_ref",
 				      "phyaux";
 
+			interconnects = <&aggre1_noc MASTER_EMAC_1 QCOM_ICC_TAG_ALWAYS
+					 &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>,
+					<&gem_noc MASTER_APPSS_PROC QCOM_ICC_TAG_ALWAYS
+					 &config_noc SLAVE_EMAC1_CFG QCOM_ICC_TAG_ALWAYS>;
+			interconnect-names = "mac-mem", "cpu-mac";
+
 			power-domains = <&gcc EMAC1_GDSC>;
 
 			phys = <&serdes1>;
@@ -3499,6 +3505,12 @@ ethernet0: ethernet@23040000 {
 				      "ptp_ref",
 				      "phyaux";
 
+			interconnects = <&aggre1_noc MASTER_EMAC QCOM_ICC_TAG_ALWAYS
+					 &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>,
+					<&gem_noc MASTER_APPSS_PROC QCOM_ICC_TAG_ALWAYS
+					 &config_noc SLAVE_EMAC_CFG QCOM_ICC_TAG_ALWAYS>;
+			interconnect-names = "mac-mem", "cpu-mac";
+
 			power-domains = <&gcc EMAC0_GDSC>;
 
 			phys = <&serdes0>;

---
base-commit: 0b58e108042b0ed28a71cd7edf5175999955b233
change-id: 20240703-icc_bw_voting_emac_dtsi-2a09f9a18174

Best regards,
-- 
Sagar Cheluvegowda <quic_scheluve@quicinc.com>

Re: [PATCH v2] arm64: dts: qcom: sa8775p: Add interconnects for ethernet

Posted by Bjorn Andersson 1 year, 4 months ago

On Tue, 09 Jul 2024 11:21:40 -0700, Sagar Cheluvegowda wrote:
> Define interconnect properties for ethernet hardware.
> 
> 

Applied, thanks!

[1/1] arm64: dts: qcom: sa8775p: Add interconnects for ethernet
      commit: e93230d0597a2736f1123cd7790a4e549f3049a8

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>

Re: [PATCH v2] arm64: dts: qcom: sa8775p: Add interconnects for ethernet

Posted by Konrad Dybcio 1 year, 5 months ago

On 9.07.2024 8:21 PM, Sagar Cheluvegowda wrote:
> Define interconnect properties for ethernet hardware.
> 
> Suggested-by: Andrew Halaney <ahalaney@redhat.com>
> Signed-off-by: Sagar Cheluvegowda <quic_scheluve@quicinc.com>
> ---
> Adding interconnect dtsi properties within ethernet node of SA8775P,
> this patch is adding support for the interconnect properties defined
> in the series ->  
> https://lore.kernel.org/all/20240703-icc_bw_voting_from_ethqos-v3-0-8f9148ac60a3@quicinc.com/
> ---

Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad