pinctrl: qcom: Add the QCS9100 tlmm compatible

[PATCH v2 1/2] dt-bindings: pinctrl: add qcs9100-tlmm compatible

Posted by Tengfei Fan 1 year, 5 months ago

Add qcs9100-tlmm compatible for QCS9100 SoC.
QCS9100 is drived from SA8775p. Currently, both the QCS9100 and SA8775p
platform use non-SCMI resource. In the future, the SA8775p platform will
move to use SCMI resources and it will have new sa8775p-related device
tree. Consequently, introduce "qcs9100-tlmm" to describe non-SCMI based
pinctrl.

Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com>
---
 Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml
index e9abbf2c0689..1bdec08efc4a 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml
@@ -17,7 +17,10 @@ allOf:
 
 properties:
   compatible:
-    const: qcom,sa8775p-tlmm
+    items:
+      - enum:
+          - qcom,qcs9100-tlmm
+          - qcom,sa8775p-tlmm
 
   reg:
     maxItems: 1

-- 
2.25.1

Re: [PATCH v2 1/2] dt-bindings: pinctrl: add qcs9100-tlmm compatible

Posted by Krzysztof Kozlowski 1 year, 5 months ago

On 09/07/2024 15:04, Tengfei Fan wrote:
> Add qcs9100-tlmm compatible for QCS9100 SoC.
> QCS9100 is drived from SA8775p. Currently, both the QCS9100 and SA8775p
> platform use non-SCMI resource. In the future, the SA8775p platform will
> move to use SCMI resources and it will have new sa8775p-related device
> tree. Consequently, introduce "qcs9100-tlmm" to describe non-SCMI based
> pinctrl.
> 
> Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com>
> ---
>  Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml
> index e9abbf2c0689..1bdec08efc4a 100644
> --- a/Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml
> @@ -17,7 +17,10 @@ allOf:
>  
>  properties:
>    compatible:
> -    const: qcom,sa8775p-tlmm
> +    items:

Same comment as in other patchset, so apparently you made all of patches
in similar way. No need to add items.

Best regards,
Krzysztof

Re: [PATCH v2 1/2] dt-bindings: pinctrl: add qcs9100-tlmm compatible

Posted by Tengfei Fan 1 year, 5 months ago


On 7/10/2024 6:14 PM, Krzysztof Kozlowski wrote:
> On 09/07/2024 15:04, Tengfei Fan wrote:
>> Add qcs9100-tlmm compatible for QCS9100 SoC.
>> QCS9100 is drived from SA8775p. Currently, both the QCS9100 and SA8775p
>> platform use non-SCMI resource. In the future, the SA8775p platform will
>> move to use SCMI resources and it will have new sa8775p-related device
>> tree. Consequently, introduce "qcs9100-tlmm" to describe non-SCMI based
>> pinctrl.
>>
>> Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com>
>> ---
>>   Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml | 5 ++++-
>>   1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml
>> index e9abbf2c0689..1bdec08efc4a 100644
>> --- a/Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml
>> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml
>> @@ -17,7 +17,10 @@ allOf:
>>   
>>   properties:
>>     compatible:
>> -    const: qcom,sa8775p-tlmm
>> +    items:
> 
> Same comment as in other patchset, so apparently you made all of patches
> in similar way. No need to add items.
> 
> Best regards,
> Krzysztof
> 

I will use an enum directly in all the patches with similar 
modifications in the next patch series.

-- 
Thx and BRs,
Tengfei Fan

Re: [PATCH v2 1/2] dt-bindings: pinctrl: add qcs9100-tlmm compatible

Posted by Tengfei Fan 1 year, 4 months ago


On 7/10/2024 6:26 PM, Tengfei Fan wrote:
> 
> 
> On 7/10/2024 6:14 PM, Krzysztof Kozlowski wrote:
>> On 09/07/2024 15:04, Tengfei Fan wrote:
>>> Add qcs9100-tlmm compatible for QCS9100 SoC.
>>> QCS9100 is drived from SA8775p. Currently, both the QCS9100 and SA8775p
>>> platform use non-SCMI resource. In the future, the SA8775p platform will
>>> move to use SCMI resources and it will have new sa8775p-related device
>>> tree. Consequently, introduce "qcs9100-tlmm" to describe non-SCMI based
>>> pinctrl.
>>>
>>> Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com>
>>> ---
>>>   Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml | 
>>> 5 ++++-
>>>   1 file changed, 4 insertions(+), 1 deletion(-)
>>>
>>> diff --git 
>>> a/Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml 
>>> b/Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml
>>> index e9abbf2c0689..1bdec08efc4a 100644
>>> --- a/Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml
>>> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sa8775p-tlmm.yaml
>>> @@ -17,7 +17,10 @@ allOf:
>>>   properties:
>>>     compatible:
>>> -    const: qcom,sa8775p-tlmm
>>> +    items:
>>
>> Same comment as in other patchset, so apparently you made all of patches
>> in similar way. No need to add items.
>>
>> Best regards,
>> Krzysztof
>>
> 
> I will use an enum directly in all the patches with similar 
> modifications in the next patch series.

After considering the feedback provided on the subject, We have decided
to keep current SA8775p compatible and ABI compatibility in drivers.
Let's close this session and ignore all the current patches here.
Thank you for your input.

> 

-- 
Thx and BRs,
Tengfei Fan