[PATCH v2 2/2] PCI: qcom: Add support for QCS9100 SoC

Tengfei Fan posted 2 patches 1 year, 7 months ago
[PATCH v2 2/2] PCI: qcom: Add support for QCS9100 SoC
Posted by Tengfei Fan 1 year, 7 months ago
Add support for QCS9100 SoC that uses controller version 5.90
reusing the 1.9.0 config.
QCS9100 is drived from SA8775p. Currently, both the QCS9100 and SA8775p
platform use non-SCMI resource. In the future, the SA8775p platform will
move to use SCMI resources and it will have new sa8775p-related device
tree. Consequently, introduce "qcom,pcie-qcs9100" to the PCIe device
match table.

Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com>
---
 drivers/pci/controller/dwc/pcie-qcom.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controller/dwc/pcie-qcom.c
index 26405fcfa499..ea3fddc74498 100644
--- a/drivers/pci/controller/dwc/pcie-qcom.c
+++ b/drivers/pci/controller/dwc/pcie-qcom.c
@@ -1722,6 +1722,7 @@ static const struct of_device_id qcom_pcie_match[] = {
 	{ .compatible = "qcom,pcie-ipq8074-gen3", .data = &cfg_2_9_0 },
 	{ .compatible = "qcom,pcie-msm8996", .data = &cfg_2_3_2 },
 	{ .compatible = "qcom,pcie-qcs404", .data = &cfg_2_4_0 },
+	{ .compatible = "qcom,pcie-qcs9100", .data = &cfg_sc8280xp },
 	{ .compatible = "qcom,pcie-sa8540p", .data = &cfg_sc8280xp },
 	{ .compatible = "qcom,pcie-sa8775p", .data = &cfg_1_34_0},
 	{ .compatible = "qcom,pcie-sc7280", .data = &cfg_1_9_0 },

-- 
2.25.1
Re: [PATCH v2 2/2] PCI: qcom: Add support for QCS9100 SoC
Posted by Bjorn Helgaas 1 year, 7 months ago
On Tue, Jul 09, 2024 at 10:59:30PM +0800, Tengfei Fan wrote:
> Add support for QCS9100 SoC that uses controller version 5.90
> reusing the 1.9.0 config.

Add blank line here if this is a paragraph break.

> QCS9100 is drived from SA8775p. Currently, both the QCS9100 and SA8775p
> platform use non-SCMI resource. In the future, the SA8775p platform will
> move to use SCMI resources and it will have new sa8775p-related device
> tree. Consequently, introduce "qcom,pcie-qcs9100" to the PCIe device
> match table.
> 
> Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com>
> ---
>  drivers/pci/controller/dwc/pcie-qcom.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controller/dwc/pcie-qcom.c
> index 26405fcfa499..ea3fddc74498 100644
> --- a/drivers/pci/controller/dwc/pcie-qcom.c
> +++ b/drivers/pci/controller/dwc/pcie-qcom.c
> @@ -1722,6 +1722,7 @@ static const struct of_device_id qcom_pcie_match[] = {
>  	{ .compatible = "qcom,pcie-ipq8074-gen3", .data = &cfg_2_9_0 },
>  	{ .compatible = "qcom,pcie-msm8996", .data = &cfg_2_3_2 },
>  	{ .compatible = "qcom,pcie-qcs404", .data = &cfg_2_4_0 },
> +	{ .compatible = "qcom,pcie-qcs9100", .data = &cfg_sc8280xp },
>  	{ .compatible = "qcom,pcie-sa8540p", .data = &cfg_sc8280xp },
>  	{ .compatible = "qcom,pcie-sa8775p", .data = &cfg_1_34_0},
>  	{ .compatible = "qcom,pcie-sc7280", .data = &cfg_1_9_0 },
> 
> -- 
> 2.25.1
>
Re: [PATCH v2 2/2] PCI: qcom: Add support for QCS9100 SoC
Posted by Tengfei Fan 1 year, 7 months ago

On 7/10/2024 12:26 AM, Bjorn Helgaas wrote:
> Add blank line here if this is a paragraph break.

A blank line will be added in the next verion patch series.


-- 
Thx and BRs,
Tengfei Fan
Re: [PATCH v2 2/2] PCI: qcom: Add support for QCS9100 SoC
Posted by Tengfei Fan 1 year, 6 months ago

On 7/10/2024 2:38 PM, Tengfei Fan wrote:
> 
> 
> On 7/10/2024 12:26 AM, Bjorn Helgaas wrote:
>> Add blank line here if this is a paragraph break.
> 
> A blank line will be added in the next verion patch series.

After considering the feedback provided on the subject, We have decided
to keep current SA8775p compatible and ABI compatibility in drivers.
Let's close this session and ignore all the current patches here.
Thank you for your input.

> 
> 

-- 
Thx and BRs,
Tengfei Fan