[PATCH] dt-bindings: display: bridge: ti,sn65dsi83: add burst-mode-disabled

stefano.radaelli21@gmail.com posted 1 patch 1 year, 7 months ago
.../devicetree/bindings/display/bridge/ti,sn65dsi83.yaml       | 3 +++
1 file changed, 3 insertions(+)
[PATCH] dt-bindings: display: bridge: ti,sn65dsi83: add burst-mode-disabled
Posted by stefano.radaelli21@gmail.com 1 year, 7 months ago
From: Stefano Radaelli <stefano.radaelli21@gmail.com>

It allows to disable Burst video mode

Co-developed-by: Noah J. Rosa <noahj.rosa@gmail.com>
Signed-off-by: Noah J. Rosa <noahj.rosa@gmail.com>
Signed-off-by: Stefano Radaelli <stefano.radaelli21@gmail.com>
---
 .../devicetree/bindings/display/bridge/ti,sn65dsi83.yaml       | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml
index 48a97bb3e2e0..eb9c8b6b6813 100644
--- a/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml
+++ b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml
@@ -35,6 +35,9 @@ properties:
   vcc-supply:
     description: A 1.8V power supply (see regulator/regulator.yaml).
 
+  burst-mode-disabled:
+    description: Set Video Mode in Non-Burst Mode
+
   ports:
     $ref: /schemas/graph.yaml#/properties/ports
 
-- 
2.34.1
Re: [PATCH] dt-bindings: display: bridge: ti,sn65dsi83: add burst-mode-disabled
Posted by Rob Herring (Arm) 1 year, 7 months ago
On Mon, 08 Jul 2024 17:18:56 +0200, stefano.radaelli21@gmail.com wrote:
> From: Stefano Radaelli <stefano.radaelli21@gmail.com>
> 
> It allows to disable Burst video mode
> 
> Co-developed-by: Noah J. Rosa <noahj.rosa@gmail.com>
> Signed-off-by: Noah J. Rosa <noahj.rosa@gmail.com>
> Signed-off-by: Stefano Radaelli <stefano.radaelli21@gmail.com>
> ---
>  .../devicetree/bindings/display/bridge/ti,sn65dsi83.yaml       | 3 +++
>  1 file changed, 3 insertions(+)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml: burst-mode-disabled: missing type definition

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240708151857.40538-1-stefano.radaelli21@gmail.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
Re: [PATCH] dt-bindings: display: bridge: ti,sn65dsi83: add burst-mode-disabled
Posted by Marek Vasut 1 year, 7 months ago
On 7/8/24 5:18 PM, stefano.radaelli21@gmail.com wrote:
> From: Stefano Radaelli <stefano.radaelli21@gmail.com>
> 
> It allows to disable Burst video mode

Why would you want to disable burst mode ? This is the energy efficient 
and recommended mode, why disable it ? Details please ?
Re: [PATCH] dt-bindings: display: bridge: ti,sn65dsi83: add burst-mode-disabled
Posted by Krzysztof Kozlowski 1 year, 7 months ago
On 08/07/2024 17:18, stefano.radaelli21@gmail.com wrote:
> From: Stefano Radaelli <stefano.radaelli21@gmail.com>
> 
> It allows to disable Burst video mode
> 
> Co-developed-by: Noah J. Rosa <noahj.rosa@gmail.com>
> Signed-off-by: Noah J. Rosa <noahj.rosa@gmail.com>
> Signed-off-by: Stefano Radaelli <stefano.radaelli21@gmail.com>
> ---
>  .../devicetree/bindings/display/bridge/ti,sn65dsi83.yaml       | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml
> index 48a97bb3e2e0..eb9c8b6b6813 100644
> --- a/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml
> +++ b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml
> @@ -35,6 +35,9 @@ properties:
>    vcc-supply:
>      description: A 1.8V power supply (see regulator/regulator.yaml).
>  
> +  burst-mode-disabled:

You described the desired Linux feature or behavior, not the actual
hardware. The bindings are about the latter, so instead you need to
rephrase the property and its description to match actual hardware
capabilities/features/configuration etc.

Also: missing type, vendor prefix and never tested.

It does not look like you tested the bindings, at least after quick
look. Please run `make dt_binding_check` (see
Documentation/devicetree/bindings/writing-schema.rst for instructions).
Maybe you need to update your dtschema and yamllint.

Best regards,
Krzysztof