1. Patchew
  2. linux
  3. [PATCH v15 00/10] Add support for Core Power Reduction v3, v4 and Hardened
  4. View patch

[PATCH v15 01/10] MAINTAINERS: Include new Qualcomm CPR drivers in the file list

Konrad Dybcio posted 10 patches 1 year, 2 months ago
[PATCH v15 01/10] MAINTAINERS: Include new Qualcomm CPR drivers in the file list
Posted by Konrad Dybcio 1 year, 2 months ago 
Expand the Qualcomm Core Power Reduction section to include the files
concerning CPR3+ support.

Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
 MAINTAINERS | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index dcb37b635f2c..f3e013a52c16 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -18687,14 +18687,15 @@ F:	Documentation/accel/qaic/
 F:	drivers/accel/qaic/
 F:	include/uapi/drm/qaic_accel.h
 
-QUALCOMM CORE POWER REDUCTION (CPR) AVS DRIVER
+QUALCOMM CORE POWER REDUCTION (CPR) AVS DRIVERS
 M:	Bjorn Andersson <andersson@kernel.org>
 M:	Konrad Dybcio <konrad.dybcio@linaro.org>
 L:	linux-pm@vger.kernel.org
 L:	linux-arm-msm@vger.kernel.org
 S:	Maintained
 F:	Documentation/devicetree/bindings/power/avs/qcom,cpr.yaml
-F:	drivers/pmdomain/qcom/cpr.c
+F:	Documentation/devicetree/bindings/soc/qcom/qcom,cpr3.yaml
+F:	drivers/pmdomain/qcom/cpr*.c
 
 QUALCOMM CPUFREQ DRIVER MSM8996/APQ8096
 M:	Ilia Lin <ilia.lin@kernel.org>

-- 
2.45.2
Re: [PATCH v15 01/10] MAINTAINERS: Include new Qualcomm CPR drivers in the file list
Posted by Krzysztof Kozlowski 1 year, 2 months ago 
On 08/07/2024 14:22, Konrad Dybcio wrote:
> Expand the Qualcomm Core Power Reduction section to include the files
> concerning CPR3+ support.
> 
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> ---
>  MAINTAINERS | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index dcb37b635f2c..f3e013a52c16 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -18687,14 +18687,15 @@ F:	Documentation/accel/qaic/
>  F:	drivers/accel/qaic/
>  F:	include/uapi/drm/qaic_accel.h
>  
> -QUALCOMM CORE POWER REDUCTION (CPR) AVS DRIVER
> +QUALCOMM CORE POWER REDUCTION (CPR) AVS DRIVERS
>  M:	Bjorn Andersson <andersson@kernel.org>
>  M:	Konrad Dybcio <konrad.dybcio@linaro.org>
>  L:	linux-pm@vger.kernel.org
>  L:	linux-arm-msm@vger.kernel.org
>  S:	Maintained
>  F:	Documentation/devicetree/bindings/power/avs/qcom,cpr.yaml
> -F:	drivers/pmdomain/qcom/cpr.c
> +F:	Documentation/devicetree/bindings/soc/qcom/qcom,cpr3.yaml

Maybe combine these two into:
Documentation/devicetree/bindings/power/avs/qcom,cpr*

Best regards,
Krzysztof
Re: [PATCH v15 01/10] MAINTAINERS: Include new Qualcomm CPR drivers in the file list
Posted by Konrad Dybcio 1 year, 2 months ago 
On 9.07.2024 11:04 AM, Krzysztof Kozlowski wrote:
> On 08/07/2024 14:22, Konrad Dybcio wrote:
>> Expand the Qualcomm Core Power Reduction section to include the files
>> concerning CPR3+ support.
>>
>> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
>> ---
>>  MAINTAINERS | 5 +++--
>>  1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index dcb37b635f2c..f3e013a52c16 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -18687,14 +18687,15 @@ F:	Documentation/accel/qaic/
>>  F:	drivers/accel/qaic/
>>  F:	include/uapi/drm/qaic_accel.h
>>  
>> -QUALCOMM CORE POWER REDUCTION (CPR) AVS DRIVER
>> +QUALCOMM CORE POWER REDUCTION (CPR) AVS DRIVERS
>>  M:	Bjorn Andersson <andersson@kernel.org>
>>  M:	Konrad Dybcio <konrad.dybcio@linaro.org>
>>  L:	linux-pm@vger.kernel.org
>>  L:	linux-arm-msm@vger.kernel.org
>>  S:	Maintained
>>  F:	Documentation/devicetree/bindings/power/avs/qcom,cpr.yaml
>> -F:	drivers/pmdomain/qcom/cpr.c
>> +F:	Documentation/devicetree/bindings/soc/qcom/qcom,cpr3.yaml
> 
> Maybe combine these two into:
> Documentation/devicetree/bindings/power/avs/qcom,cpr*

I think avs was proposed to be a subsystem/driver directory at some point
and (adaptive voltage source? something like that) and this is the only file
in that directory in bindings..

Should we continue with this "class" of devices, or should I move qcom,cpr.yaml
to soc?

Konrad
Re: [PATCH v15 01/10] MAINTAINERS: Include new Qualcomm CPR drivers in the file list
Posted by Krzysztof Kozlowski 1 year, 2 months ago 
On 09/07/2024 11:49, Konrad Dybcio wrote:
> On 9.07.2024 11:04 AM, Krzysztof Kozlowski wrote:
>> On 08/07/2024 14:22, Konrad Dybcio wrote:
>>> Expand the Qualcomm Core Power Reduction section to include the files
>>> concerning CPR3+ support.
>>>
>>> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
>>> ---
>>>  MAINTAINERS | 5 +++--
>>>  1 file changed, 3 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/MAINTAINERS b/MAINTAINERS
>>> index dcb37b635f2c..f3e013a52c16 100644
>>> --- a/MAINTAINERS
>>> +++ b/MAINTAINERS
>>> @@ -18687,14 +18687,15 @@ F:	Documentation/accel/qaic/
>>>  F:	drivers/accel/qaic/
>>>  F:	include/uapi/drm/qaic_accel.h
>>>  
>>> -QUALCOMM CORE POWER REDUCTION (CPR) AVS DRIVER
>>> +QUALCOMM CORE POWER REDUCTION (CPR) AVS DRIVERS
>>>  M:	Bjorn Andersson <andersson@kernel.org>
>>>  M:	Konrad Dybcio <konrad.dybcio@linaro.org>
>>>  L:	linux-pm@vger.kernel.org
>>>  L:	linux-arm-msm@vger.kernel.org
>>>  S:	Maintained
>>>  F:	Documentation/devicetree/bindings/power/avs/qcom,cpr.yaml
>>> -F:	drivers/pmdomain/qcom/cpr.c
>>> +F:	Documentation/devicetree/bindings/soc/qcom/qcom,cpr3.yaml
>>
>> Maybe combine these two into:
>> Documentation/devicetree/bindings/power/avs/qcom,cpr*
> 
> I think avs was proposed to be a subsystem/driver directory at some point
> and (adaptive voltage source? something like that) and this is the only file
> in that directory in bindings..
> 
> Should we continue with this "class" of devices, or should I move qcom,cpr.yaml
> to soc?

Rather cpr3 should be moved to avs or some other power directory. "soc"
is fallback, junkyard for things without clear domain.


Best regards,
Krzysztof
Re: [PATCH v15 01/10] MAINTAINERS: Include new Qualcomm CPR drivers in the file list
Posted by Ulf Hansson 1 year, 1 month ago 
On Tue, 9 Jul 2024 at 16:42, Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> On 09/07/2024 11:49, Konrad Dybcio wrote:
> > On 9.07.2024 11:04 AM, Krzysztof Kozlowski wrote:
> >> On 08/07/2024 14:22, Konrad Dybcio wrote:
> >>> Expand the Qualcomm Core Power Reduction section to include the files
> >>> concerning CPR3+ support.
> >>>
> >>> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> >>> ---
> >>>  MAINTAINERS | 5 +++--
> >>>  1 file changed, 3 insertions(+), 2 deletions(-)
> >>>
> >>> diff --git a/MAINTAINERS b/MAINTAINERS
> >>> index dcb37b635f2c..f3e013a52c16 100644
> >>> --- a/MAINTAINERS
> >>> +++ b/MAINTAINERS
> >>> @@ -18687,14 +18687,15 @@ F:        Documentation/accel/qaic/
> >>>  F: drivers/accel/qaic/
> >>>  F: include/uapi/drm/qaic_accel.h
> >>>
> >>> -QUALCOMM CORE POWER REDUCTION (CPR) AVS DRIVER
> >>> +QUALCOMM CORE POWER REDUCTION (CPR) AVS DRIVERS
> >>>  M: Bjorn Andersson <andersson@kernel.org>
> >>>  M: Konrad Dybcio <konrad.dybcio@linaro.org>
> >>>  L: linux-pm@vger.kernel.org
> >>>  L: linux-arm-msm@vger.kernel.org
> >>>  S: Maintained
> >>>  F: Documentation/devicetree/bindings/power/avs/qcom,cpr.yaml
> >>> -F: drivers/pmdomain/qcom/cpr.c
> >>> +F: Documentation/devicetree/bindings/soc/qcom/qcom,cpr3.yaml
> >>
> >> Maybe combine these two into:
> >> Documentation/devicetree/bindings/power/avs/qcom,cpr*
> >
> > I think avs was proposed to be a subsystem/driver directory at some point
> > and (adaptive voltage source? something like that) and this is the only file
> > in that directory in bindings..
> >
> > Should we continue with this "class" of devices, or should I move qcom,cpr.yaml
> > to soc?
>
> Rather cpr3 should be moved to avs or some other power directory. "soc"
> is fallback, junkyard for things without clear domain.

In my opinion, I would suggest dropping the
"Documentation/devicetree/bindings/power/avs/" directory. We already
have similar bindings sprinkled across various directories, see below.
One less seems better to me.

Documentation/devicetree/bindings/arm/*
Documentation/devicetree/bindings/firmware/*
Documentation/devicetree/bindings/power/*
Documentation/devicetree/bindings/soc/*

Kind regards
Uffe
Re: [PATCH v15 01/10] MAINTAINERS: Include new Qualcomm CPR drivers in the file list
Posted by Konrad Dybcio 1 year, 1 month ago 
On 15.07.2024 1:34 PM, Ulf Hansson wrote:
> On Tue, 9 Jul 2024 at 16:42, Krzysztof Kozlowski <krzk@kernel.org> wrote:
>>
>> On 09/07/2024 11:49, Konrad Dybcio wrote:
>>> On 9.07.2024 11:04 AM, Krzysztof Kozlowski wrote:
>>>> On 08/07/2024 14:22, Konrad Dybcio wrote:
>>>>> Expand the Qualcomm Core Power Reduction section to include the files
>>>>> concerning CPR3+ support.
>>>>>
>>>>> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
>>>>> ---
>>>>>  MAINTAINERS | 5 +++--
>>>>>  1 file changed, 3 insertions(+), 2 deletions(-)
>>>>>
>>>>> diff --git a/MAINTAINERS b/MAINTAINERS
>>>>> index dcb37b635f2c..f3e013a52c16 100644
>>>>> --- a/MAINTAINERS
>>>>> +++ b/MAINTAINERS
>>>>> @@ -18687,14 +18687,15 @@ F:        Documentation/accel/qaic/
>>>>>  F: drivers/accel/qaic/
>>>>>  F: include/uapi/drm/qaic_accel.h
>>>>>
>>>>> -QUALCOMM CORE POWER REDUCTION (CPR) AVS DRIVER
>>>>> +QUALCOMM CORE POWER REDUCTION (CPR) AVS DRIVERS
>>>>>  M: Bjorn Andersson <andersson@kernel.org>
>>>>>  M: Konrad Dybcio <konrad.dybcio@linaro.org>
>>>>>  L: linux-pm@vger.kernel.org
>>>>>  L: linux-arm-msm@vger.kernel.org
>>>>>  S: Maintained
>>>>>  F: Documentation/devicetree/bindings/power/avs/qcom,cpr.yaml
>>>>> -F: drivers/pmdomain/qcom/cpr.c
>>>>> +F: Documentation/devicetree/bindings/soc/qcom/qcom,cpr3.yaml
>>>>
>>>> Maybe combine these two into:
>>>> Documentation/devicetree/bindings/power/avs/qcom,cpr*
>>>
>>> I think avs was proposed to be a subsystem/driver directory at some point
>>> and (adaptive voltage source? something like that) and this is the only file
>>> in that directory in bindings..
>>>
>>> Should we continue with this "class" of devices, or should I move qcom,cpr.yaml
>>> to soc?
>>
>> Rather cpr3 should be moved to avs or some other power directory. "soc"
>> is fallback, junkyard for things without clear domain.
> 
> In my opinion, I would suggest dropping the
> "Documentation/devicetree/bindings/power/avs/" directory. We already
> have similar bindings sprinkled across various directories, see below.
> One less seems better to me.
> 
> Documentation/devicetree/bindings/arm/*
> Documentation/devicetree/bindings/firmware/*
> Documentation/devicetree/bindings/power/*
> Documentation/devicetree/bindings/soc/*

So, should it go to bindings/power? Or should we get a new
bindings/pmdomain dir?

Konrad
Re: [PATCH v15 01/10] MAINTAINERS: Include new Qualcomm CPR drivers in the file list
Posted by Ulf Hansson 1 year, 1 month ago 
On Tue, 16 Jul 2024 at 13:58, Konrad Dybcio <konrad.dybcio@linaro.org> wrote:
>
> On 15.07.2024 1:34 PM, Ulf Hansson wrote:
> > On Tue, 9 Jul 2024 at 16:42, Krzysztof Kozlowski <krzk@kernel.org> wrote:
> >>
> >> On 09/07/2024 11:49, Konrad Dybcio wrote:
> >>> On 9.07.2024 11:04 AM, Krzysztof Kozlowski wrote:
> >>>> On 08/07/2024 14:22, Konrad Dybcio wrote:
> >>>>> Expand the Qualcomm Core Power Reduction section to include the files
> >>>>> concerning CPR3+ support.
> >>>>>
> >>>>> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> >>>>> ---
> >>>>>  MAINTAINERS | 5 +++--
> >>>>>  1 file changed, 3 insertions(+), 2 deletions(-)
> >>>>>
> >>>>> diff --git a/MAINTAINERS b/MAINTAINERS
> >>>>> index dcb37b635f2c..f3e013a52c16 100644
> >>>>> --- a/MAINTAINERS
> >>>>> +++ b/MAINTAINERS
> >>>>> @@ -18687,14 +18687,15 @@ F:        Documentation/accel/qaic/
> >>>>>  F: drivers/accel/qaic/
> >>>>>  F: include/uapi/drm/qaic_accel.h
> >>>>>
> >>>>> -QUALCOMM CORE POWER REDUCTION (CPR) AVS DRIVER
> >>>>> +QUALCOMM CORE POWER REDUCTION (CPR) AVS DRIVERS
> >>>>>  M: Bjorn Andersson <andersson@kernel.org>
> >>>>>  M: Konrad Dybcio <konrad.dybcio@linaro.org>
> >>>>>  L: linux-pm@vger.kernel.org
> >>>>>  L: linux-arm-msm@vger.kernel.org
> >>>>>  S: Maintained
> >>>>>  F: Documentation/devicetree/bindings/power/avs/qcom,cpr.yaml
> >>>>> -F: drivers/pmdomain/qcom/cpr.c
> >>>>> +F: Documentation/devicetree/bindings/soc/qcom/qcom,cpr3.yaml
> >>>>
> >>>> Maybe combine these two into:
> >>>> Documentation/devicetree/bindings/power/avs/qcom,cpr*
> >>>
> >>> I think avs was proposed to be a subsystem/driver directory at some point
> >>> and (adaptive voltage source? something like that) and this is the only file
> >>> in that directory in bindings..
> >>>
> >>> Should we continue with this "class" of devices, or should I move qcom,cpr.yaml
> >>> to soc?
> >>
> >> Rather cpr3 should be moved to avs or some other power directory. "soc"
> >> is fallback, junkyard for things without clear domain.
> >
> > In my opinion, I would suggest dropping the
> > "Documentation/devicetree/bindings/power/avs/" directory. We already
> > have similar bindings sprinkled across various directories, see below.
> > One less seems better to me.
> >
> > Documentation/devicetree/bindings/arm/*
> > Documentation/devicetree/bindings/firmware/*
> > Documentation/devicetree/bindings/power/*
> > Documentation/devicetree/bindings/soc/*
>
> So, should it go to bindings/power? Or should we get a new
> bindings/pmdomain dir?

No strong opinions from my side. Unless Krzysztof has better
suggestions, using bindings/power/* works for me.

Kind regards
Uffe
Re: [PATCH v15 01/10] MAINTAINERS: Include new Qualcomm CPR drivers in the file list
Posted by Krzysztof Kozlowski 1 year, 1 month ago 
On 16/07/2024 16:47, Ulf Hansson wrote:
>>>>
>>>> Rather cpr3 should be moved to avs or some other power directory. "soc"
>>>> is fallback, junkyard for things without clear domain.
>>>
>>> In my opinion, I would suggest dropping the
>>> "Documentation/devicetree/bindings/power/avs/" directory. We already
>>> have similar bindings sprinkled across various directories, see below.
>>> One less seems better to me.
>>>
>>> Documentation/devicetree/bindings/arm/*
>>> Documentation/devicetree/bindings/firmware/*
>>> Documentation/devicetree/bindings/power/*
>>> Documentation/devicetree/bindings/soc/*
>>
>> So, should it go to bindings/power? Or should we get a new
>> bindings/pmdomain dir?
> 
> No strong opinions from my side. Unless Krzysztof has better
> suggestions, using bindings/power/* works for me.

Ack

Best regards,
Krzysztof

Patchew 2.1-devel-b67e4c2

© 2016 - 2025 Red Hat, Inc.