[PATCH 1/2] dt-bindings: arm: bcm2835: Specify /system/linux,revision property

Jonathan Neuschäfer posted 2 patches 1 year, 5 months ago
[PATCH 1/2] dt-bindings: arm: bcm2835: Specify /system/linux,revision property
Posted by Jonathan Neuschäfer 1 year, 5 months ago
The Raspberry Pi bootloader provides a revision code[0] in the
devicetree, at /system/linux,revision. This patch adds
/system/linux,revision to the schema to allow it to be used in
mainline Linux.

[0]: https://www.raspberrypi.com/documentation/computers/raspberry-pi.html#new-style-revision-codes
Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
---
 Documentation/devicetree/bindings/arm/bcm/bcm2835.yaml | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/Documentation/devicetree/bindings/arm/bcm/bcm2835.yaml b/Documentation/devicetree/bindings/arm/bcm/bcm2835.yaml
index 162a39dab21823..c6abf818b5ea57 100644
--- a/Documentation/devicetree/bindings/arm/bcm/bcm2835.yaml
+++ b/Documentation/devicetree/bindings/arm/bcm/bcm2835.yaml
@@ -54,6 +54,18 @@ properties:
               - raspberrypi,model-zero-2-w
           - const: brcm,bcm2837

+  system:
+    type: object
+    additionalProperties: true
+    properties:
+
+      linux,revision:
+        $ref: /schemas/types.yaml#/definitions/string-array
+        description:
+          The "system revision" number, as determined by the bootloader.
+          https://www.raspberrypi.com/documentation/computers/raspberry-pi.html#new-style-revision-codes
+
+
 additionalProperties: true

 ...

--
2.43.0
Re: [PATCH 1/2] dt-bindings: arm: bcm2835: Specify /system/linux,revision property
Posted by Krzysztof Kozlowski 1 year, 5 months ago
On 08/07/2024 01:08, Jonathan Neuschäfer wrote:
> The Raspberry Pi bootloader provides a revision code[0] in the
> devicetree, at /system/linux,revision. This patch adds
> /system/linux,revision to the schema to allow it to be used in
> mainline Linux.

Sorry, no, we do not document stuff for various out of tree things.
Otherwise we would have to accept hundreds of ridiculous, vendor properties.

Fix your bootloader or make it upstream.

Best regards,
Krzysztof

Re: [PATCH 1/2] dt-bindings: arm: bcm2835: Specify /system/linux,revision property
Posted by J. Neuschäfer 1 year, 5 months ago
On Mon, Jul 08, 2024 at 04:13:10PM +0200, Krzysztof Kozlowski wrote:
> On 08/07/2024 01:08, Jonathan Neuschäfer wrote:
> > The Raspberry Pi bootloader provides a revision code[0] in the
> > devicetree, at /system/linux,revision. This patch adds
> > /system/linux,revision to the schema to allow it to be used in
> > mainline Linux.
>
> Sorry, no, we do not document stuff for various out of tree things.
> Otherwise we would have to accept hundreds of ridiculous, vendor properties.

Fair enough.

> Fix your bootloader or make it upstream.

There is no open source upstream for this bootloader. It is (sadly)
Broadcom's own proprietary code.

Not sure what fixing it would entail.


Jonathan
Re: [PATCH 1/2] dt-bindings: arm: bcm2835: Specify /system/linux,revision property
Posted by Florian Fainelli 1 year, 2 months ago
On 7/9/24 12:52, J. Neuschäfer wrote:
> On Mon, Jul 08, 2024 at 04:13:10PM +0200, Krzysztof Kozlowski wrote:
>> On 08/07/2024 01:08, Jonathan Neuschäfer wrote:
>>> The Raspberry Pi bootloader provides a revision code[0] in the
>>> devicetree, at /system/linux,revision. This patch adds
>>> /system/linux,revision to the schema to allow it to be used in
>>> mainline Linux.
>>
>> Sorry, no, we do not document stuff for various out of tree things.
>> Otherwise we would have to accept hundreds of ridiculous, vendor properties.
> 
> Fair enough.
> 
>> Fix your bootloader or make it upstream.
> 
> There is no open source upstream for this bootloader. It is (sadly)
> Broadcom's own proprietary code.

We have plenty of proprietary code all over the place, but that one is 
not ours, it's Raspberry Pi's own, FWIW.
-- 
Florian