1. Patchew
  2. linux
  3. View series

[PATCH] arm64: dts: qcom: sa8775p: Add interconnects for ethernet

Sagar Cheluvegowda posted 1 patch 1 year, 5 months ago
There is a newer version of this series
arch/arm64/boot/dts/qcom/sa8775p.dtsi | 12 ++++++++++++
1 file changed, 12 insertions(+)
[PATCH] arm64: dts: qcom: sa8775p: Add interconnects for ethernet
Posted by Sagar Cheluvegowda 1 year, 5 months ago 
Define interconnect properties for ethernet hardware.

Suggested-by: Andrew Halaney <ahalaney@redhat.com>
Signed-off-by: Sagar Cheluvegowda <quic_scheluve@quicinc.com>
---
Adding interconnect dtsi properties within ethernet node of SA8775P,
this patch is adding support for the interconnect properties defined
in the series ->  
https://lore.kernel.org/all/20240703-icc_bw_voting_from_ethqos-v3-0-8f9148ac60a3@quicinc.com/
---
 arch/arm64/boot/dts/qcom/sa8775p.dtsi | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
index 23f1b2e5e624..7ebf03953b7b 100644
--- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi
+++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
@@ -3464,6 +3464,12 @@ ethernet1: ethernet@23000000 {
 				      "ptp_ref",
 				      "phyaux";
 
+			interconnect-names = "mac-mem", "cpu-mac";
+			interconnects = <&aggre1_noc MASTER_EMAC_1 QCOM_ICC_TAG_ALWAYS
+					 &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>,
+					<&gem_noc MASTER_APPSS_PROC QCOM_ICC_TAG_ALWAYS
+					 &config_noc SLAVE_EMAC1_CFG QCOM_ICC_TAG_ALWAYS>;
+
 			power-domains = <&gcc EMAC1_GDSC>;
 
 			phys = <&serdes1>;
@@ -3499,6 +3505,12 @@ ethernet0: ethernet@23040000 {
 				      "ptp_ref",
 				      "phyaux";
 
+			interconnect-names = "mac-mem", "cpu-mac";
+			interconnects = <&aggre1_noc MASTER_EMAC QCOM_ICC_TAG_ALWAYS
+					 &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>,
+					<&gem_noc MASTER_APPSS_PROC QCOM_ICC_TAG_ALWAYS
+					 &config_noc SLAVE_EMAC_CFG QCOM_ICC_TAG_ALWAYS>;
+
 			power-domains = <&gcc EMAC0_GDSC>;
 
 			phys = <&serdes0>;

---
base-commit: 0b58e108042b0ed28a71cd7edf5175999955b233
change-id: 20240703-icc_bw_voting_emac_dtsi-2a09f9a18174

Best regards,
-- 
Sagar Cheluvegowda <quic_scheluve@quicinc.com>
Re: [PATCH] arm64: dts: qcom: sa8775p: Add interconnects for ethernet
Posted by Konrad Dybcio 1 year, 5 months ago 
On 8.07.2024 11:14 PM, Sagar Cheluvegowda wrote:
> Define interconnect properties for ethernet hardware.
> 
> Suggested-by: Andrew Halaney <ahalaney@redhat.com>
> Signed-off-by: Sagar Cheluvegowda <quic_scheluve@quicinc.com>
> ---
> Adding interconnect dtsi properties within ethernet node of SA8775P,
> this patch is adding support for the interconnect properties defined
> in the series ->  
> https://lore.kernel.org/all/20240703-icc_bw_voting_from_ethqos-v3-0-8f9148ac60a3@quicinc.com/
> ---
>  arch/arm64/boot/dts/qcom/sa8775p.dtsi | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
> index 23f1b2e5e624..7ebf03953b7b 100644
> --- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
> @@ -3464,6 +3464,12 @@ ethernet1: ethernet@23000000 {
>  				      "ptp_ref",
>  				      "phyaux";
>  
> +			interconnect-names = "mac-mem", "cpu-mac";
> +			interconnects = <&aggre1_noc MASTER_EMAC_1 QCOM_ICC_TAG_ALWAYS
> +					 &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>,
> +					<&gem_noc MASTER_APPSS_PROC QCOM_ICC_TAG_ALWAYS
> +					 &config_noc SLAVE_EMAC1_CFG QCOM_ICC_TAG_ALWAYS>;

property
property-names

please

otherwise lgtm

Konrad
Re: [PATCH] arm64: dts: qcom: sa8775p: Add interconnects for ethernet
Posted by Sagar Cheluvegowda 1 year, 5 months ago 

On 7/9/2024 5:19 AM, Konrad Dybcio wrote:
> On 8.07.2024 11:14 PM, Sagar Cheluvegowda wrote:
>> Define interconnect properties for ethernet hardware.
>>
>> Suggested-by: Andrew Halaney <ahalaney@redhat.com>
>> Signed-off-by: Sagar Cheluvegowda <quic_scheluve@quicinc.com>
>> ---
>> Adding interconnect dtsi properties within ethernet node of SA8775P,
>> this patch is adding support for the interconnect properties defined
>> in the series ->  
>> https://lore.kernel.org/all/20240703-icc_bw_voting_from_ethqos-v3-0-8f9148ac60a3@quicinc.com/
>> ---
>>  arch/arm64/boot/dts/qcom/sa8775p.dtsi | 12 ++++++++++++
>>  1 file changed, 12 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
>> index 23f1b2e5e624..7ebf03953b7b 100644
>> --- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
>> @@ -3464,6 +3464,12 @@ ethernet1: ethernet@23000000 {
>>  				      "ptp_ref",
>>  				      "phyaux";
>>  
>> +			interconnect-names = "mac-mem", "cpu-mac";
>> +			interconnects = <&aggre1_noc MASTER_EMAC_1 QCOM_ICC_TAG_ALWAYS
>> +					 &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>,
>> +					<&gem_noc MASTER_APPSS_PROC QCOM_ICC_TAG_ALWAYS
>> +					 &config_noc SLAVE_EMAC1_CFG QCOM_ICC_TAG_ALWAYS>;
> 
> property
> property-names
> 
> please
> 
> otherwise lgtm
> 
> Konrad

Thanks Konrad Dybcio for reviewing, let me post a new patch re-ordering the properties.
Re: [PATCH] arm64: dts: qcom: sa8775p: Add interconnects for ethernet
Posted by Andrew Lunn 1 year, 5 months ago 
On Mon, Jul 08, 2024 at 02:14:47PM -0700, Sagar Cheluvegowda wrote:
> Define interconnect properties for ethernet hardware.
> 
> Suggested-by: Andrew Halaney <ahalaney@redhat.com>
> Signed-off-by: Sagar Cheluvegowda <quic_scheluve@quicinc.com>
> ---
> Adding interconnect dtsi properties within ethernet node of SA8775P,
> this patch is adding support for the interconnect properties defined
> in the series ->  
> https://lore.kernel.org/all/20240703-icc_bw_voting_from_ethqos-v3-0-8f9148ac60a3@quicinc.com/

Thanks for adding a user.

       Andrew

Patchew 2.1-devel-b67e4c2

© 2016 - 2025 Red Hat, Inc.