ARM: dts: qcom: apq8960: correct memory base

[PATCH] ARM: dts: qcom: apq8960: correct memory base

Posted by David Heidelberg 1 year, 7 months ago

Bootloader will provide the information anyway to the kernel.

Ref: https://github.com/msm8916-mainline/lk2nd/blob/main/target/msm8960/rules.mk

Signed-off-by: David Heidelberg <david@ixit.cz>
---
 arch/arm/boot/dts/qcom/qcom-msm8960.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git ./arch/arm/boot/dts/qcom/qcom-msm8960.dtsi ./arch/arm/boot/dts/qcom/qcom-msm8960.dtsi
index a9c6d2dbb460..ebc43c5c6e5f 100644
--- ./arch/arm/boot/dts/qcom/qcom-msm8960.dtsi
+++ ./arch/arm/boot/dts/qcom/qcom-msm8960.dtsi
@@ -47,9 +47,9 @@ L2: l2-cache {
 		};
 	};
 
-	memory {
+	memory@80000000 {
 		device_type = "memory";
-		reg = <0x0 0x0>;
+		reg = <0x80000000 0>;
 	};
 
 	cpu-pmu {
-- 
2.45.2

Re: [PATCH] ARM: dts: qcom: apq8960: correct memory base

Posted by Bjorn Andersson 1 year, 7 months ago

On Sat, Jul 06, 2024 at 12:34:07PM GMT, David Heidelberg wrote:
> Bootloader will provide the information anyway to the kernel.

How about we describe an actual problem here?

Perhaps this is the problem you're solving?:

"""
DeviceTree validation requires a unit address on the memory node, adjust
the base to match [Ref] and use this as unit address.

The bootloader will update the information with the actual values during
boot.
"""

I'd also prefer s/apq8960/msm8960/ in $subject, is there a reason why
you did choose apq8960?

Regards,
Bjorn

> 
> Ref: https://github.com/msm8916-mainline/lk2nd/blob/main/target/msm8960/rules.mk
> 
> Signed-off-by: David Heidelberg <david@ixit.cz>
> ---
>  arch/arm/boot/dts/qcom/qcom-msm8960.dtsi | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git ./arch/arm/boot/dts/qcom/qcom-msm8960.dtsi ./arch/arm/boot/dts/qcom/qcom-msm8960.dtsi
> index a9c6d2dbb460..ebc43c5c6e5f 100644
> --- ./arch/arm/boot/dts/qcom/qcom-msm8960.dtsi
> +++ ./arch/arm/boot/dts/qcom/qcom-msm8960.dtsi
> @@ -47,9 +47,9 @@ L2: l2-cache {
>  		};
>  	};
>  
> -	memory {
> +	memory@80000000 {
>  		device_type = "memory";
> -		reg = <0x0 0x0>;
> +		reg = <0x80000000 0>;
>  	};
>  
>  	cpu-pmu {
> -- 
> 2.45.2
>

Re: [PATCH] ARM: dts: qcom: apq8960: correct memory base

Posted by David Heidelberg 1 year, 7 months ago

Hello Bjorn,

the apq8960 is just mental typo due to dealing with apq8064 code at same 
time. I sent properly named patch [1] with your description and Dmitry's 
R-b.

Thank you
David

[1] `ARM: dts: qcom: msm8960: correct memory base`

On 06/07/2024 13:05, Bjorn Andersson wrote:
> On Sat, Jul 06, 2024 at 12:34:07PM GMT, David Heidelberg wrote:
>> Bootloader will provide the information anyway to the kernel.
> How about we describe an actual problem here?
>
> Perhaps this is the problem you're solving?:
>
> """
> DeviceTree validation requires a unit address on the memory node, adjust
> the base to match [Ref] and use this as unit address.
>
> The bootloader will update the information with the actual values during
> boot.
> """
>
> I'd also prefer s/apq8960/msm8960/ in $subject, is there a reason why
> you did choose apq8960?
>
> Regards,
> Bjorn
>
>> Ref: https://github.com/msm8916-mainline/lk2nd/blob/main/target/msm8960/rules.mk
>>
>> Signed-off-by: David Heidelberg <david@ixit.cz>
>> ---
>>   arch/arm/boot/dts/qcom/qcom-msm8960.dtsi | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git ./arch/arm/boot/dts/qcom/qcom-msm8960.dtsi ./arch/arm/boot/dts/qcom/qcom-msm8960.dtsi
>> index a9c6d2dbb460..ebc43c5c6e5f 100644
>> --- ./arch/arm/boot/dts/qcom/qcom-msm8960.dtsi
>> +++ ./arch/arm/boot/dts/qcom/qcom-msm8960.dtsi
>> @@ -47,9 +47,9 @@ L2: l2-cache {
>>   		};
>>   	};
>>   
>> -	memory {
>> +	memory@80000000 {
>>   		device_type = "memory";
>> -		reg = <0x0 0x0>;
>> +		reg = <0x80000000 0>;
>>   	};
>>   
>>   	cpu-pmu {
>> -- 
>> 2.45.2
>>
-- 
David Heidelberg

Re: [PATCH] ARM: dts: qcom: apq8960: correct memory base

Posted by Dmitry Baryshkov 1 year, 7 months ago

On Sat, Jul 06, 2024 at 12:34:07PM GMT, David Heidelberg wrote:
> Bootloader will provide the information anyway to the kernel.
> 
> Ref: https://github.com/msm8916-mainline/lk2nd/blob/main/target/msm8960/rules.mk
> 
> Signed-off-by: David Heidelberg <david@ixit.cz>
> ---
>  arch/arm/boot/dts/qcom/qcom-msm8960.dtsi | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>


-- 
With best wishes
Dmitry