[PATCH 3/5] null_blk: Don't bother validating blocksize

John Garry posted 5 patches 1 year, 7 months ago
There is a newer version of this series
[PATCH 3/5] null_blk: Don't bother validating blocksize
Posted by John Garry 1 year, 7 months ago
The block queue limits validation does this for us now.

Signed-off-by: John Garry <john.g.garry@oracle.com>
---
 drivers/block/null_blk/main.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/block/null_blk/main.c b/drivers/block/null_blk/main.c
index 9d0f6da77601..2f0431e42c49 100644
--- a/drivers/block/null_blk/main.c
+++ b/drivers/block/null_blk/main.c
@@ -1831,9 +1831,6 @@ static int null_validate_conf(struct nullb_device *dev)
 		dev->queue_mode = NULL_Q_MQ;
 	}
 
-	if (blk_validate_block_size(dev->blocksize))
-		return -EINVAL;
-
 	if (dev->use_per_node_hctx) {
 		if (dev->submit_queues != nr_online_nodes)
 			dev->submit_queues = nr_online_nodes;
-- 
2.31.1
Re: [PATCH 3/5] null_blk: Don't bother validating blocksize
Posted by Christoph Hellwig 1 year, 7 months ago
Looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>