[PATCH 3/4] arm64: defconfig: Enable hci_uart for Amlogic Bluetooth

Yang Li via B4 Relay posted 4 patches 1 year, 7 months ago
There is a newer version of this series
[PATCH 3/4] arm64: defconfig: Enable hci_uart for Amlogic Bluetooth
Posted by Yang Li via B4 Relay 1 year, 7 months ago
From: Yang Li <yang.li@amlogic.com>

Enable the HCI protocol of Amlogitc Bluetooth.

Signed-off-by: Yang Li <yang.li@amlogic.com>
---
 arch/arm64/configs/defconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index 57a9abe78ee4..11c4b5c532ca 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -192,6 +192,7 @@ CONFIG_BT_HCIUART_LL=y
 CONFIG_BT_HCIUART_BCM=y
 CONFIG_BT_HCIUART_QCA=y
 CONFIG_BT_HCIUART_MRVL=y
+CONFIG_BT_HCIUART_AML=y
 CONFIG_BT_MRVL=m
 CONFIG_BT_MRVL_SDIO=m
 CONFIG_BT_QCOMSMD=m

-- 
2.42.0
Re: [PATCH 3/4] arm64: defconfig: Enable hci_uart for Amlogic Bluetooth
Posted by Krzysztof Kozlowski 1 year, 7 months ago
On 05/07/2024 13:20, Yang Li via B4 Relay wrote:
> From: Yang Li <yang.li@amlogic.com>
> 
> Enable the HCI protocol of Amlogitc Bluetooth.

Why? Commit msg MUST answer this.

Also, this is supposed to be module.

Best regards,
Krzysztof
Re: [PATCH 3/4] arm64: defconfig: Enable hci_uart for Amlogic Bluetooth
Posted by Yang Li 1 year, 7 months ago
On 2024/7/7 21:08, Krzysztof Kozlowski wrote:
> On 05/07/2024 13:20, Yang Li via B4 Relay wrote:
>> From: Yang Li <yang.li@amlogic.com>
>>
>> Enable the HCI protocol of Amlogitc Bluetooth.
> Why? Commit msg MUST answer this.
>
> Also, this is supposed to be module.

Yes, "hci_uart" is already set to module by "CONFIG_BT_HCIUART". 
"CONFIG_BT_HCIUART_AML" is the Bluetooth driver that specifically 
enables Amlogic support.


I will change the commit msg to:

     arm64: defconfig: enable Amlogic bluetooth relevant drivers as modules

     CONFIG_BT_HCIUART_AML is the Bluetooth driver that enables support 
for Amlogic chips, including W155S2, W265S1, W265P1, and W265S2.

>
> Best regards,
> Krzysztof
>
Re: [PATCH 3/4] arm64: defconfig: Enable hci_uart for Amlogic Bluetooth
Posted by Krzysztof Kozlowski 1 year, 7 months ago
On 11/07/2024 13:40, Yang Li wrote:
> 
>      arm64: defconfig: enable Amlogic bluetooth relevant drivers as modules
> 
>      CONFIG_BT_HCIUART_AML is the Bluetooth driver that enables support 
> for Amlogic chips, including W155S2, W265S1, W265P1, and W265S2.

This still does not answer why we would like to have it in defconfig,
e.g. which mainline board uses it or benefits from it.


Best regards,
Krzysztof

Re: [PATCH 3/4] arm64: defconfig: Enable hci_uart for Amlogic Bluetooth
Posted by Yang Li 1 year, 7 months ago
Hi,

On 2024/7/11 20:19, Krzysztof Kozlowski wrote:
> On 11/07/2024 13:40, Yang Li wrote:
>>       arm64: defconfig: enable Amlogic bluetooth relevant drivers as modules
>>
>>       CONFIG_BT_HCIUART_AML is the Bluetooth driver that enables support
>> for Amlogic chips, including W155S2, W265S1, W265P1, and W265S2.
> This still does not answer why we would like to have it in defconfig,
> e.g. which mainline board uses it or benefits from it.

Well, I understand.

I plan to submit this patch after the mainline board is ready for 
contributions.

Thanks!

>
> Best regards,
> Krzysztof
>