mfd: Constify read-only regmap structs

[PATCH v2 14/24] mfd: rohm-bd718x7: Constify struct regmap_irq_chip

Posted by Javier Carrasco 1 year, 7 months ago

`bd718xx_irq_chip` is not modified and can be declared as const to
move its data to a read-only section.

Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
---
 drivers/mfd/rohm-bd718x7.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mfd/rohm-bd718x7.c b/drivers/mfd/rohm-bd718x7.c
index 7755a4c073bf..25e494a93d48 100644
--- a/drivers/mfd/rohm-bd718x7.c
+++ b/drivers/mfd/rohm-bd718x7.c
@@ -60,7 +60,7 @@ static const struct regmap_irq bd718xx_irqs[] = {
 	REGMAP_IRQ_REG(BD718XX_INT_STBY_REQ, 0, BD718XX_INT_STBY_REQ_MASK),
 };
 
-static struct regmap_irq_chip bd718xx_irq_chip = {
+static const struct regmap_irq_chip bd718xx_irq_chip = {
 	.name = "bd718xx-irq",
 	.irqs = bd718xx_irqs,
 	.num_irqs = ARRAY_SIZE(bd718xx_irqs),

-- 
2.40.1

Re: [PATCH v2 14/24] mfd: rohm-bd718x7: Constify struct regmap_irq_chip

Posted by Matti Vaittinen 1 year, 7 months ago

On 7/4/24 20:23, Javier Carrasco wrote:
> `bd718xx_irq_chip` is not modified and can be declared as const to
> move its data to a read-only section.
> 
> Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>

Reviewed-by: Matti Vaittinen <mazziesaccount@gmail.com>

> ---
>   drivers/mfd/rohm-bd718x7.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mfd/rohm-bd718x7.c b/drivers/mfd/rohm-bd718x7.c
> index 7755a4c073bf..25e494a93d48 100644
> --- a/drivers/mfd/rohm-bd718x7.c
> +++ b/drivers/mfd/rohm-bd718x7.c
> @@ -60,7 +60,7 @@ static const struct regmap_irq bd718xx_irqs[] = {
>   	REGMAP_IRQ_REG(BD718XX_INT_STBY_REQ, 0, BD718XX_INT_STBY_REQ_MASK),
>   };
>   
> -static struct regmap_irq_chip bd718xx_irq_chip = {
> +static const struct regmap_irq_chip bd718xx_irq_chip = {
>   	.name = "bd718xx-irq",
>   	.irqs = bd718xx_irqs,
>   	.num_irqs = ARRAY_SIZE(bd718xx_irqs),
> 

-- 
Matti Vaittinen
Linux kernel developer at ROHM Semiconductors
Oulu Finland

~~ When things go utterly wrong vim users can always type :help! ~~