sched/smt: Fix error handling in sched_cpu_deactivate()

[PATCH 0/4] sched/smt: Fix error handling in sched_cpu_deactivate()

Posted by Yang Yingliang 1 year, 5 months ago

From: Yang Yingliang <yangyingliang@huawei.com>

sched_smt_present decrement and set_rq_offline() is called before
cpuset_cpu_inactive(), if cpuset_cpu_inactive() fails, these two
things need be rollback.

Yang Yingliang (4):
  sched/smt: Introduce sched_smt_present_inc/dec() helper
  sched/smt: fix unbalance sched_smt_present dec/inc
  sched/core: Introduce sched_set_rq_on/offline() helper
  sched/core: fix unbalance set_rq_online/offline() in
    sched_cpu_deactivate()

 kernel/sched/core.c | 68 +++++++++++++++++++++++++++++++--------------
 1 file changed, 47 insertions(+), 21 deletions(-)

-- 
2.25.1

Re: [PATCH 0/4] sched/smt: Fix error handling in sched_cpu_deactivate()

Posted by Peter Zijlstra 1 year, 5 months ago

On Wed, Jul 03, 2024 at 11:16:06AM +0800, Yang Yingliang wrote:
> From: Yang Yingliang <yangyingliang@huawei.com>
> 
> sched_smt_present decrement and set_rq_offline() is called before
> cpuset_cpu_inactive(), if cpuset_cpu_inactive() fails, these two
> things need be rollback.
> 
> Yang Yingliang (4):
>   sched/smt: Introduce sched_smt_present_inc/dec() helper
>   sched/smt: fix unbalance sched_smt_present dec/inc
>   sched/core: Introduce sched_set_rq_on/offline() helper
>   sched/core: fix unbalance set_rq_online/offline() in
>     sched_cpu_deactivate()
> 
>  kernel/sched/core.c | 68 +++++++++++++++++++++++++++++++--------------
>  1 file changed, 47 insertions(+), 21 deletions(-)

Thanks!