Hello,
On Wed, Jul 03, 2024 at 12:36:57PM +0200, Luca Ceresoli wrote:
> Simplify code using of_property_for_each_u32_new() as the two additional
> parameters in of_property_for_each_u32() are not used here.
>
> Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
> ---
> drivers/pwm/pwm-samsung.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/pwm/pwm-samsung.c b/drivers/pwm/pwm-samsung.c
> index efb60c9f0cb3..fef02a0b023e 100644
> --- a/drivers/pwm/pwm-samsung.c
> +++ b/drivers/pwm/pwm-samsung.c
> @@ -510,8 +510,6 @@ static int pwm_samsung_parse_dt(struct pwm_chip *chip)
> struct samsung_pwm_chip *our_chip = to_samsung_pwm_chip(chip);
> struct device_node *np = pwmchip_parent(chip)->of_node;
> const struct of_device_id *match;
> - struct property *prop;
> - const __be32 *cur;
> u32 val;
>
> match = of_match_node(samsung_pwm_matches, np);
> @@ -520,7 +518,7 @@ static int pwm_samsung_parse_dt(struct pwm_chip *chip)
>
> memcpy(&our_chip->variant, match->data, sizeof(our_chip->variant));
>
> - of_property_for_each_u32(np, "samsung,pwm-outputs", prop, cur, val) {
> + of_property_for_each_u32_new(np, "samsung,pwm-outputs", val) {
> if (val >= SAMSUNG_PWM_NUM) {
> dev_err(pwmchip_parent(chip),
> "%s: invalid channel index in samsung,pwm-outputs property\n",
>
Acked-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
Feel free to merge this together with the change from the first patch.
Best regards
Uwe