[PATCH 06/10] iio: dac: ltc2688: Constify struct regmap_bus

Javier Carrasco posted 10 patches 1 year, 7 months ago
[PATCH 06/10] iio: dac: ltc2688: Constify struct regmap_bus
Posted by Javier Carrasco 1 year, 7 months ago
`ltc2688_regmap_bus` is not modified and can be declared as const to
move its data to a read-only section.

Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
---
 drivers/iio/dac/ltc2688.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iio/dac/ltc2688.c b/drivers/iio/dac/ltc2688.c
index af50d2a95898..376dca163c91 100644
--- a/drivers/iio/dac/ltc2688.c
+++ b/drivers/iio/dac/ltc2688.c
@@ -918,7 +918,7 @@ static bool ltc2688_reg_writable(struct device *dev, unsigned int reg)
 	return false;
 }
 
-static struct regmap_bus ltc2688_regmap_bus = {
+static const struct regmap_bus ltc2688_regmap_bus = {
 	.read = ltc2688_spi_read,
 	.write = ltc2688_spi_write,
 	.read_flag_mask = LTC2688_READ_OPERATION,

-- 
2.40.1
Re: [PATCH 06/10] iio: dac: ltc2688: Constify struct regmap_bus
Posted by Nuno Sá 1 year, 7 months ago
On Wed, 2024-07-03 at 23:04 +0200, Javier Carrasco wrote:
> `ltc2688_regmap_bus` is not modified and can be declared as const to
> move its data to a read-only section.
> 
> Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
> ---

Indeed,

Reviewed-by: Nuno Sa <nuno.sa@analog.com>