[v1] arm64: dts: mediatek: mt8183-kukui: align thermal node names with bindings

[PATCH] arm64: dts: mediatek: mt8183-kukui: align thermal node names with bindings

Posted by Krzysztof Kozlowski 1 year, 7 months ago

Bindings expect thermal zones node name to follow certain pattern.
This fixes dtbs_check warning:

  mt8183-kukui-jacuzzi-burnet.dtb: thermal-zones: 'tboard1', 'tboard2'
    do not match any of the regexes: '^[a-zA-Z][a-zA-Z0-9\\-]{1,10}-thermal$', 'pinctrl-[0-9]+'

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
index 6345e969efae..3aea2643f21c 100644
--- a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
@@ -974,13 +974,13 @@ &ssusb {
 };
 
 &thermal_zones {
-	tboard1 {
+	tboard1-thermal {
 		polling-delay = <1000>; /* milliseconds */
 		polling-delay-passive = <0>; /* milliseconds */
 		thermal-sensors = <&tboard_thermistor1>;
 	};
 
-	tboard2 {
+	tboard2-thermal {
 		polling-delay = <1000>; /* milliseconds */
 		polling-delay-passive = <0>; /* milliseconds */
 		thermal-sensors = <&tboard_thermistor2>;
-- 
2.43.0

Re: [PATCH] arm64: dts: mediatek: mt8183-kukui: align thermal node names with bindings

Posted by Chen-Yu Tsai 1 year, 3 months ago

On Tue, Jul 2, 2024 at 10:51 PM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> Bindings expect thermal zones node name to follow certain pattern.
> This fixes dtbs_check warning:
>
>   mt8183-kukui-jacuzzi-burnet.dtb: thermal-zones: 'tboard1', 'tboard2'
>     do not match any of the regexes: '^[a-zA-Z][a-zA-Z0-9\\-]{1,10}-thermal$', 'pinctrl-[0-9]+'
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Reviewed-by: Chen-Yu Tsai <wenst@chromium.org>

This seems to have been sitting for a long time. Angelo, can you pick it up?


> ---
>  arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
> index 6345e969efae..3aea2643f21c 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi
> @@ -974,13 +974,13 @@ &ssusb {
>  };
>
>  &thermal_zones {
> -       tboard1 {
> +       tboard1-thermal {
>                 polling-delay = <1000>; /* milliseconds */
>                 polling-delay-passive = <0>; /* milliseconds */
>                 thermal-sensors = <&tboard_thermistor1>;
>         };
>
> -       tboard2 {
> +       tboard2-thermal {
>                 polling-delay = <1000>; /* milliseconds */
>                 polling-delay-passive = <0>; /* milliseconds */
>                 thermal-sensors = <&tboard_thermistor2>;
> --
> 2.43.0
>
>