arm64: dts: qcom: qrb4210-rb2: Correct max current draw for VBUS

[PATCH v3] arm64: dts: qcom: qrb4210-rb2: Correct max current draw for VBUS

Posted by Dang Huynh 1 year, 5 months ago

According to downstream sources, maximum current for PMI632 VBUS
is 1A.

Taken from msm-4.19 (631561973a034e46ccacd0e53ef65d13a40d87a4)
Line 685-687 in drivers/power/supply/qcom/qpnp-smb5.c

Fixes: a06a2f12f9e2 ("arm64: dts: qcom: qrb4210-rb2: enable USB-C port handling")
Reviewed-by: Luca Weiss <luca.weiss@fairphone.com>
Signed-off-by: Dang Huynh <danct12@riseup.net>
---
In previous patch series, there's a suggestion to correct maximum
current for PMI632 VBUS.

Unfortunately it didn't make it and probably forgotten.

Link to the suggestion mentioned:
https://lore.kernel.org/linux-arm-msm/CYMDEAJZ0TJK.K31XZB3E9QOG@fairphone.com/

Signed-off-by: Dang Huynh <danct12@riseup.net>
----
Changes in v3:
- Fixed wrong usage of electrical units.
- Link to v2: https://lore.kernel.org/r/20240701-qrd4210rb2-vbus-volt-v2-1-b7bcd2a78c8b@riseup.net

Changes in v2:
- Fixed typo (voltage -> ampere)
- Link to v1: https://lore.kernel.org/r/20240701-qrd4210rb2-vbus-volt-v1-1-5c06f8358436@riseup.net
---
 arch/arm64/boot/dts/qcom/qrb4210-rb2.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts b/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts
index 1c7de7f2db79..1888d99d398b 100644
--- a/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts
+++ b/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts
@@ -305,7 +305,7 @@ pmi632_ss_in: endpoint {
 
 &pmi632_vbus {
 	regulator-min-microamp = <500000>;
-	regulator-max-microamp = <3000000>;
+	regulator-max-microamp = <1000000>;
 	status = "okay";
 };
 

---
base-commit: 642a16ca7994a50d7de85715996a8ce171a5bdfb
change-id: 20240701-qrd4210rb2-vbus-volt-822764c7cfca

Best regards,
-- 
Dang Huynh <danct12@riseup.net>

Re: [PATCH v3] arm64: dts: qcom: qrb4210-rb2: Correct max current draw for VBUS

Posted by Bjorn Andersson 1 year, 5 months ago

On Tue, 02 Jul 2024 13:01:19 +0700, Dang Huynh wrote:
> According to downstream sources, maximum current for PMI632 VBUS
> is 1A.
> 
> Taken from msm-4.19 (631561973a034e46ccacd0e53ef65d13a40d87a4)
> Line 685-687 in drivers/power/supply/qcom/qpnp-smb5.c
> 
> 
> [...]

Applied, thanks!

[1/1] arm64: dts: qcom: qrb4210-rb2: Correct max current draw for VBUS
      commit: c6050d45cd372e4a34f9f501b30243caf2e810c6

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>

Re: [PATCH v3] arm64: dts: qcom: qrb4210-rb2: Correct max current draw for VBUS

Posted by Dmitry Baryshkov 1 year, 5 months ago

On Tue, Jul 02, 2024 at 01:01:19PM GMT, Dang Huynh wrote:
> According to downstream sources, maximum current for PMI632 VBUS
> is 1A.
> 
> Taken from msm-4.19 (631561973a034e46ccacd0e53ef65d13a40d87a4)
> Line 685-687 in drivers/power/supply/qcom/qpnp-smb5.c
> 
> Fixes: a06a2f12f9e2 ("arm64: dts: qcom: qrb4210-rb2: enable USB-C port handling")
> Reviewed-by: Luca Weiss <luca.weiss@fairphone.com>
> Signed-off-by: Dang Huynh <danct12@riseup.net>
> ---
> In previous patch series, there's a suggestion to correct maximum
> current for PMI632 VBUS.
> 
> Unfortunately it didn't make it and probably forgotten.
> 
> Link to the suggestion mentioned:
> https://lore.kernel.org/linux-arm-msm/CYMDEAJZ0TJK.K31XZB3E9QOG@fairphone.com/
> 
> Signed-off-by: Dang Huynh <danct12@riseup.net>
> ----
> Changes in v3:
> - Fixed wrong usage of electrical units.
> - Link to v2: https://lore.kernel.org/r/20240701-qrd4210rb2-vbus-volt-v2-1-b7bcd2a78c8b@riseup.net
> 
> Changes in v2:
> - Fixed typo (voltage -> ampere)
> - Link to v1: https://lore.kernel.org/r/20240701-qrd4210rb2-vbus-volt-v1-1-5c06f8358436@riseup.net
> ---
>  arch/arm64/boot/dts/qcom/qrb4210-rb2.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>

-- 
With best wishes
Dmitry