ARM: dts: nuvoton: wpcm450: align LED and GPIO keys node name with bindings

[PATCH] ARM: dts: nuvoton: wpcm450: align LED and GPIO keys node name with bindings

Posted by Krzysztof Kozlowski 1 year, 5 months ago

Bindings expect the LED and GPIO keys node names to follow certain
pattern, see dtbs_check warnings:

  nuvoton-wpcm450-supermicro-x9sci-ln4f.dtb: gpio-keys: 'uid' does not match any of the regexes: '^(button|event|key|switch|(button|event|key|switch)...

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 .../dts/nuvoton/nuvoton-wpcm450-supermicro-x9sci-ln4f.dts   | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm/boot/dts/nuvoton/nuvoton-wpcm450-supermicro-x9sci-ln4f.dts b/arch/arm/boot/dts/nuvoton/nuvoton-wpcm450-supermicro-x9sci-ln4f.dts
index b78c116cbc18..edb907f740bf 100644
--- a/arch/arm/boot/dts/nuvoton/nuvoton-wpcm450-supermicro-x9sci-ln4f.dts
+++ b/arch/arm/boot/dts/nuvoton/nuvoton-wpcm450-supermicro-x9sci-ln4f.dts
@@ -34,7 +34,7 @@ gpio-keys {
 		pinctrl-names = "default";
 		pinctrl-0 = <&key_pins>;
 
-		uid {
+		button-uid {
 			label = "UID button";
 			linux,code = <KEY_HOME>;
 			gpios = <&gpio0 14 GPIO_ACTIVE_HIGH>;
@@ -46,12 +46,12 @@ gpio-leds {
 		pinctrl-names = "default";
 		pinctrl-0 = <&led_pins>;
 
-		uid {
+		led-uid {
 			label = "UID";
 			gpios = <&gpio1 7 GPIO_ACTIVE_HIGH>;
 		};
 
-		heartbeat {
+		led-heartbeat {
 			label = "heartbeat";
 			gpios = <&gpio1 4 GPIO_ACTIVE_LOW>;
 		};
-- 
2.43.0

Re: [PATCH] ARM: dts: nuvoton: wpcm450: align LED and GPIO keys node name with bindings

Posted by Krzysztof Kozlowski 1 year, 4 months ago

On Mon, 01 Jul 2024 18:49:15 +0200, Krzysztof Kozlowski wrote:
> Bindings expect the LED and GPIO keys node names to follow certain
> pattern, see dtbs_check warnings:
> 
>   nuvoton-wpcm450-supermicro-x9sci-ln4f.dtb: gpio-keys: 'uid' does not match any of the regexes: '^(button|event|key|switch|(button|event|key|switch)...
> 
> 

No one took this patch and it waits on the list for very long.

Applied, thanks!

[1/1] ARM: dts: nuvoton: wpcm450: align LED and GPIO keys node name with bindings
      https://git.kernel.org/krzk/linux-dt/c/c7b44ed960ddecb3604d1e273494a932f00f384b

Best regards,
-- 
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Re: [PATCH] ARM: dts: nuvoton: wpcm450: align LED and GPIO keys node name with bindings

Posted by J. Neuschäfer 1 year, 5 months ago

On Mon, Jul 01, 2024 at 06:49:15PM +0200, Krzysztof Kozlowski wrote:
> Bindings expect the LED and GPIO keys node names to follow certain
> pattern, see dtbs_check warnings:
>
>   nuvoton-wpcm450-supermicro-x9sci-ln4f.dtb: gpio-keys: 'uid' does not match any of the regexes: '^(button|event|key|switch|(button|event|key|switch)...
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---

Looks good, thanks!

Reviewed-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>

>  .../dts/nuvoton/nuvoton-wpcm450-supermicro-x9sci-ln4f.dts   | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/boot/dts/nuvoton/nuvoton-wpcm450-supermicro-x9sci-ln4f.dts b/arch/arm/boot/dts/nuvoton/nuvoton-wpcm450-supermicro-x9sci-ln4f.dts
> index b78c116cbc18..edb907f740bf 100644
> --- a/arch/arm/boot/dts/nuvoton/nuvoton-wpcm450-supermicro-x9sci-ln4f.dts
> +++ b/arch/arm/boot/dts/nuvoton/nuvoton-wpcm450-supermicro-x9sci-ln4f.dts
> @@ -34,7 +34,7 @@ gpio-keys {
>  		pinctrl-names = "default";
>  		pinctrl-0 = <&key_pins>;
>
> -		uid {
> +		button-uid {
>  			label = "UID button";
>  			linux,code = <KEY_HOME>;
>  			gpios = <&gpio0 14 GPIO_ACTIVE_HIGH>;
> @@ -46,12 +46,12 @@ gpio-leds {
>  		pinctrl-names = "default";
>  		pinctrl-0 = <&led_pins>;
>
> -		uid {
> +		led-uid {
>  			label = "UID";
>  			gpios = <&gpio1 7 GPIO_ACTIVE_HIGH>;
>  		};
>
> -		heartbeat {
> +		led-heartbeat {
>  			label = "heartbeat";
>  			gpios = <&gpio1 4 GPIO_ACTIVE_LOW>;
>  		};
> --
> 2.43.0
>