[v1] HID: mcp2221: Remove unneeded semicolon

[PATCH] HID: mcp2221: Remove unneeded semicolon

Posted by Chen Ni 1 year, 5 months ago

Remove unneeded semicolon.
This is detected by coccinelle.

Fixes: 960f9df7c620 ("HID: mcp2221: add ADC/DAC support via iio subsystem")
Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
---
 drivers/hid/hid-mcp2221.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/hid/hid-mcp2221.c b/drivers/hid/hid-mcp2221.c
index da5ea5a23b08..0f93c22a479f 100644
--- a/drivers/hid/hid-mcp2221.c
+++ b/drivers/hid/hid-mcp2221.c
@@ -1048,7 +1048,7 @@ static int mcp_iio_channels(struct mcp2221 *mcp)
 			break;
 		default:
 			continue;
-		};
+		}
 
 		chan->type = IIO_VOLTAGE;
 		chan->indexed = 1;
-- 
2.25.1

Re: [PATCH] HID: mcp2221: Remove unneeded semicolon

Posted by Jonathan Cameron 1 year, 5 months ago

On Mon, 1 Jul 2024 15:16:39 +0800
Chen Ni <nichen@iscas.ac.cn> wrote:

> Remove unneeded semicolon.
> This is detected by coccinelle.
> 
> Fixes: 960f9df7c620 ("HID: mcp2221: add ADC/DAC support via iio subsystem")

Fixes tag not appropriate for this one as it's not a bug.

> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
Otherwise looks fine to me.

Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

> ---
>  drivers/hid/hid-mcp2221.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hid/hid-mcp2221.c b/drivers/hid/hid-mcp2221.c
> index da5ea5a23b08..0f93c22a479f 100644
> --- a/drivers/hid/hid-mcp2221.c
> +++ b/drivers/hid/hid-mcp2221.c
> @@ -1048,7 +1048,7 @@ static int mcp_iio_channels(struct mcp2221 *mcp)
>  			break;
>  		default:
>  			continue;
> -		};
> +		}
>  
>  		chan->type = IIO_VOLTAGE;
>  		chan->indexed = 1;

Re: [PATCH] HID: mcp2221: Remove unneeded semicolon

Posted by Andi Shyti 1 year, 5 months ago

On Mon, Jul 01, 2024 at 03:16:39PM GMT, Chen Ni wrote:
> Remove unneeded semicolon.

Please be a bit more precise: "Remove unnecessary semicolon at
the end of the switch statement"

> This is detected by coccinelle.
> 
> Fixes: 960f9df7c620 ("HID: mcp2221: add ADC/DAC support via iio subsystem")

No need for the Fixes tag here.

Andi

> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
> ---
>  drivers/hid/hid-mcp2221.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hid/hid-mcp2221.c b/drivers/hid/hid-mcp2221.c
> index da5ea5a23b08..0f93c22a479f 100644
> --- a/drivers/hid/hid-mcp2221.c
> +++ b/drivers/hid/hid-mcp2221.c
> @@ -1048,7 +1048,7 @@ static int mcp_iio_channels(struct mcp2221 *mcp)
>  			break;
>  		default:
>  			continue;
> -		};
> +		}
>  
>  		chan->type = IIO_VOLTAGE;
>  		chan->indexed = 1;
> -- 
> 2.25.1
>