[PATCH] net: stmmac: dwmac-qcom-ethqos: fix error array size

YijieYang posted 1 patch 1 year, 5 months ago
drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] net: stmmac: dwmac-qcom-ethqos: fix error array size
Posted by YijieYang 1 year, 5 months ago
From: Yijie Yang <quic_yijiyang@quicinc.com>

Correct member @num_por with size of right array @emac_v4_0_0_por for
struct ethqos_emac_driver_data @emac_v4_0_0_data.

Cc: stable@vger.kernel.org
Fixes: 8c4d92e82d50 ("net: stmmac: dwmac-qcom-ethqos: add support for emac4 on sa8775p platforms")
Signed-off-by: Yijie Yang <quic_yijiyang@quicinc.com>
---
 drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c
index 80eb72bc6311..e8a1701cdb7c 100644
--- a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c
+++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c
@@ -272,7 +272,7 @@ static const struct ethqos_emac_por emac_v4_0_0_por[] = {
 
 static const struct ethqos_emac_driver_data emac_v4_0_0_data = {
 	.por = emac_v4_0_0_por,
-	.num_por = ARRAY_SIZE(emac_v3_0_0_por),
+	.num_por = ARRAY_SIZE(emac_v4_0_0_por),
 	.rgmii_config_loopback_en = false,
 	.has_emac_ge_3 = true,
 	.link_clk_name = "phyaux",

base-commit: 0fc4bfab2cd45f9acb86c4f04b5191e114e901ed
-- 
2.34.1
Re: [PATCH] net: stmmac: dwmac-qcom-ethqos: fix error array size
Posted by Bartosz Golaszewski 1 year, 5 months ago
On Mon, Jul 1, 2024 at 3:48 AM YijieYang <quic_yijiyang@quicinc.com> wrote:
>
> From: Yijie Yang <quic_yijiyang@quicinc.com>
>
> Correct member @num_por with size of right array @emac_v4_0_0_por for
> struct ethqos_emac_driver_data @emac_v4_0_0_data.
>
> Cc: stable@vger.kernel.org
> Fixes: 8c4d92e82d50 ("net: stmmac: dwmac-qcom-ethqos: add support for emac4 on sa8775p platforms")
> Signed-off-by: Yijie Yang <quic_yijiyang@quicinc.com>
> ---
>  drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c
> index 80eb72bc6311..e8a1701cdb7c 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c
> @@ -272,7 +272,7 @@ static const struct ethqos_emac_por emac_v4_0_0_por[] = {
>
>  static const struct ethqos_emac_driver_data emac_v4_0_0_data = {
>         .por = emac_v4_0_0_por,
> -       .num_por = ARRAY_SIZE(emac_v3_0_0_por),
> +       .num_por = ARRAY_SIZE(emac_v4_0_0_por),
>         .rgmii_config_loopback_en = false,
>         .has_emac_ge_3 = true,
>         .link_clk_name = "phyaux",
>
> base-commit: 0fc4bfab2cd45f9acb86c4f04b5191e114e901ed
> --
> 2.34.1
>
>

Oops, that's on me. Thanks for catching it.

Reviewed-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>