Hi Tejun,

A significant amount of kernel code formats the workqueue name before it
calls a workqueue creation function. This patch series simplifies such kernel
code and modifies the create*_workqueue() macros such that these accept a
printf-style format string and argument list.

The approach of this patch series is as follows:
1. Introduce the create*_workqueue2() macros that accept a printf-style
   format string and argument list.
2. Convert all workqueue creation calls that might pass a name that includes
   a formatting character from create*_workqueue(name) into
   create*_workqueue2("%s", name).
3. Convert all workqueue creation code that is preceded by workqueue name
   formatting code into a create*_workqueue2(fmt, args) call.
4. Convert all create*_workqueue2() calls into create*_workqueue() calls,
   remove the original create*_workqueue() calls and rename the new
   create*_workqueue2() macros into create*_workqueue().

Please consider this patch series for the next merge window.

Thanks,

Bart.

Bart Van Assche (53):
  workqueue: Introduce the create*_workqueue2() macros
  dmaengine: idxd: Switch to create*_workqueue2()
  drm/amdgpu: Switch to create*_workqueue2()
  media: i2c: adv7511: Switch to create*_workqueue2()
  media: cobalt: Switch to create*_workqueue2()
  media: dm1105: Switch to create*_workqueue2()
  misc: bcm_vk: Switch to create*_workqueue2()
  net: amd-xgbe: Switch to create*_workqueue2()
  net: atlantic: Switch to create*_workqueue2()
  net: mvpp2: Switch to create*_workqueue2()
  remoteproc: stm32: Switch to create*_workqueue2()
  mm/z3fold: Switch to create*_workqueue2()
  usb: typec: tcpm: Switch to create*_workqueue2()
  net/qla3xxx: Switch to create*_workqueue2()
  sfc: Switch to create*_workqueue2()
  wifi: zd1211rw: Switch to create*_workqueue2()
  power: supply: mt6370: Switch to create*_workqueue2()
  remoteproc: imx_rproc: Switch to create*_workqueue2()
  scsi: hisi_sas: Switch to create*_workqueue2()
  scsi: mpt3sas: Switch to create*_workqueue2()
  accel/habanalabs: Simplify the workqueue creation calls
  crypto: safexcel - Simplify a create*_workqueue() call
  pds_core: Simplify a create*_workqueue() call
  net: bna: Simplify a create*_workqueue() call
  net/mlx5: Simplify the create*_workqueue() calls
  net: lan966x: Simplify a create*_workqueue() call
  net: sparx5: Simplify the create*_workqueue() calls
  net: mscc: ocelot: Simplify a create*_workqueue() call
  net: qed: Simplify a create*_workqueue() call
  net: stmmac: Simplify a create*_workqueue() call
  nfc: mrvl: Simplify a create*_workqueue() call
  scsi: ibmvscsi_tgt: Simplify a create*_workqueue() call
  scsi: libsas: Simplify the create*_workqueue() calls
  scsi: mpi3mr: Simplify a create*_workqueue() call
  scsi: qedf: Simplify the create*_workqueue() calls
  scsi: qedi: Simplify the create*_workqueue() calls
  scsi: qla2xxx: Simplify the create*_workqueue() calls
  scsi: qla4xxx: Simplify a create*_workqueue() call
  scsi: vmw_pvscsi: Simplify a create*_workqueue() call
  scsi: myrb: Simplify the create*_workqueue() calls
  scsi: myrs: Simplify the create*_workqueue() calls
  scsi: stex: Simplify the create*_workqueue() calls
  scsi: fcoe: Simplify the create*_workqueue() calls
  scsi: snic: Simplify the create*_workqueue() calls
  scsi: scsi_transport_fc: Simplify the create*_workqueue() calls
  scsi: core: Simplify the alloc_workqueue() calls
  serial: max3100: Simplify a create*_workqueue() call
  scsi: ufs: Simplify the create*_workqueue() calls
  usb: typec: ucsi: Simplify a create*_workqueue() call
  cifs: Simplify a create*_workqueue() call
  mac802154: Simplify the create*_workqueue() calls
  nfc: nci: Simplify the create*_workqueue() calls
  workqueue: Rename create*_workqueue2() into create*_workqueue()

 drivers/accel/habanalabs/common/device.c      | 25 +++++++++----------
 drivers/crypto/inside-secure/safexcel.c       |  4 +--
 drivers/dma/idxd/cdev.c                       |  2 +-
 drivers/dma/idxd/init.c                       |  2 +-
 drivers/gpu/drm/amd/amdgpu/amdgpu_reset.c     |  2 +-
 drivers/media/i2c/adv7511-v4l2.c              |  2 +-
 drivers/media/pci/cobalt/cobalt-driver.c      |  2 +-
 drivers/media/pci/dm1105/dm1105.c             |  2 +-
 drivers/misc/bcm-vk/bcm_vk_dev.c              |  2 +-
 drivers/net/ethernet/amd/pds_core/main.c      |  7 ++----
 drivers/net/ethernet/amd/xgbe/xgbe-drv.c      |  4 +--
 .../net/ethernet/aquantia/atlantic/aq_main.c  |  2 +-
 drivers/net/ethernet/brocade/bna/bnad.c       |  4 +--
 drivers/net/ethernet/brocade/bna/bnad.h       |  1 -
 .../net/ethernet/marvell/mvpp2/mvpp2_main.c   |  3 ++-
 drivers/net/ethernet/mellanox/mlx5/core/cmd.c | 12 ++-------
 .../net/ethernet/mellanox/mlx5/core/health.c  | 10 ++------
 .../mellanox/mlx5/core/sf/vhca_event.c        |  5 ++--
 .../microchip/lan966x/lan966x_ethtool.c       |  7 ++----
 .../microchip/sparx5/sparx5_ethtool.c         |  6 ++---
 .../ethernet/microchip/sparx5/sparx5_main.c   |  6 ++---
 drivers/net/ethernet/mscc/ocelot_stats.c      |  6 ++---
 drivers/net/ethernet/qlogic/qed/qed_sriov.c   |  9 +++----
 drivers/net/ethernet/qlogic/qla3xxx.c         |  2 +-
 drivers/net/ethernet/sfc/efx_common.c         |  3 ++-
 drivers/net/ethernet/sfc/falcon/efx.c         |  3 ++-
 drivers/net/ethernet/sfc/siena/efx_common.c   |  3 ++-
 drivers/net/ethernet/stmicro/stmmac/stmmac.h  |  1 -
 .../net/ethernet/stmicro/stmmac/stmmac_main.c | 11 +++-----
 drivers/net/wireless/zydas/zd1211rw/zd_usb.c  |  2 +-
 drivers/nfc/nfcmrvl/fw_dnld.c                 |  8 +++---
 drivers/power/supply/mt6370-charger.c         |  2 +-
 drivers/remoteproc/imx_rproc.c                |  2 +-
 drivers/remoteproc/stm32_rproc.c              |  2 +-
 drivers/scsi/fcoe/fcoe_sysfs.c                |  7 +-----
 drivers/scsi/hisi_sas/hisi_sas_main.c         |  2 +-
 drivers/scsi/hosts.c                          |  9 +++----
 drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c      |  4 +--
 drivers/scsi/libsas/sas_init.c                |  9 +++----
 drivers/scsi/mpi3mr/mpi3mr_fw.c               |  4 +--
 drivers/scsi/mpt3sas/mpt3sas_base.c           |  4 +--
 drivers/scsi/myrb.c                           |  5 ++--
 drivers/scsi/myrb.h                           |  1 -
 drivers/scsi/myrs.c                           |  5 ++--
 drivers/scsi/myrs.h                           |  1 -
 drivers/scsi/qedf/qedf_main.c                 | 17 +++++--------
 drivers/scsi/qedi/qedi_main.c                 |  8 +++---
 drivers/scsi/qla2xxx/qla_os.c                 | 10 ++++----
 drivers/scsi/qla4xxx/ql4_os.c                 |  5 ++--
 drivers/scsi/scsi_transport_fc.c              |  4 +--
 drivers/scsi/snic/snic_main.c                 |  5 ++--
 drivers/scsi/stex.c                           |  6 ++---
 drivers/scsi/vmw_pvscsi.c                     |  8 ++----
 drivers/tty/serial/max3100.c                  |  4 +--
 drivers/ufs/core/ufshcd.c                     | 13 +++-------
 drivers/usb/typec/tcpm/fusb302.c              |  2 +-
 drivers/usb/typec/ucsi/ucsi.c                 |  9 ++-----
 fs/smb/client/smbdirect.c                     |  3 +--
 include/linux/mlx5/driver.h                   |  5 ----
 include/linux/workqueue.h                     | 15 +++++------
 include/scsi/fcoe_sysfs.h                     |  1 -
 include/scsi/scsi_host.h                      |  1 -
 include/scsi/scsi_transport_fc.h              |  3 ---
 mm/z3fold.c                                   |  4 +--
 net/mac802154/main.c                          |  7 +++---
 net/nfc/nci/core.c                            | 13 +++++-----
 66 files changed, 135 insertions(+), 223 deletions(-)

Hello, Bart.

On Sun, Jun 30, 2024 at 03:26:18PM -0700, Bart Van Assche wrote:
> 1. Introduce the create*_workqueue2() macros that accept a printf-style
>    format string and argument list.

I don't think we want to update create_workqueue() interface at all. Please
convert them to use alloc_workqueue() instead. Once we convert all
create_workqueue() users then we can just drop the old interface.

The challenge with converging to alloc_workqueue() interface is that the
conversion needs to explicitly decide whether WQ_MEM_RECLAIM is needed or
not but that shouldn't be *too* difficult.

Thanks.

-- 
tejun

On 7/1/24 12:39 PM, Tejun Heo wrote:
> On Sun, Jun 30, 2024 at 03:26:18PM -0700, Bart Van Assche wrote:
>> 1. Introduce the create*_workqueue2() macros that accept a printf-style
>>     format string and argument list.
> 
> I don't think we want to update create_workqueue() interface at all. Please
> convert them to use alloc_workqueue() instead. Once we convert all
> create_workqueue() users then we can just drop the old interface.
> 
> The challenge with converging to alloc_workqueue() interface is that the
> conversion needs to explicitly decide whether WQ_MEM_RECLAIM is needed or
> not but that shouldn't be *too* difficult.

The create*_workqueue() macros are used about 270 times in the Linux
kernel (the macro names also occur in some comments):

$ git grep -nHEw 
'create_workqueue|create_freezable_workqueue|create_singlethread_workqueue' 
| grep -Ev 'Documentation/|include/linux/workqueue' | wc -l
     271

That's too much for a single patch series. I can start with converting
the SCSI workqueue creation code.

Thanks,

Bart.

Hello, Bart.

On Mon, Jul 01, 2024 at 01:13:57PM -0700, Bart Van Assche wrote:
> The create*_workqueue() macros are used about 270 times in the Linux
> kernel (the macro names also occur in some comments):
> 
> $ git grep -nHEw
> 'create_workqueue|create_freezable_workqueue|create_singlethread_workqueue'
> | grep -Ev 'Documentation/|include/linux/workqueue' | wc -l
>     271
> 
> That's too much for a single patch series. I can start with converting
> the SCSI workqueue creation code.

Yeah, it's been on the to-do list for a long time. Starting with SCSI sounds
great.

Thank you.

-- 
tejun