Add clocks and clock-names for brcm4329-fmac.

Signed-off-by: Jacobe Zang <jacobe.zang@wesion.com>
---
 .../bindings/net/wireless/brcm,bcm4329-fmac.yaml          | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml b/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml
index 2c2093c77ec9a..f542b60e44dc4 100644
--- a/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml
+++ b/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml
@@ -122,6 +122,14 @@ properties:
       NVRAM. This would normally be filled in by the bootloader from platform
       configuration data.
 
+  clocks:
+    items:
+      - description: Wi-Fi RTC clock
+
+  clock-names:
+    items:
+      - const: lpo
+
 required:
   - compatible
   - reg
-- 
2.34.1

On 6/30/2024 9:36 AM, Jacobe Zang wrote:
> Add clocks and clock-names for brcm4329-fmac.

you can add my....

Reviewed-by: Arend van Spriel <arend.vanspriel@broadcom.com>
> Signed-off-by: Jacobe Zang <jacobe.zang@wesion.com>
> ---
>   .../bindings/net/wireless/brcm,bcm4329-fmac.yaml          | 8 ++++++++
>   1 file changed, 8 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml b/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml
> index 2c2093c77ec9a..f542b60e44dc4 100644
> --- a/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml
> +++ b/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml
> @@ -122,6 +122,14 @@ properties:
>         NVRAM. This would normally be filled in by the bootloader from platform
>         configuration data.
>   
> +  clocks:
> +    items:
> +      - description: Wi-Fi RTC clock

Having a few problems with the description. There is only one LPO clock 
input on the 43752 chipset. From the AMPAK AP6275P datasheet:

| 31 | LPO_IN | I | External Low Power Clock input (32.768KHz) |

I would suggest to use the description from the datasheet or something 
similar.

On 30/06/2024 09:36, Jacobe Zang wrote:
> Add clocks and clock-names for brcm4329-fmac.
> 
> Signed-off-by: Jacobe Zang <jacobe.zang@wesion.com>
> ---
>  .../bindings/net/wireless/brcm,bcm4329-fmac.yaml          | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml b/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml
> index 2c2093c77ec9a..f542b60e44dc4 100644
> --- a/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml
> +++ b/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml
> @@ -122,6 +122,14 @@ properties:
>        NVRAM. This would normally be filled in by the bootloader from platform
>        configuration data.
>  
> +  clocks:
> +    items:
> +      - description: Wi-Fi RTC clock
> +
> +  clock-names:
> +    items:
> +      - const: lpo

This does not match your DTS. DTS is different, e.g. does not have
compatible. There are required properties here, some of which are required.

Best regards,
Krzysztof

Hi Jacobe,

Am 30.06.24 um 09:36 schrieb Jacobe Zang:
> Add clocks and clock-names for brcm4329-fmac.
thanks for taking care of this. According to CYW43455 datasheet which is
also covered by this binding, there are more clocks in the hardware
design, so i suggest to reword subject and commit message that this
patch only adds the low power clock.
>
> Signed-off-by: Jacobe Zang <jacobe.zang@wesion.com>
> ---
>   .../bindings/net/wireless/brcm,bcm4329-fmac.yaml          | 8 ++++++++
>   1 file changed, 8 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml b/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml
> index 2c2093c77ec9a..f542b60e44dc4 100644
> --- a/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml
> +++ b/Documentation/devicetree/bindings/net/wireless/brcm,bcm4329-fmac.yaml
> @@ -122,6 +122,14 @@ properties:
>         NVRAM. This would normally be filled in by the bootloader from platform
>         configuration data.
>
> +  clocks:
> +    items:
> +      - description: Wi-Fi RTC clock
> +
> +  clock-names:
> +    items:
> +      - const: lpo
> +
>   required:
>     - compatible
>     - reg