perf report: Calling available function for stats printing

[PATCH] perf report: Calling available function for stats printing

Posted by Abhishek Dubey 1 year, 7 months ago

For printing dump_trace, just use existing stats_print()
function.

Signed-off-by: Abhishek Dubey <adubey@linux.ibm.com>
---
 tools/perf/builtin-report.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
index 9718770facb5..6edc0d4ce6fb 100644
--- a/tools/perf/builtin-report.c
+++ b/tools/perf/builtin-report.c
@@ -1089,8 +1089,7 @@ static int __cmd_report(struct report *rep)
 			perf_session__fprintf_dsos(session, stdout);
 
 		if (dump_trace) {
-			perf_session__fprintf_nr_events(session, stdout);
-			evlist__fprintf_nr_events(session->evlist, stdout);
+			stats_print(rep);
 			return 0;
 		}
 	}
-- 
2.44.0

Re: [PATCH] perf report: Calling available function for stats printing

Posted by Namhyung Kim 1 year, 7 months ago

On Fri, 28 Jun 2024 14:32:24 -0400, Abhishek Dubey wrote:

> For printing dump_trace, just use existing stats_print()
> function.
> 
> 

Applied to perf-tools-next, thanks!

Best regards,
Namhyung

Re: [PATCH] perf report: Calling available function for stats printing

Posted by Ian Rogers 1 year, 7 months ago

On Fri, Jun 28, 2024 at 11:32 AM Abhishek Dubey <adubey@linux.ibm.com> wrote:
>
> For printing dump_trace, just use existing stats_print()
> function.
>
> Signed-off-by: Abhishek Dubey <adubey@linux.ibm.com>

Reviewed-by: Ian Rogers <irogers@google.com>

Thanks,
Ian

> ---
>  tools/perf/builtin-report.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
> index 9718770facb5..6edc0d4ce6fb 100644
> --- a/tools/perf/builtin-report.c
> +++ b/tools/perf/builtin-report.c
> @@ -1089,8 +1089,7 @@ static int __cmd_report(struct report *rep)
>                         perf_session__fprintf_dsos(session, stdout);
>
>                 if (dump_trace) {
> -                       perf_session__fprintf_nr_events(session, stdout);
> -                       evlist__fprintf_nr_events(session->evlist, stdout);
> +                       stats_print(rep);
>                         return 0;
>                 }
>         }
> --
> 2.44.0
>